Re: [NFS] [PATCH 001 of 3] knfsd: Use recv_msg to get peer address for NFSD instead of code-copying

2007-03-05 Thread Neil Brown
On Monday March 5, [EMAIL PROTECTED] wrote: > On Friday 02 March 2007 05:28, NeilBrown wrote: > > The sunrpc server code needs to know the source and destination address > > for UDP packets so it can reply properly. > > It currently copies code out of the network stack to pick the pieces out > >

Re: [NFS] [PATCH 001 of 3] knfsd: Use recv_msg to get peer address for NFSD instead of code-copying

2007-03-05 Thread Neil Brown
On Monday March 5, [EMAIL PROTECTED] wrote: > > Hi Neil, > > here's another minor comment: > > On Friday 02 March 2007 05:28, NeilBrown wrote: > > +static inline void svc_udp_get_dest_address(struct svc_rqst *rqstp, > > + struct cmsghdr *cmh) > > { > >

Re: [NFS] [PATCH 001 of 3] knfsd: Use recv_msg to get peer address for NFSD instead of code-copying

2007-03-05 Thread Olaf Kirch
Hi Neil, here's another minor comment: On Friday 02 March 2007 05:28, NeilBrown wrote: > +static inline void svc_udp_get_dest_address(struct svc_rqst *rqstp, > + struct cmsghdr *cmh) > { > switch (rqstp->rq_sock->sk_sk->sk_family) { > case

Re: [NFS] [PATCH 001 of 3] knfsd: Use recv_msg to get peer address for NFSD instead of code-copying

2007-03-05 Thread Olaf Kirch
On Friday 02 March 2007 05:28, NeilBrown wrote: > The sunrpc server code needs to know the source and destination address > for UDP packets so it can reply properly. > It currently copies code out of the network stack to pick the pieces out > of the skb. > This is ugly and causes compile problems

Re: [NFS] [PATCH 001 of 3] knfsd: Use recv_msg to get peer address for NFSD instead of code-copying

2007-03-05 Thread Olaf Kirch
On Friday 02 March 2007 05:28, NeilBrown wrote: The sunrpc server code needs to know the source and destination address for UDP packets so it can reply properly. It currently copies code out of the network stack to pick the pieces out of the skb. This is ugly and causes compile problems with

Re: [NFS] [PATCH 001 of 3] knfsd: Use recv_msg to get peer address for NFSD instead of code-copying

2007-03-05 Thread Olaf Kirch
Hi Neil, here's another minor comment: On Friday 02 March 2007 05:28, NeilBrown wrote: +static inline void svc_udp_get_dest_address(struct svc_rqst *rqstp, + struct cmsghdr *cmh) { switch (rqstp-rq_sock-sk_sk-sk_family) { case AF_INET: {

Re: [NFS] [PATCH 001 of 3] knfsd: Use recv_msg to get peer address for NFSD instead of code-copying

2007-03-05 Thread Neil Brown
On Monday March 5, [EMAIL PROTECTED] wrote: Hi Neil, here's another minor comment: On Friday 02 March 2007 05:28, NeilBrown wrote: +static inline void svc_udp_get_dest_address(struct svc_rqst *rqstp, + struct cmsghdr *cmh) { switch

Re: [NFS] [PATCH 001 of 3] knfsd: Use recv_msg to get peer address for NFSD instead of code-copying

2007-03-05 Thread Neil Brown
On Monday March 5, [EMAIL PROTECTED] wrote: On Friday 02 March 2007 05:28, NeilBrown wrote: The sunrpc server code needs to know the source and destination address for UDP packets so it can reply properly. It currently copies code out of the network stack to pick the pieces out of the

[PATCH 001 of 3] knfsd: Use recv_msg to get peer address for NFSD instead of code-copying

2007-03-01 Thread NeilBrown
The sunrpc server code needs to know the source and destination address for UDP packets so it can reply properly. It currently copies code out of the network stack to pick the pieces out of the skb. This is ugly and causes compile problems with the IPv6 stuff. So, rip that out and use recv_msg

[PATCH 001 of 3] knfsd: Use recv_msg to get peer address for NFSD instead of code-copying

2007-03-01 Thread NeilBrown
The sunrpc server code needs to know the source and destination address for UDP packets so it can reply properly. It currently copies code out of the network stack to pick the pieces out of the skb. This is ugly and causes compile problems with the IPv6 stuff. So, rip that out and use recv_msg