Re: [PATCH 01/10] Task Containers(V11): Basic task container framework

[YAMAMOTO Takashi]

> +extern void container_init_smp(void);

> +static inline void container_init_smp(void) {}

stale prototypes?

YAMAMOTO Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 01/10] Task Containers(V11): Basic task container framework

[Paul Menage]

On 7/26/07, YAMAMOTO Takashi <[EMAIL PROTECTED]> wrote:
> > +Other fields in the container_subsys object include:
>
> > +- hierarchy: an index indicating which hierarchy, if any, this
> > +  subsystem is currently attached to. If this is -1, then the
> > +  subsystem is not attached to any hierarchy, and all tasks should be
> > +  considered to be members of the subsystem's top_container. It should
> > +  be initialized to -1.
>
> stale info?

Yes, I think so. I really need to do a proper pass over
Documentation/containers.txt one more time following a bunch of recent
changes.

>
> > +struct container {
>
> > + struct containerfs_root *root;
> > + struct container *top_container;
> > +};
>
> can cont->top_container be different from than >root.top_container?

No, I guess it can't. And there are only a couple of places using
cont->top_container now, so I should probably remove it.

Thanks,

Paul
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 01/10] Task Containers(V11): Basic task container framework

[Paul Menage]

On 7/26/07, YAMAMOTO Takashi [EMAIL PROTECTED] wrote:
  +Other fields in the container_subsys object include:

  +- hierarchy: an index indicating which hierarchy, if any, this
  +  subsystem is currently attached to. If this is -1, then the
  +  subsystem is not attached to any hierarchy, and all tasks should be
  +  considered to be members of the subsystem's top_container. It should
  +  be initialized to -1.

 stale info?

Yes, I think so. I really need to do a proper pass over
Documentation/containers.txt one more time following a bunch of recent
changes.


  +struct container {

  + struct containerfs_root *root;
  + struct container *top_container;
  +};

 can cont-top_container be different from than cont-root.top_container?

No, I guess it can't. And there are only a couple of places using
cont-top_container now, so I should probably remove it.

Thanks,

Paul
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 01/10] Task Containers(V11): Basic task container framework

[YAMAMOTO Takashi]

 +extern void container_init_smp(void);

 +static inline void container_init_smp(void) {}

stale prototypes?

YAMAMOTO Takashi
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 01/10] Task Containers(V11): Basic task container framework

[YAMAMOTO Takashi]

> +Other fields in the container_subsys object include:

> +- hierarchy: an index indicating which hierarchy, if any, this
> +  subsystem is currently attached to. If this is -1, then the
> +  subsystem is not attached to any hierarchy, and all tasks should be
> +  considered to be members of the subsystem's top_container. It should
> +  be initialized to -1.

stale info?

> +struct container {

> + struct containerfs_root *root;
> + struct container *top_container;
> +};

can cont->top_container be different from than >root.top_container?

YAMAMOTO Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 01/10] Task Containers(V11): Basic task container framework

[YAMAMOTO Takashi]

 +Other fields in the container_subsys object include:

 +- hierarchy: an index indicating which hierarchy, if any, this
 +  subsystem is currently attached to. If this is -1, then the
 +  subsystem is not attached to any hierarchy, and all tasks should be
 +  considered to be members of the subsystem's top_container. It should
 +  be initialized to -1.

stale info?

 +struct container {

 + struct containerfs_root *root;
 + struct container *top_container;
 +};

can cont-top_container be different from than cont-root.top_container?

YAMAMOTO Takashi
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/