Re: [PATCH 01/10] mfd: Add TI LMU driver

2014-02-19 Thread Lee Jones
> + pdata->en_gpio = of_get_named_gpio(node, "ti,enable-gpio", 0); > >>> > >>>There is a global DT property for this already. > >> > >>I've not found it yet, but I agree it looks like general property. > >>So I'll replace "ti,enable-gpio" with "ti,lmu-en-gpio". > > > >Just re-use "gpio-enable".

Re: [PATCH 01/10] mfd: Add TI LMU driver

2014-02-18 Thread Milo Kim
Hi Lee, On 02/18/2014 05:21 PM, Lee Jones wrote: + pdata->en_gpio = of_get_named_gpio(node, "ti,enable-gpio", 0); There is a global DT property for this already. I've not found it yet, but I agree it looks like general property. So I'll replace "ti,enable-gpio" with "ti,lmu-en-gpio".

Re: [PATCH 01/10] mfd: Add TI LMU driver

2014-02-18 Thread Lee Jones
> >>+static const struct resource lm3633_effect_resources[] = { > >>+ { > >>+ .name = LM3633_EFFECT_BL0_RAMPUP, > >>+ .flags = IORESOURCE_REG, > >>+ .start = LM3633_EFFECT_REGISTER(BL0_RAMPUP), > >>+ }, > >>+ { > >>+ .name = LM3633_EFFECT_PTN_HIGHB

Re: [PATCH 01/10] mfd: Add TI LMU driver

2014-02-17 Thread Milo Kim
Hi Lee, On 02/17/2014 06:57 PM, Lee Jones wrote: +static const struct resource lm3633_effect_resources[] = { + { + .name = LM3633_EFFECT_BL0_RAMPUP, + .flags = IORESOURCE_REG, + .start = LM3633_EFFECT_REGISTER(BL0_RAMPUP), + }, + { +

Re: [PATCH 01/10] mfd: Add TI LMU driver

2014-02-17 Thread Lee Jones
> TI LMU (Lighting Management Unit) driver supports lighting devices such like > LM3532, LM3631, LM3633, LM3695 and LM3697. > > LMU devices has common features as below. > - I2C interface for accessing device registers > - Hardware enable pin control > - Backlight brightness control > - Li

[PATCH 01/10] mfd: Add TI LMU driver

2014-02-13 Thread Milo Kim
TI LMU (Lighting Management Unit) driver supports lighting devices such like LM3532, LM3631, LM3633, LM3695 and LM3697. LMU devices has common features as below. - I2C interface for accessing device registers - Hardware enable pin control - Backlight brightness control - Light effect drive