Re: [PATCH 01/10] mm: Assign id to every memcg-aware shrinker

2018-03-28 Thread Vladimir Davydov
On Wed, Mar 28, 2018 at 01:30:20PM +0300, Kirill Tkhai wrote: > On 27.03.2018 18:48, Vladimir Davydov wrote: > > On Tue, Mar 27, 2018 at 06:09:20PM +0300, Kirill Tkhai wrote: > >> diff --git a/mm/vmscan.c b/mm/vmscan.c > >> index 8fcd9f8d7390..91b5120b924f 100644 > >> --- a/mm/vmscan.c

Re: [PATCH 01/10] mm: Assign id to every memcg-aware shrinker

2018-03-28 Thread Vladimir Davydov
On Wed, Mar 28, 2018 at 01:30:20PM +0300, Kirill Tkhai wrote: > On 27.03.2018 18:48, Vladimir Davydov wrote: > > On Tue, Mar 27, 2018 at 06:09:20PM +0300, Kirill Tkhai wrote: > >> diff --git a/mm/vmscan.c b/mm/vmscan.c > >> index 8fcd9f8d7390..91b5120b924f 100644 > >> --- a/mm/vmscan.c

Re: [PATCH 01/10] mm: Assign id to every memcg-aware shrinker

2018-03-28 Thread Kirill Tkhai
On 27.03.2018 18:48, Vladimir Davydov wrote: > On Tue, Mar 27, 2018 at 06:09:20PM +0300, Kirill Tkhai wrote: >> diff --git a/mm/vmscan.c b/mm/vmscan.c >> index 8fcd9f8d7390..91b5120b924f 100644 >> --- a/mm/vmscan.c >> +++ b/mm/vmscan.c >> @@ -159,6 +159,56 @@ unsigned long

Re: [PATCH 01/10] mm: Assign id to every memcg-aware shrinker

2018-03-28 Thread Kirill Tkhai
On 27.03.2018 18:48, Vladimir Davydov wrote: > On Tue, Mar 27, 2018 at 06:09:20PM +0300, Kirill Tkhai wrote: >> diff --git a/mm/vmscan.c b/mm/vmscan.c >> index 8fcd9f8d7390..91b5120b924f 100644 >> --- a/mm/vmscan.c >> +++ b/mm/vmscan.c >> @@ -159,6 +159,56 @@ unsigned long

Re: [PATCH 01/10] mm: Assign id to every memcg-aware shrinker

2018-03-27 Thread Vladimir Davydov
On Tue, Mar 27, 2018 at 06:09:20PM +0300, Kirill Tkhai wrote: > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 8fcd9f8d7390..91b5120b924f 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -159,6 +159,56 @@ unsigned long vm_total_pages; > static

Re: [PATCH 01/10] mm: Assign id to every memcg-aware shrinker

2018-03-27 Thread Vladimir Davydov
On Tue, Mar 27, 2018 at 06:09:20PM +0300, Kirill Tkhai wrote: > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 8fcd9f8d7390..91b5120b924f 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -159,6 +159,56 @@ unsigned long vm_total_pages; > static

Re: [PATCH 01/10] mm: Assign id to every memcg-aware shrinker

2018-03-27 Thread Kirill Tkhai
On 27.03.2018 12:15, Vladimir Davydov wrote: > On Mon, Mar 26, 2018 at 06:09:35PM +0300, Kirill Tkhai wrote: >> Hi, Vladimir, >> >> thanks for your review! >> >> On 24.03.2018 21:40, Vladimir Davydov wrote: >>> Hello Kirill, >>> >>> I don't have any objections to the idea behind this patch set.

Re: [PATCH 01/10] mm: Assign id to every memcg-aware shrinker

2018-03-27 Thread Kirill Tkhai
On 27.03.2018 12:15, Vladimir Davydov wrote: > On Mon, Mar 26, 2018 at 06:09:35PM +0300, Kirill Tkhai wrote: >> Hi, Vladimir, >> >> thanks for your review! >> >> On 24.03.2018 21:40, Vladimir Davydov wrote: >>> Hello Kirill, >>> >>> I don't have any objections to the idea behind this patch set.

Re: [PATCH 01/10] mm: Assign id to every memcg-aware shrinker

2018-03-27 Thread Vladimir Davydov
On Mon, Mar 26, 2018 at 06:09:35PM +0300, Kirill Tkhai wrote: > Hi, Vladimir, > > thanks for your review! > > On 24.03.2018 21:40, Vladimir Davydov wrote: > > Hello Kirill, > > > > I don't have any objections to the idea behind this patch set. > > Well, at least I don't know how to better

Re: [PATCH 01/10] mm: Assign id to every memcg-aware shrinker

2018-03-27 Thread Vladimir Davydov
On Mon, Mar 26, 2018 at 06:09:35PM +0300, Kirill Tkhai wrote: > Hi, Vladimir, > > thanks for your review! > > On 24.03.2018 21:40, Vladimir Davydov wrote: > > Hello Kirill, > > > > I don't have any objections to the idea behind this patch set. > > Well, at least I don't know how to better

Re: [PATCH 01/10] mm: Assign id to every memcg-aware shrinker

2018-03-26 Thread Kirill Tkhai
On 26.03.2018 18:14, Matthew Wilcox wrote: > On Mon, Mar 26, 2018 at 06:09:35PM +0300, Kirill Tkhai wrote: >>> AFAIK ida always allocates the smallest available id so you don't need >>> to keep track of bitmap_id_start. >> >> I saw mnt_alloc_group_id() does the same, so this was the reason, the

Re: [PATCH 01/10] mm: Assign id to every memcg-aware shrinker

2018-03-26 Thread Kirill Tkhai
On 26.03.2018 18:14, Matthew Wilcox wrote: > On Mon, Mar 26, 2018 at 06:09:35PM +0300, Kirill Tkhai wrote: >>> AFAIK ida always allocates the smallest available id so you don't need >>> to keep track of bitmap_id_start. >> >> I saw mnt_alloc_group_id() does the same, so this was the reason, the

Re: [PATCH 01/10] mm: Assign id to every memcg-aware shrinker

2018-03-26 Thread Matthew Wilcox
On Mon, Mar 26, 2018 at 06:09:35PM +0300, Kirill Tkhai wrote: > > AFAIK ida always allocates the smallest available id so you don't need > > to keep track of bitmap_id_start. > > I saw mnt_alloc_group_id() does the same, so this was the reason, the > additional > variable was used. Doesn't this

Re: [PATCH 01/10] mm: Assign id to every memcg-aware shrinker

2018-03-26 Thread Matthew Wilcox
On Mon, Mar 26, 2018 at 06:09:35PM +0300, Kirill Tkhai wrote: > > AFAIK ida always allocates the smallest available id so you don't need > > to keep track of bitmap_id_start. > > I saw mnt_alloc_group_id() does the same, so this was the reason, the > additional > variable was used. Doesn't this

Re: [PATCH 01/10] mm: Assign id to every memcg-aware shrinker

2018-03-26 Thread Kirill Tkhai
Hi, Vladimir, thanks for your review! On 24.03.2018 21:40, Vladimir Davydov wrote: > Hello Kirill, > > I don't have any objections to the idea behind this patch set. > Well, at least I don't know how to better tackle the problem you > describe in the cover letter. Please, see below for my

Re: [PATCH 01/10] mm: Assign id to every memcg-aware shrinker

2018-03-26 Thread Kirill Tkhai
Hi, Vladimir, thanks for your review! On 24.03.2018 21:40, Vladimir Davydov wrote: > Hello Kirill, > > I don't have any objections to the idea behind this patch set. > Well, at least I don't know how to better tackle the problem you > describe in the cover letter. Please, see below for my

Re: [PATCH 01/10] mm: Assign id to every memcg-aware shrinker

2018-03-24 Thread Vladimir Davydov
Hello Kirill, I don't have any objections to the idea behind this patch set. Well, at least I don't know how to better tackle the problem you describe in the cover letter. Please, see below for my comments regarding implementation details. On Wed, Mar 21, 2018 at 04:21:17PM +0300, Kirill Tkhai

Re: [PATCH 01/10] mm: Assign id to every memcg-aware shrinker

2018-03-24 Thread Vladimir Davydov
Hello Kirill, I don't have any objections to the idea behind this patch set. Well, at least I don't know how to better tackle the problem you describe in the cover letter. Please, see below for my comments regarding implementation details. On Wed, Mar 21, 2018 at 04:21:17PM +0300, Kirill Tkhai

[PATCH 01/10] mm: Assign id to every memcg-aware shrinker

2018-03-21 Thread Kirill Tkhai
The patch introduces shrinker::id number, which is used to enumerate memcg-aware shrinkers. The number start from 0, and the code tries to maintain it as small as possible. This will be used as to represent a memcg-aware shrinkers in memcg shrinkers map. Signed-off-by: Kirill Tkhai

[PATCH 01/10] mm: Assign id to every memcg-aware shrinker

2018-03-21 Thread Kirill Tkhai
The patch introduces shrinker::id number, which is used to enumerate memcg-aware shrinkers. The number start from 0, and the code tries to maintain it as small as possible. This will be used as to represent a memcg-aware shrinkers in memcg shrinkers map. Signed-off-by: Kirill Tkhai ---