Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-03 Thread Mark Rutland
On Wed, Feb 03, 2016 at 05:56:56PM +0100, Gregory CLEMENT wrote: > Hi Mark, > > On mar., févr. 02 2016, Mark Rutland wrote: > >> diff --git a/Documentation/kernel-parameters.txt > >> b/Documentation/kernel-parameters.txt > >> index 87d40a72f6a1..198f6bd56e84 100644 > >> ---

Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-03 Thread Gregory CLEMENT
Hi Mark, On mar., févr. 02 2016, Mark Rutland wrote: >> diff --git a/Documentation/devicetree/bindings/tty/serial/mvebu-uart.txt >> b/Documentation/devicetree/bindings/tty/serial/mvebu-uart.txt >> new file mode 100644 >> index ..6087defd9f93 >> --- /dev/null >> +++

Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-03 Thread Gregory CLEMENT
Hi Marcin, On mer., févr. 03 2016, Marcin Wojtas wrote: > Hi Gregory > >> + >> +static int mvebu_uart_startup(struct uart_port *port) >> +{ >> + int ret; >> + >> + writel(CTRL_TXFIFO_RST | CTRL_RXFIFO_RST, >> + port->membase + UART_CTRL); >> + udelay(1); >> +

Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-03 Thread Gregory CLEMENT
Hi Arnd, On mar., févr. 02 2016, Arnd Bergmann wrote: > On Tuesday 02 February 2016 19:07:39 Gregory CLEMENT wrote: > >> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig >> index 39721ec4f415..b291f934d51b 100644 >> --- a/drivers/tty/serial/Kconfig >> +++

Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-03 Thread Gregory CLEMENT
Hi Mark, On mar., févr. 02 2016, Mark Rutland wrote: > On Tue, Feb 02, 2016 at 07:07:39PM +0100, Gregory CLEMENT wrote: >> From: Wilson Ding >> >> Armada-3700's uart is a simple serial port, which doesn't >> support. Configuring the modem control lines. The uart port has a 32 >> bytes Tx

Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-03 Thread Gregory CLEMENT
Hi, On mar., févr. 02 2016, One Thousand Gnomes wrote: >> +static void mvebu_uart_set_termios(struct uart_port *port, >> + struct ktermios *termios, >> + struct ktermios *old) >> +{ >> +unsigned long flags; >> +unsigned int

Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-03 Thread Marcin Wojtas
Hi Gregory > + > +static int mvebu_uart_startup(struct uart_port *port) > +{ > + int ret; > + > + writel(CTRL_TXFIFO_RST | CTRL_RXFIFO_RST, > + port->membase + UART_CTRL); > + udelay(1); > + writel(CTRL_RX_INT, port->membase + UART_CTRL); > + > + ret =

Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-03 Thread Marcin Wojtas
Hi Gregory > + > +static int mvebu_uart_startup(struct uart_port *port) > +{ > + int ret; > + > + writel(CTRL_TXFIFO_RST | CTRL_RXFIFO_RST, > + port->membase + UART_CTRL); > + udelay(1); > + writel(CTRL_RX_INT, port->membase + UART_CTRL); > + > + ret =

Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-03 Thread Gregory CLEMENT
Hi Marcin, On mer., févr. 03 2016, Marcin Wojtas wrote: > Hi Gregory > >> + >> +static int mvebu_uart_startup(struct uart_port *port) >> +{ >> + int ret; >> + >> + writel(CTRL_TXFIFO_RST | CTRL_RXFIFO_RST, >> + port->membase + UART_CTRL); >> +

Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-03 Thread Gregory CLEMENT
Hi, On mar., févr. 02 2016, One Thousand Gnomes wrote: >> +static void mvebu_uart_set_termios(struct uart_port *port, >> + struct ktermios *termios, >> + struct ktermios *old) >> +{ >> +unsigned long

Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-03 Thread Gregory CLEMENT
Hi Mark, On mar., févr. 02 2016, Mark Rutland wrote: > On Tue, Feb 02, 2016 at 07:07:39PM +0100, Gregory CLEMENT wrote: >> From: Wilson Ding >> >> Armada-3700's uart is a simple serial port, which doesn't >> support. Configuring the modem control

Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-03 Thread Gregory CLEMENT
Hi Mark, On mar., févr. 02 2016, Mark Rutland wrote: >> diff --git a/Documentation/devicetree/bindings/tty/serial/mvebu-uart.txt >> b/Documentation/devicetree/bindings/tty/serial/mvebu-uart.txt >> new file mode 100644 >> index ..6087defd9f93 >> --- /dev/null

Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-03 Thread Mark Rutland
On Wed, Feb 03, 2016 at 05:56:56PM +0100, Gregory CLEMENT wrote: > Hi Mark, > > On mar., févr. 02 2016, Mark Rutland wrote: > >> diff --git a/Documentation/kernel-parameters.txt > >> b/Documentation/kernel-parameters.txt > >> index 87d40a72f6a1..198f6bd56e84 100644 > >>

Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-03 Thread Gregory CLEMENT
Hi Arnd, On mar., févr. 02 2016, Arnd Bergmann wrote: > On Tuesday 02 February 2016 19:07:39 Gregory CLEMENT wrote: > >> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig >> index 39721ec4f415..b291f934d51b 100644 >> --- a/drivers/tty/serial/Kconfig >> +++

Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-02 Thread Rob Herring
On Tue, Feb 02, 2016 at 07:07:39PM +0100, Gregory CLEMENT wrote: > From: Wilson Ding > > Armada-3700's uart is a simple serial port, which doesn't > support. Configuring the modem control lines. The uart port has a 32 > bytes Tx FIFO and a 64 bytes Rx FIFO > > The uart driver implements the

Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-02 Thread Arnd Bergmann
On Tuesday 02 February 2016 19:07:39 Gregory CLEMENT wrote: > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig > index 39721ec4f415..b291f934d51b 100644 > --- a/drivers/tty/serial/Kconfig > +++ b/drivers/tty/serial/Kconfig > @@ -1606,6 +1606,28 @@ config SERIAL_STM32_CONSOLE >

Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-02 Thread Mark Rutland
On Tue, Feb 02, 2016 at 07:07:39PM +0100, Gregory CLEMENT wrote: > From: Wilson Ding > > Armada-3700's uart is a simple serial port, which doesn't > support. Configuring the modem control lines. The uart port has a 32 > bytes Tx FIFO and a 64 bytes Rx FIFO > > The uart driver implements the

Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-02 Thread Mark Rutland
On Tue, Feb 02, 2016 at 06:19:29PM +, Mark Rutland wrote: > On Tue, Feb 02, 2016 at 07:07:39PM +0100, Gregory CLEMENT wrote: > > From: Wilson Ding > > > > Armada-3700's uart is a simple serial port, which doesn't > > support. Configuring the modem control lines. The uart port has a 32 > >

Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-02 Thread One Thousand Gnomes
> +static void mvebu_uart_set_termios(struct uart_port *port, > +struct ktermios *termios, > +struct ktermios *old) > +{ > + unsigned long flags; > + unsigned int baud; > + > + spin_lock_irqsave(>lock, flags); > + > +

Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-02 Thread Mark Rutland
On Tue, Feb 02, 2016 at 07:07:39PM +0100, Gregory CLEMENT wrote: > From: Wilson Ding > > Armada-3700's uart is a simple serial port, which doesn't > support. Configuring the modem control lines. The uart port has a 32 > bytes Tx FIFO and a 64 bytes Rx FIFO > > The uart driver implements the

[PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-02 Thread Gregory CLEMENT
From: Wilson Ding Armada-3700's uart is a simple serial port, which doesn't support. Configuring the modem control lines. The uart port has a 32 bytes Tx FIFO and a 64 bytes Rx FIFO The uart driver implements the uart core operations. It also support the system (early) console based on

Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-02 Thread Mark Rutland
On Tue, Feb 02, 2016 at 06:19:29PM +, Mark Rutland wrote: > On Tue, Feb 02, 2016 at 07:07:39PM +0100, Gregory CLEMENT wrote: > > From: Wilson Ding > > > > Armada-3700's uart is a simple serial port, which doesn't > > support. Configuring the modem control lines. The uart

Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-02 Thread Mark Rutland
On Tue, Feb 02, 2016 at 07:07:39PM +0100, Gregory CLEMENT wrote: > From: Wilson Ding > > Armada-3700's uart is a simple serial port, which doesn't > support. Configuring the modem control lines. The uart port has a 32 > bytes Tx FIFO and a 64 bytes Rx FIFO > > The uart

Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-02 Thread One Thousand Gnomes
> +static void mvebu_uart_set_termios(struct uart_port *port, > +struct ktermios *termios, > +struct ktermios *old) > +{ > + unsigned long flags; > + unsigned int baud; > + > + spin_lock_irqsave(>lock, flags); > + > +

Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-02 Thread Mark Rutland
On Tue, Feb 02, 2016 at 07:07:39PM +0100, Gregory CLEMENT wrote: > From: Wilson Ding > > Armada-3700's uart is a simple serial port, which doesn't > support. Configuring the modem control lines. The uart port has a 32 > bytes Tx FIFO and a 64 bytes Rx FIFO > > The uart

[PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-02 Thread Gregory CLEMENT
From: Wilson Ding Armada-3700's uart is a simple serial port, which doesn't support. Configuring the modem control lines. The uart port has a 32 bytes Tx FIFO and a 64 bytes Rx FIFO The uart driver implements the uart core operations. It also support the system (early)

Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-02 Thread Arnd Bergmann
On Tuesday 02 February 2016 19:07:39 Gregory CLEMENT wrote: > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig > index 39721ec4f415..b291f934d51b 100644 > --- a/drivers/tty/serial/Kconfig > +++ b/drivers/tty/serial/Kconfig > @@ -1606,6 +1606,28 @@ config SERIAL_STM32_CONSOLE >

Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port

2016-02-02 Thread Rob Herring
On Tue, Feb 02, 2016 at 07:07:39PM +0100, Gregory CLEMENT wrote: > From: Wilson Ding > > Armada-3700's uart is a simple serial port, which doesn't > support. Configuring the modem control lines. The uart port has a 32 > bytes Tx FIFO and a 64 bytes Rx FIFO > > The uart