Re: [PATCH 01/10] vfio: ccw: Moving state change out of IRQ context

2018-04-30 Thread Cornelia Huck
On Wed, 25 Apr 2018 13:06:31 +0200 Halil Pasic wrote: > On 04/25/2018 08:57 AM, Cornelia Huck wrote: > >> AFAIU this will be the problem of the person implementing the clear > >> and the halt for vfio-ccw. I.e. it's a non-problem right now. > > Well, that person is me:) I

Re: [PATCH 01/10] vfio: ccw: Moving state change out of IRQ context

2018-04-30 Thread Cornelia Huck
On Wed, 25 Apr 2018 13:06:31 +0200 Halil Pasic wrote: > On 04/25/2018 08:57 AM, Cornelia Huck wrote: > >> AFAIU this will be the problem of the person implementing the clear > >> and the halt for vfio-ccw. I.e. it's a non-problem right now. > > Well, that person is me:) I will post some RFC

Re: [PATCH 01/10] vfio: ccw: Moving state change out of IRQ context

2018-04-25 Thread Halil Pasic
On 04/25/2018 08:57 AM, Cornelia Huck wrote: AFAIU this will be the problem of the person implementing the clear and the halt for vfio-ccw. I.e. it's a non-problem right now. Well, that person is me:) I will post some RFC Real Soon Now if I stop getting sidetracked... Makes sense. It

Re: [PATCH 01/10] vfio: ccw: Moving state change out of IRQ context

2018-04-25 Thread Halil Pasic
On 04/25/2018 08:57 AM, Cornelia Huck wrote: AFAIU this will be the problem of the person implementing the clear and the halt for vfio-ccw. I.e. it's a non-problem right now. Well, that person is me:) I will post some RFC Real Soon Now if I stop getting sidetracked... Makes sense. It

Re: [PATCH 01/10] vfio: ccw: Moving state change out of IRQ context

2018-04-25 Thread Cornelia Huck
On Tue, 24 Apr 2018 18:42:38 +0200 Halil Pasic wrote: > On 04/24/2018 11:59 AM, Cornelia Huck wrote: > > On Tue, 24 Apr 2018 10:40:56 +0200 > > Pierre Morel wrote: > > > >> On 24/04/2018 08:54, Dong Jia Shi wrote: > >>> * Pierre Morel

Re: [PATCH 01/10] vfio: ccw: Moving state change out of IRQ context

2018-04-25 Thread Cornelia Huck
On Tue, 24 Apr 2018 18:42:38 +0200 Halil Pasic wrote: > On 04/24/2018 11:59 AM, Cornelia Huck wrote: > > On Tue, 24 Apr 2018 10:40:56 +0200 > > Pierre Morel wrote: > > > >> On 24/04/2018 08:54, Dong Jia Shi wrote: > >>> * Pierre Morel [2018-04-19 16:48:04 +0200]: > >>> > >>> [...] > >>>

Re: [PATCH 01/10] vfio: ccw: Moving state change out of IRQ context

2018-04-24 Thread Halil Pasic
On 04/24/2018 11:59 AM, Cornelia Huck wrote: On Tue, 24 Apr 2018 10:40:56 +0200 Pierre Morel wrote: On 24/04/2018 08:54, Dong Jia Shi wrote: * Pierre Morel [2018-04-19 16:48:04 +0200]: [...] @@ -94,9 +83,15 @@ static void

Re: [PATCH 01/10] vfio: ccw: Moving state change out of IRQ context

2018-04-24 Thread Halil Pasic
On 04/24/2018 11:59 AM, Cornelia Huck wrote: On Tue, 24 Apr 2018 10:40:56 +0200 Pierre Morel wrote: On 24/04/2018 08:54, Dong Jia Shi wrote: * Pierre Morel [2018-04-19 16:48:04 +0200]: [...] @@ -94,9 +83,15 @@ static void vfio_ccw_sch_io_todo(struct work_struct *work) static void

Re: [PATCH 01/10] vfio: ccw: Moving state change out of IRQ context

2018-04-24 Thread Pierre Morel
On 24/04/2018 13:55, Cornelia Huck wrote: On Tue, 24 Apr 2018 13:49:14 +0200 Pierre Morel wrote: On 24/04/2018 11:59, Cornelia Huck wrote: On Tue, 24 Apr 2018 10:40:56 +0200 Pierre Morel wrote: On 24/04/2018 08:54, Dong Jia Shi

Re: [PATCH 01/10] vfio: ccw: Moving state change out of IRQ context

2018-04-24 Thread Pierre Morel
On 24/04/2018 13:55, Cornelia Huck wrote: On Tue, 24 Apr 2018 13:49:14 +0200 Pierre Morel wrote: On 24/04/2018 11:59, Cornelia Huck wrote: On Tue, 24 Apr 2018 10:40:56 +0200 Pierre Morel wrote: On 24/04/2018 08:54, Dong Jia Shi wrote: * Pierre Morel [2018-04-19 16:48:04 +0200]: [...]

Re: [PATCH 01/10] vfio: ccw: Moving state change out of IRQ context

2018-04-24 Thread Cornelia Huck
On Tue, 24 Apr 2018 13:49:14 +0200 Pierre Morel wrote: > On 24/04/2018 11:59, Cornelia Huck wrote: > > On Tue, 24 Apr 2018 10:40:56 +0200 > > Pierre Morel wrote: > > > >> On 24/04/2018 08:54, Dong Jia Shi wrote: > >>> * Pierre Morel

Re: [PATCH 01/10] vfio: ccw: Moving state change out of IRQ context

2018-04-24 Thread Cornelia Huck
On Tue, 24 Apr 2018 13:49:14 +0200 Pierre Morel wrote: > On 24/04/2018 11:59, Cornelia Huck wrote: > > On Tue, 24 Apr 2018 10:40:56 +0200 > > Pierre Morel wrote: > > > >> On 24/04/2018 08:54, Dong Jia Shi wrote: > >>> * Pierre Morel [2018-04-19 16:48:04 +0200]: > >>> > >>> [...] > >>>

Re: [PATCH 01/10] vfio: ccw: Moving state change out of IRQ context

2018-04-24 Thread Pierre Morel
On 24/04/2018 11:59, Cornelia Huck wrote: On Tue, 24 Apr 2018 10:40:56 +0200 Pierre Morel wrote: On 24/04/2018 08:54, Dong Jia Shi wrote: * Pierre Morel [2018-04-19 16:48:04 +0200]: [...] @@ -94,9 +83,15 @@ static void

Re: [PATCH 01/10] vfio: ccw: Moving state change out of IRQ context

2018-04-24 Thread Pierre Morel
On 24/04/2018 11:59, Cornelia Huck wrote: On Tue, 24 Apr 2018 10:40:56 +0200 Pierre Morel wrote: On 24/04/2018 08:54, Dong Jia Shi wrote: * Pierre Morel [2018-04-19 16:48:04 +0200]: [...] @@ -94,9 +83,15 @@ static void vfio_ccw_sch_io_todo(struct work_struct *work) static void

Re: [PATCH 01/10] vfio: ccw: Moving state change out of IRQ context

2018-04-24 Thread Cornelia Huck
On Tue, 24 Apr 2018 10:40:56 +0200 Pierre Morel wrote: > On 24/04/2018 08:54, Dong Jia Shi wrote: > > * Pierre Morel [2018-04-19 16:48:04 +0200]: > > > > [...] > > > >> @@ -94,9 +83,15 @@ static void vfio_ccw_sch_io_todo(struct work_struct

Re: [PATCH 01/10] vfio: ccw: Moving state change out of IRQ context

2018-04-24 Thread Cornelia Huck
On Tue, 24 Apr 2018 10:40:56 +0200 Pierre Morel wrote: > On 24/04/2018 08:54, Dong Jia Shi wrote: > > * Pierre Morel [2018-04-19 16:48:04 +0200]: > > > > [...] > > > >> @@ -94,9 +83,15 @@ static void vfio_ccw_sch_io_todo(struct work_struct > >> *work) > >> static void

Re: [PATCH 01/10] vfio: ccw: Moving state change out of IRQ context

2018-04-24 Thread Pierre Morel
On 24/04/2018 08:54, Dong Jia Shi wrote: * Pierre Morel [2018-04-19 16:48:04 +0200]: [...] @@ -94,9 +83,15 @@ static void vfio_ccw_sch_io_todo(struct work_struct *work) static void vfio_ccw_sch_irq(struct subchannel *sch) { struct vfio_ccw_private

Re: [PATCH 01/10] vfio: ccw: Moving state change out of IRQ context

2018-04-24 Thread Pierre Morel
On 24/04/2018 08:54, Dong Jia Shi wrote: * Pierre Morel [2018-04-19 16:48:04 +0200]: [...] @@ -94,9 +83,15 @@ static void vfio_ccw_sch_io_todo(struct work_struct *work) static void vfio_ccw_sch_irq(struct subchannel *sch) { struct vfio_ccw_private *private =

[PATCH 01/10] vfio: ccw: Moving state change out of IRQ context

2018-04-19 Thread Pierre Morel
Having state changes out of IRQ context allows to protect critical sections with mutexes. Next patches in the serie will use this possibility. We use work queues to thread the interrupts. Signed-off-by: Pierre Morel --- drivers/s390/cio/vfio_ccw_drv.c | 21

[PATCH 01/10] vfio: ccw: Moving state change out of IRQ context

2018-04-19 Thread Pierre Morel
Having state changes out of IRQ context allows to protect critical sections with mutexes. Next patches in the serie will use this possibility. We use work queues to thread the interrupts. Signed-off-by: Pierre Morel --- drivers/s390/cio/vfio_ccw_drv.c | 21 -