Re: [PATCH 01/11] mmc: bcm2835: Simplify with dev_err_probe()

[Florian Fainelli]

On 9/2/2020 12:36 PM, Krzysztof Kozlowski wrote:

Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski 


Acked-by: Florian Fainelli 
--
Florian

[PATCH 01/11] mmc: bcm2835: Simplify with dev_err_probe()

[Krzysztof Kozlowski]

Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski 
---
 drivers/mmc/host/bcm2835.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mmc/host/bcm2835.c b/drivers/mmc/host/bcm2835.c
index a0767790a826..35320bc9dc02 100644
--- a/drivers/mmc/host/bcm2835.c
+++ b/drivers/mmc/host/bcm2835.c
@@ -1406,9 +1406,7 @@ static int bcm2835_probe(struct platform_device *pdev)
 
clk = devm_clk_get(dev, NULL);
if (IS_ERR(clk)) {
-   ret = PTR_ERR(clk);
-   if (ret != -EPROBE_DEFER)
-   dev_err(dev, "could not get clk: %d\n", ret);
+   ret = dev_err_probe(dev, PTR_ERR(clk), "could not get clk\n");
goto err;
}
 
-- 
2.17.1