Re: [PATCH 01/11] mmc: omap: fix error return code

[Ulf Hansson]

On 23 August 2015 at 02:11, Julia Lawall  wrote:
> Return a negative error code on failure.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // 
> @@
> identifier ret; expression e1,e2;
> @@
> (
> if (\(ret < 0\|ret != 0\))
>  { ... return ret; }
> |
> ret = 0
> )
> ... when != ret = e1
> when != 
> *if(...)
> {
>   ... when != ret = e2
>   when forall
>  return ret;
> }
> // 
>
> Signed-off-by: Julia Lawall 

Thanks, applied for next!

Kind regards
Uffe

>
> ---
>  drivers/mmc/host/omap.c |4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
> index 70dcf07..b763b11 100644
> --- a/drivers/mmc/host/omap.c
> +++ b/drivers/mmc/host/omap.c
> @@ -1420,8 +1420,10 @@ static int mmc_omap_probe(struct platform_device *pdev)
> host->reg_shift = (mmc_omap7xx() ? 1 : 2);
>
> host->mmc_omap_wq = alloc_workqueue("mmc_omap", 0, 0);
> -   if (!host->mmc_omap_wq)
> +   if (!host->mmc_omap_wq) {
> +   ret = -ENOMEM;
> goto err_plat_cleanup;
> +   }
>
> for (i = 0; i < pdata->nr_slots; i++) {
> ret = mmc_omap_new_slot(host, i);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 01/11] mmc: omap: fix error return code

[Ulf Hansson]

On 23 August 2015 at 02:11, Julia Lawall julia.law...@lip6.fr wrote:
 Return a negative error code on failure.

 A simplified version of the semantic match that finds this problem is as
 follows: (http://coccinelle.lip6.fr/)

 // smpl
 @@
 identifier ret; expression e1,e2;
 @@
 (
 if (\(ret  0\|ret != 0\))
  { ... return ret; }
 |
 ret = 0
 )
 ... when != ret = e1
 when != ret
 *if(...)
 {
   ... when != ret = e2
   when forall
  return ret;
 }
 // /smpl

 Signed-off-by: Julia Lawall julia.law...@lip6.fr

Thanks, applied for next!

Kind regards
Uffe


 ---
  drivers/mmc/host/omap.c |4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

 diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
 index 70dcf07..b763b11 100644
 --- a/drivers/mmc/host/omap.c
 +++ b/drivers/mmc/host/omap.c
 @@ -1420,8 +1420,10 @@ static int mmc_omap_probe(struct platform_device *pdev)
 host-reg_shift = (mmc_omap7xx() ? 1 : 2);

 host-mmc_omap_wq = alloc_workqueue(mmc_omap, 0, 0);
 -   if (!host-mmc_omap_wq)
 +   if (!host-mmc_omap_wq) {
 +   ret = -ENOMEM;
 goto err_plat_cleanup;
 +   }

 for (i = 0; i  pdata-nr_slots; i++) {
 ret = mmc_omap_new_slot(host, i);

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 01/11] mmc: omap: fix error return code

[Julia Lawall]

Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// 
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
when != 
*if(...)
{
  ... when != ret = e2
  when forall
 return ret;
}
// 

Signed-off-by: Julia Lawall 

---
 drivers/mmc/host/omap.c |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
index 70dcf07..b763b11 100644
--- a/drivers/mmc/host/omap.c
+++ b/drivers/mmc/host/omap.c
@@ -1420,8 +1420,10 @@ static int mmc_omap_probe(struct platform_device *pdev)
host->reg_shift = (mmc_omap7xx() ? 1 : 2);
 
host->mmc_omap_wq = alloc_workqueue("mmc_omap", 0, 0);
-   if (!host->mmc_omap_wq)
+   if (!host->mmc_omap_wq) {
+   ret = -ENOMEM;
goto err_plat_cleanup;
+   }
 
for (i = 0; i < pdata->nr_slots; i++) {
ret = mmc_omap_new_slot(host, i);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 01/11] mmc: omap: fix error return code

[Julia Lawall]

Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// smpl
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret  0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
when != ret
*if(...)
{
  ... when != ret = e2
  when forall
 return ret;
}
// /smpl

Signed-off-by: Julia Lawall julia.law...@lip6.fr

---
 drivers/mmc/host/omap.c |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
index 70dcf07..b763b11 100644
--- a/drivers/mmc/host/omap.c
+++ b/drivers/mmc/host/omap.c
@@ -1420,8 +1420,10 @@ static int mmc_omap_probe(struct platform_device *pdev)
host-reg_shift = (mmc_omap7xx() ? 1 : 2);
 
host-mmc_omap_wq = alloc_workqueue(mmc_omap, 0, 0);
-   if (!host-mmc_omap_wq)
+   if (!host-mmc_omap_wq) {
+   ret = -ENOMEM;
goto err_plat_cleanup;
+   }
 
for (i = 0; i  pdata-nr_slots; i++) {
ret = mmc_omap_new_slot(host, i);

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/