Re: [PATCH 01/11] net: phy: Add rockchip phy driver support

2017-06-27 Thread David.Wu
Hi Andrew, 在 2017/6/27 22:46, Andrew Lunn 写道: it has been licensed from somebody. And does that somebody already have a driver for it? There is no point adding a driver, if all you need to do is add the ID to another driver. I didn't find it. Maybe use the same, but the configuration is dif

Re: [PATCH 01/11] net: phy: Add rockchip phy driver support

2017-06-27 Thread Andrew Lunn
> it has been licensed from somebody. And does that somebody already have a driver for it? There is no point adding a driver, if all you need to do is add the ID to another driver. Andrew

Re: [PATCH 01/11] net: phy: Add rockchip phy driver support

2017-06-27 Thread David.Wu
Hi Andrew, 在 2017/6/24 10:19, Andrew Lunn 写道: On Fri, Jun 23, 2017 at 12:41:59PM +0800, David Wu wrote: Support internal ephy currently. Signed-off-by: David Wu --- drivers/net/phy/Kconfig| 4 ++ drivers/net/phy/Makefile | 1 + drivers/net/phy/rockchip.c | 94 +

Re: [PATCH 01/11] net: phy: Add rockchip phy driver support

2017-06-24 Thread Heiko Stuebner
Am Samstag, 24. Juni 2017, 16:04:06 CEST schrieb Andrew Lunn: > > hmm, we do have quite a number of non-net phys in the phy subsystem > > (DP, PCIe, ...) and given that the above would be CONFIG_ROCKCHIP_PHY > > in a global sense, sounds like it could make things confusing. > > > > So some additio

Re: [PATCH 01/11] net: phy: Add rockchip phy driver support

2017-06-24 Thread Andrew Lunn
> hmm, we do have quite a number of non-net phys in the phy subsystem > (DP, PCIe, ...) and given that the above would be CONFIG_ROCKCHIP_PHY > in a global sense, sounds like it could make things confusing. > > So some addition sounds reasonable ... ROCKCHIP_ETH_PHY or so? I follow you reasoning,

Re: [PATCH 01/11] net: phy: Add rockchip phy driver support

2017-06-24 Thread Heiko Stuebner
Am Samstag, 24. Juni 2017, 04:19:10 CEST schrieb Andrew Lunn: > On Fri, Jun 23, 2017 at 12:41:59PM +0800, David Wu wrote: > > Support internal ephy currently. > > > > Signed-off-by: David Wu > > --- > > drivers/net/phy/Kconfig| 4 ++ > > drivers/net/phy/Makefile | 1 + > > drivers/net/ph

Re: [PATCH 01/11] net: phy: Add rockchip phy driver support

2017-06-23 Thread Andrew Lunn
On Fri, Jun 23, 2017 at 12:41:59PM +0800, David Wu wrote: > Support internal ephy currently. > > Signed-off-by: David Wu > --- > drivers/net/phy/Kconfig| 4 ++ > drivers/net/phy/Makefile | 1 + > drivers/net/phy/rockchip.c | 94 > ++ > 3 files

Re: [PATCH 01/11] net: phy: Add rockchip phy driver support

2017-06-23 Thread Andrew Lunn
> + > +static int internal_config_init(struct phy_device *phydev) > +{ internal_ is a bit generic. The Marvell Ethernet switches have internal phy, etc. rockchip_ would be a better prefix. Andrew

Re: [PATCH 01/11] net: phy: Add rockchip phy driver support

2017-06-23 Thread Florian Fainelli
On 06/22/2017 09:41 PM, David Wu wrote: > Support internal ephy currently. > > Signed-off-by: David Wu > --- > drivers/net/phy/Kconfig| 4 ++ > drivers/net/phy/Makefile | 1 + > drivers/net/phy/rockchip.c | 94 > ++ > 3 files changed, 99 inser

Re: [PATCH 01/11] net: phy: Add rockchip phy driver support

2017-06-23 Thread Andrew Lunn
On Fri, Jun 23, 2017 at 12:41:59PM +0800, David Wu wrote: > Support internal ephy currently. > > Signed-off-by: David Wu > --- > drivers/net/phy/Kconfig| 4 ++ > drivers/net/phy/Makefile | 1 + > drivers/net/phy/rockchip.c | 94 > ++ > 3 files

[PATCH 01/11] net: phy: Add rockchip phy driver support

2017-06-22 Thread David Wu
Support internal ephy currently. Signed-off-by: David Wu --- drivers/net/phy/Kconfig| 4 ++ drivers/net/phy/Makefile | 1 + drivers/net/phy/rockchip.c | 94 ++ 3 files changed, 99 insertions(+) create mode 100644 drivers/net/phy/rockchip.c di