[PATCH 01/12] perf/breakpoint: Split attribute parse and commit

2018-06-25 Thread Frederic Weisbecker
arch_validate_hwbkpt_settings() mixes up attribute check and commit into a single code entity. Therefore the validation may return an error due to incorrect atributes while still leaving halfway modified architecture breakpoint data. This is harmless when we deal with a new breakpoint but it

[PATCH 01/12] perf/breakpoint: Split attribute parse and commit

2018-06-25 Thread Frederic Weisbecker
arch_validate_hwbkpt_settings() mixes up attribute check and commit into a single code entity. Therefore the validation may return an error due to incorrect atributes while still leaving halfway modified architecture breakpoint data. This is harmless when we deal with a new breakpoint but it

[PATCH 01/12] perf/breakpoint: Split attribute parse and commit

2018-06-01 Thread Frederic Weisbecker
arch_validate_hwbkpt_settings() mixes up attribute check and commit into a single code entity. Therefore the validation may return an error due to incorrect atributes while still leaving halfway modified architecture breakpoint data. This is harmless when we deal with a new breakpoint but it

[PATCH 01/12] perf/breakpoint: Split attribute parse and commit

2018-06-01 Thread Frederic Weisbecker
arch_validate_hwbkpt_settings() mixes up attribute check and commit into a single code entity. Therefore the validation may return an error due to incorrect atributes while still leaving halfway modified architecture breakpoint data. This is harmless when we deal with a new breakpoint but it

Re: [PATCH 01/12] perf/breakpoint: Split attribute parse and commit

2018-05-28 Thread Michael Ellerman
Frederic Weisbecker writes: > On Thu, May 24, 2018 at 11:56:01AM +1000, Michael Ellerman wrote: >> Frederic Weisbecker writes: >> >> > diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c >> > index 6e28d28..51320c2 100644 >> >

Re: [PATCH 01/12] perf/breakpoint: Split attribute parse and commit

2018-05-28 Thread Michael Ellerman
Frederic Weisbecker writes: > On Thu, May 24, 2018 at 11:56:01AM +1000, Michael Ellerman wrote: >> Frederic Weisbecker writes: >> >> > diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c >> > index 6e28d28..51320c2 100644 >> > --- a/kernel/events/hw_breakpoint.c >> > +++

Re: [PATCH 01/12] perf/breakpoint: Split attribute parse and commit

2018-05-25 Thread Frederic Weisbecker
On Thu, May 24, 2018 at 11:56:01AM +1000, Michael Ellerman wrote: > Frederic Weisbecker writes: > > > diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c > > index 6e28d28..51320c2 100644 > > --- a/kernel/events/hw_breakpoint.c > > +++

Re: [PATCH 01/12] perf/breakpoint: Split attribute parse and commit

2018-05-25 Thread Frederic Weisbecker
On Thu, May 24, 2018 at 11:56:01AM +1000, Michael Ellerman wrote: > Frederic Weisbecker writes: > > > diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c > > index 6e28d28..51320c2 100644 > > --- a/kernel/events/hw_breakpoint.c > > +++ b/kernel/events/hw_breakpoint.c > >

Re: [PATCH 01/12] perf/breakpoint: Split attribute parse and commit

2018-05-23 Thread Michael Ellerman
Frederic Weisbecker writes: > diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c > index 6e28d28..51320c2 100644 > --- a/kernel/events/hw_breakpoint.c > +++ b/kernel/events/hw_breakpoint.c > @@ -424,19 +443,22 @@ static int

Re: [PATCH 01/12] perf/breakpoint: Split attribute parse and commit

2018-05-23 Thread Michael Ellerman
Frederic Weisbecker writes: > diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c > index 6e28d28..51320c2 100644 > --- a/kernel/events/hw_breakpoint.c > +++ b/kernel/events/hw_breakpoint.c > @@ -424,19 +443,22 @@ static int validate_hw_breakpoint(struct perf_event *bp) >

[PATCH 01/12] perf/breakpoint: Split attribute parse and commit

2018-05-18 Thread Frederic Weisbecker
arch_validate_hwbkpt_settings() mixes up attribute check and commit into a single code entity. Therefore the validation may return an error due to incorrect atributes while still leaving halfway modified architecture breakpoint data. This is harmless when we deal with a new breakpoint but it

[PATCH 01/12] perf/breakpoint: Split attribute parse and commit

2018-05-18 Thread Frederic Weisbecker
arch_validate_hwbkpt_settings() mixes up attribute check and commit into a single code entity. Therefore the validation may return an error due to incorrect atributes while still leaving halfway modified architecture breakpoint data. This is harmless when we deal with a new breakpoint but it