Re: [PATCH 01/16] perf symbol: correct comment wrt kallsyms loading

2012-08-11 Thread Namhyung Kim
2012-08-10 (금), 15:22 -0700, Cody P Schafer: > In kallsyms_parse() when calling process_symbol() (a callback argument > to kallsyms_parse()), we pass start as both start & end (ie: > start=start, end=start). > > In map__process_kallsym_symbol(), the length is calculated as 'end - start + > 1', >

Re: [PATCH 01/16] perf symbol: correct comment wrt kallsyms loading

2012-08-11 Thread Namhyung Kim
2012-08-10 (금), 15:22 -0700, Cody P Schafer: In kallsyms_parse() when calling process_symbol() (a callback argument to kallsyms_parse()), we pass start as both start end (ie: start=start, end=start). In map__process_kallsym_symbol(), the length is calculated as 'end - start + 1', making

[PATCH 01/16] perf symbol: correct comment wrt kallsyms loading

2012-08-10 Thread Cody P Schafer
In kallsyms_parse() when calling process_symbol() (a callback argument to kallsyms_parse()), we pass start as both start & end (ie: start=start, end=start). In map__process_kallsym_symbol(), the length is calculated as 'end - start + 1', making the length 1, not 0. Essentially, start & end

[PATCH 01/16] perf symbol: correct comment wrt kallsyms loading

2012-08-10 Thread Cody P Schafer
In kallsyms_parse() when calling process_symbol() (a callback argument to kallsyms_parse()), we pass start as both start end (ie: start=start, end=start). In map__process_kallsym_symbol(), the length is calculated as 'end - start + 1', making the length 1, not 0. Essentially, start end define

[PATCH 01/16] perf symbol: correct comment wrt kallsyms loading

2012-08-09 Thread Cody P Schafer
In kallsyms_parse() when calling process_symbol() (a callback argument to kallsyms_parse()), we pass start as both start & end (ie: start=start, end=start). In map__process_kallsym_symbol(), the length is calculated as 'end - start + 1', making the length 1, not 0. Essentially, start & end

[PATCH 01/16] perf symbol: correct comment wrt kallsyms loading

2012-08-09 Thread Cody P Schafer
In kallsyms_parse() when calling process_symbol() (a callback argument to kallsyms_parse()), we pass start as both start end (ie: start=start, end=start). In map__process_kallsym_symbol(), the length is calculated as 'end - start + 1', making the length 1, not 0. Essentially, start end define