Re: [PATCH 01/18] dmaengine: of-dma: Add support for optional router configuration callback

2020-11-09 Thread Peter Ujfalusi
On 09/11/2020 14.23, Vinod Koul wrote: > HI Peter, > > On 09-11-20, 14:09, Peter Ujfalusi wrote: >> Hi Vinod, >> >> On 09/11/2020 13.45, Vinod Koul wrote: Without a channel number I can not do anything. It is close to a chicken and egg problem. >>> >>> We get 'channel' in xlate, so

Re: [PATCH 01/18] dmaengine: of-dma: Add support for optional router configuration callback

2020-11-09 Thread Vinod Koul
HI Peter, On 09-11-20, 14:09, Peter Ujfalusi wrote: > Hi Vinod, > > On 09/11/2020 13.45, Vinod Koul wrote: > >> Without a channel number I can not do anything. > >> It is close to a chicken and egg problem. > > > > We get 'channel' in xlate, so wont that help? I think I am still missing > >

Re: [PATCH 01/18] dmaengine: of-dma: Add support for optional router configuration callback

2020-11-09 Thread Peter Ujfalusi
Hi Vinod, On 09/11/2020 13.45, Vinod Koul wrote: >> Without a channel number I can not do anything. >> It is close to a chicken and egg problem. > > We get 'channel' in xlate, so wont that help? I think I am still missing > something here :( Yes, we get channel in xlate, but we get the channel

Re: [PATCH 01/18] dmaengine: of-dma: Add support for optional router configuration callback

2020-11-09 Thread Vinod Koul
Hey Peter, On 28-10-20, 11:56, Peter Ujfalusi wrote: > Hi Vinod, > > On 28/10/2020 7.55, Vinod Koul wrote: > > >> To summarize: > >> In of_dma_route_allocate() the router does not yet know the channel we > >> are going to get. > >> In of_dma_xlate() the DMA driver does not yet know if the

Re: [PATCH 01/18] dmaengine: of-dma: Add support for optional router configuration callback

2020-10-28 Thread Peter Ujfalusi
Hi Vinod, On 28/10/2020 7.55, Vinod Koul wrote: >> To summarize: >> In of_dma_route_allocate() the router does not yet know the channel we >> are going to get. >> In of_dma_xlate() the DMA driver does not yet know if the channel will >> use router or not. >> I need to tell the router the event

Re: [PATCH 01/18] dmaengine: of-dma: Add support for optional router configuration callback

2020-10-28 Thread Vinod Koul
On 08-10-20, 09:41, Peter Ujfalusi wrote: > > > On 07/10/2020 18.55, Vinod Koul wrote: > > On 07-10-20, 11:08, Peter Ujfalusi wrote: > > > >> Not really. In DT an event triggered channel can be requested via router > >> (when this is used) for example: > >> > >> dmas = <_l2g a b c>; > >> a -

Re: [PATCH 01/18] dmaengine: of-dma: Add support for optional router configuration callback

2020-10-08 Thread Peter Ujfalusi
On 07/10/2020 8.44, Vinod Koul wrote: > Hi Peter, > > On 30-09-20, 12:13, Peter Ujfalusi wrote: >> Additional configuration for the DMA event router might be needed for a >> channel which can not be done during device_alloc_chan_resources callback >> since the router information is not yet

Re: [PATCH 01/18] dmaengine: of-dma: Add support for optional router configuration callback

2020-10-08 Thread Peter Ujfalusi
On 07/10/2020 18.55, Vinod Koul wrote: > On 07-10-20, 11:08, Peter Ujfalusi wrote: > >> Not really. In DT an event triggered channel can be requested via router >> (when this is used) for example: >> >> dmas = <_l2g a b c>; >> a - the input number of the DMA request in l2g >> b - edge or level

Re: [PATCH 01/18] dmaengine: of-dma: Add support for optional router configuration callback

2020-10-07 Thread Vinod Koul
On 07-10-20, 11:08, Peter Ujfalusi wrote: > Not really. In DT an event triggered channel can be requested via router > (when this is used) for example: > > dmas = <_l2g a b c>; > a - the input number of the DMA request in l2g > b - edge or level trigger to be selected > c - ASEL number for the

Re: [PATCH 01/18] dmaengine: of-dma: Add support for optional router configuration callback

2020-10-06 Thread Vinod Koul
Hi Peter, On 30-09-20, 12:13, Peter Ujfalusi wrote: > Additional configuration for the DMA event router might be needed for a > channel which can not be done during device_alloc_chan_resources callback > since the router information is not yet present for the drivers. > > If there is a need for

[PATCH 01/18] dmaengine: of-dma: Add support for optional router configuration callback

2020-09-30 Thread Peter Ujfalusi
Additional configuration for the DMA event router might be needed for a channel which can not be done during device_alloc_chan_resources callback since the router information is not yet present for the drivers. If there is a need for additional configuration for the channel if DMA router is in