Al Viro wrote:
> One general comment: I would strongly recommend splitting the iov_iter
> initializers change into a separate patch.
Done.
> > void *addr = kmap_atomic(page);
> >
> > written = copy_to_iter(addr, copy, iter);
>
> FWIW, I wonder if that
Al Viro wrote:
> One general comment: I would strongly recommend splitting the iov_iter
> initializers change into a separate patch.
Done.
> > void *addr = kmap_atomic(page);
> >
> > written = copy_to_iter(addr, copy, iter);
>
> FWIW, I wonder if that
On Sat, Oct 20, 2018 at 02:10:44AM +0100, David Howells wrote:
One general comment: I would strongly recommend splitting the iov_iter
initializers change into a separate patch.
> index 8d41ca7bfcf1..dcdbcb6f09f8 100644
> --- a/fs/cifs/file.c
> +++ b/fs/cifs/file.c
> @@ -2990,7 +2990,7 @@
On Sat, Oct 20, 2018 at 02:10:44AM +0100, David Howells wrote:
One general comment: I would strongly recommend splitting the iov_iter
initializers change into a separate patch.
> index 8d41ca7bfcf1..dcdbcb6f09f8 100644
> --- a/fs/cifs/file.c
> +++ b/fs/cifs/file.c
> @@ -2990,7 +2990,7 @@
In the iov_iter struct, separate the iterator type from the iterator
direction and use accessor functions to access them in most places.
Convert a bunch of places to use switch-statements to access them rather
then chains of bitwise-AND statements. This makes it easier to add further
iterator
In the iov_iter struct, separate the iterator type from the iterator
direction and use accessor functions to access them in most places.
Convert a bunch of places to use switch-statements to access them rather
then chains of bitwise-AND statements. This makes it easier to add further
iterator
6 matches
Mail list logo