Re: [PATCH 01/33] clk_ops: change round_rate() to return unsigned long

2018-01-02 Thread Stephen Boyd
On 01/02, Bryan O'Donoghue wrote: > On 02/01/18 19:01, Stephen Boyd wrote: > >On 12/31, Bryan O'Donoghue wrote: > >>On 30/12/17 16:36, Mikko Perttunen wrote: > >>>FWIW, we had this problem some years ago with the Tegra CPU clock > >>>- then it was determined that a simpler solution was to have the

Re: [PATCH 01/33] clk_ops: change round_rate() to return unsigned long

2018-01-02 Thread Stephen Boyd
On 01/02, Bryan O'Donoghue wrote: > On 02/01/18 19:01, Stephen Boyd wrote: > >On 12/31, Bryan O'Donoghue wrote: > >>On 30/12/17 16:36, Mikko Perttunen wrote: > >>>FWIW, we had this problem some years ago with the Tegra CPU clock > >>>- then it was determined that a simpler solution was to have the

Re: [PATCH 01/33] clk_ops: change round_rate() to return unsigned long

2018-01-02 Thread Bryan O'Donoghue
On 02/01/18 19:01, Stephen Boyd wrote: On 12/31, Bryan O'Donoghue wrote: On 30/12/17 16:36, Mikko Perttunen wrote: FWIW, we had this problem some years ago with the Tegra CPU clock - then it was determined that a simpler solution was to have the determine_rate callback support unsigned long

Re: [PATCH 01/33] clk_ops: change round_rate() to return unsigned long

2018-01-02 Thread Bryan O'Donoghue
On 02/01/18 19:01, Stephen Boyd wrote: On 12/31, Bryan O'Donoghue wrote: On 30/12/17 16:36, Mikko Perttunen wrote: FWIW, we had this problem some years ago with the Tegra CPU clock - then it was determined that a simpler solution was to have the determine_rate callback support unsigned long

Re: [PATCH 01/33] clk_ops: change round_rate() to return unsigned long

2018-01-02 Thread Stephen Boyd
On 12/31, Bryan O'Donoghue wrote: > On 30/12/17 16:36, Mikko Perttunen wrote: > >FWIW, we had this problem some years ago with the Tegra CPU clock > >- then it was determined that a simpler solution was to have the > >determine_rate callback support unsigned long rates - so clock > >drivers that

Re: [PATCH 01/33] clk_ops: change round_rate() to return unsigned long

2018-01-02 Thread Stephen Boyd
On 12/31, Bryan O'Donoghue wrote: > On 30/12/17 16:36, Mikko Perttunen wrote: > >FWIW, we had this problem some years ago with the Tegra CPU clock > >- then it was determined that a simpler solution was to have the > >determine_rate callback support unsigned long rates - so clock > >drivers that

Re: [PATCH 01/33] clk_ops: change round_rate() to return unsigned long

2018-01-01 Thread kbuild test robot
Hi Bryan, I love your patch! Perhaps something to improve: [auto build test WARNING on tegra/for-next] [also build test WARNING on v4.15-rc6] [cannot apply to clk/clk-next next-20171222] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 01/33] clk_ops: change round_rate() to return unsigned long

2018-01-01 Thread kbuild test robot
Hi Bryan, I love your patch! Perhaps something to improve: [auto build test WARNING on tegra/for-next] [also build test WARNING on v4.15-rc6] [cannot apply to clk/clk-next next-20171222] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 01/33] clk_ops: change round_rate() to return unsigned long

2018-01-01 Thread kbuild test robot
Hi Bryan, I love your patch! Yet something to improve: [auto build test ERROR on tegra/for-next] [also build test ERROR on v4.15-rc6] [cannot apply to clk/clk-next next-20171222] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 01/33] clk_ops: change round_rate() to return unsigned long

2018-01-01 Thread kbuild test robot
Hi Bryan, I love your patch! Yet something to improve: [auto build test ERROR on tegra/for-next] [also build test ERROR on v4.15-rc6] [cannot apply to clk/clk-next next-20171222] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 01/33] clk_ops: change round_rate() to return unsigned long

2018-01-01 Thread kbuild test robot
Hi Bryan, I love your patch! Perhaps something to improve: [auto build test WARNING on tegra/for-next] [also build test WARNING on v4.15-rc6] [cannot apply to clk/clk-next next-20171222] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 01/33] clk_ops: change round_rate() to return unsigned long

2018-01-01 Thread kbuild test robot
Hi Bryan, I love your patch! Perhaps something to improve: [auto build test WARNING on tegra/for-next] [also build test WARNING on v4.15-rc6] [cannot apply to clk/clk-next next-20171222] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 01/33] clk_ops: change round_rate() to return unsigned long

2017-12-31 Thread Bryan O'Donoghue
On 30/12/17 16:36, Mikko Perttunen wrote: FWIW, we had this problem some years ago with the Tegra CPU clock - then it was determined that a simpler solution was to have the determine_rate callback support unsigned long rates - so clock drivers that need to return rates higher than 2^31 can

Re: [PATCH 01/33] clk_ops: change round_rate() to return unsigned long

2017-12-31 Thread Bryan O'Donoghue
On 30/12/17 16:36, Mikko Perttunen wrote: FWIW, we had this problem some years ago with the Tegra CPU clock - then it was determined that a simpler solution was to have the determine_rate callback support unsigned long rates - so clock drivers that need to return rates higher than 2^31 can

Re: [PATCH 01/33] clk_ops: change round_rate() to return unsigned long

2017-12-30 Thread Mikko Perttunen
FWIW, we had this problem some years ago with the Tegra CPU clock - then it was determined that a simpler solution was to have the determine_rate callback support unsigned long rates - so clock drivers that need to return rates higher than 2^31 can instead implement the determine_rate

Re: [PATCH 01/33] clk_ops: change round_rate() to return unsigned long

2017-12-30 Thread Mikko Perttunen
FWIW, we had this problem some years ago with the Tegra CPU clock - then it was determined that a simpler solution was to have the determine_rate callback support unsigned long rates - so clock drivers that need to return rates higher than 2^31 can instead implement the determine_rate

[PATCH 01/33] clk_ops: change round_rate() to return unsigned long

2017-12-29 Thread Bryan O'Donoghue
Right now it is not possible to return a value larger than LONG_MAX on 32 bit systems. You can pass a rate of ULONG_MAX but can't return anything past LONG_MAX due to the fact both the rounded_rate and negative error codes are represented in the return value of round_rate(). Most implementations

[PATCH 01/33] clk_ops: change round_rate() to return unsigned long

2017-12-29 Thread Bryan O'Donoghue
Right now it is not possible to return a value larger than LONG_MAX on 32 bit systems. You can pass a rate of ULONG_MAX but can't return anything past LONG_MAX due to the fact both the rounded_rate and negative error codes are represented in the return value of round_rate(). Most implementations