On 25 February 2013 14:51, Mark Brown
wrote:
> On Mon, Feb 25, 2013 at 10:27:36AM +0100, Ulf Hansson wrote:
>> On 22 February 2013 11:38, Mark Brown
>
>> > Are you sure this actually does what you think it does, especially when
>> > run on modern kernels?
>
>> Not sure, what you are thinking of mo
On Mon, Feb 25, 2013 at 10:27:36AM +0100, Ulf Hansson wrote:
> On 22 February 2013 11:38, Mark Brown
> > Are you sure this actually does what you think it does, especially when
> > run on modern kernels?
> Not sure, what you are thinking of more precisely here. Runtime pm has
> been in the kernel
On 22 February 2013 11:38, Mark Brown
wrote:
> On Thu, Feb 21, 2013 at 11:45:08PM +0100, Ulf Hansson wrote:
>> On 20 February 2013 14:19, Mark Brown
>
>> > This doesn't look especially sane... You're doing a runtime get, taking
>> > the lock without releasing it and disabling the regulator. This
On Thu, Feb 21, 2013 at 11:45:08PM +0100, Ulf Hansson wrote:
> On 20 February 2013 14:19, Mark Brown
> > This doesn't look especially sane... You're doing a runtime get, taking
> > the lock without releasing it and disabling the regulator. This is
> > *very* odd, both the changelog and the code
On Thu, 21 Feb 2013, Ulf Hansson wrote:
> On 20 February 2013 14:19, Mark Brown
> wrote:
> > On Fri, Feb 15, 2013 at 12:56:32PM +, Lee Jones wrote:
> >
> >> +static int ab8500_gpadc_suspend(struct device *dev)
> >> +{
> >> + struct ab8500_gpadc *gpadc = dev_get_drvdata(dev);
> >> +
> >> +
On 20 February 2013 14:19, Mark Brown
wrote:
> On Fri, Feb 15, 2013 at 12:56:32PM +, Lee Jones wrote:
>
>> +static int ab8500_gpadc_suspend(struct device *dev)
>> +{
>> + struct ab8500_gpadc *gpadc = dev_get_drvdata(dev);
>> +
>> + mutex_lock(&gpadc->ab8500_gpadc_lock);
>> +
>> + p
On Fri, Feb 15, 2013 at 12:56:32PM +, Lee Jones wrote:
> +static int ab8500_gpadc_suspend(struct device *dev)
> +{
> + struct ab8500_gpadc *gpadc = dev_get_drvdata(dev);
> +
> + mutex_lock(&gpadc->ab8500_gpadc_lock);
> +
> + pm_runtime_get_sync(dev);
> +
> + regulator_disable(g
From: Daniel WILLERUD
suspend/resume methods implemented to prevent suspend while the gpadc
driver is busy.
Signed-off-by: Daniel WILLERUD
Signed-off-by: Lee Jones
Reviewed-by: Jonas ABERG
Reviewed-by: Ulf HANSSON
---
drivers/mfd/ab8500-gpadc.c | 28
1 file ch
8 matches
Mail list logo
