Re: [PATCH 02/10] migrate: make core migration code aware of hugepage

2013-04-05 Thread KOSAKI Motohiro
>>> There doesn't seem to be any caller for this function. Please move it to >>> the patch which uses it. >> >> I would do like that if there's only one user of this function, but I thought >> that it's better to separate this part as changes of common code >> because this function is commonly

Re: [PATCH 02/10] migrate: make core migration code aware of hugepage

2013-04-05 Thread KOSAKI Motohiro
There doesn't seem to be any caller for this function. Please move it to the patch which uses it. I would do like that if there's only one user of this function, but I thought that it's better to separate this part as changes of common code because this function is commonly used by multiple

Re: [PATCH 02/10] migrate: make core migration code aware of hugepage

2013-03-26 Thread Michal Hocko
On Tue 26-03-13 00:33:35, Naoya Horiguchi wrote: > On Mon, Mar 25, 2013 at 11:57:01AM +0100, Michal Hocko wrote: > > On Fri 22-03-13 16:23:47, Naoya Horiguchi wrote: [...] > > > +int migrate_movable_pages(struct list_head *from, new_page_t > > > get_new_page, > > > + unsigned long

Re: [PATCH 02/10] migrate: make core migration code aware of hugepage

2013-03-26 Thread Michal Hocko
On Tue 26-03-13 00:33:35, Naoya Horiguchi wrote: On Mon, Mar 25, 2013 at 11:57:01AM +0100, Michal Hocko wrote: On Fri 22-03-13 16:23:47, Naoya Horiguchi wrote: [...] +int migrate_movable_pages(struct list_head *from, new_page_t get_new_page, + unsigned long private,

Re: [PATCH 02/10] migrate: make core migration code aware of hugepage

2013-03-25 Thread Naoya Horiguchi
On Mon, Mar 25, 2013 at 11:57:01AM +0100, Michal Hocko wrote: > On Fri 22-03-13 16:23:47, Naoya Horiguchi wrote: ... > > diff --git v3.9-rc3.orig/mm/hugetlb.c v3.9-rc3/mm/hugetlb.c > > index 98a478e..a787c44 100644 > > --- v3.9-rc3.orig/mm/hugetlb.c > > +++ v3.9-rc3/mm/hugetlb.c > > @@ -48,7 +48,8

Re: [PATCH 02/10] migrate: make core migration code aware of hugepage

2013-03-25 Thread Michal Hocko
On Fri 22-03-13 16:23:47, Naoya Horiguchi wrote: > Before enabling each user of page migration to support hugepage, > this patch adds necessary changes on core migration code. > The main change is that the list of pages to migrate can link > not only LRU pages, but also hugepages. > Along with

Re: [PATCH 02/10] migrate: make core migration code aware of hugepage

2013-03-25 Thread Michal Hocko
On Fri 22-03-13 16:23:47, Naoya Horiguchi wrote: Before enabling each user of page migration to support hugepage, this patch adds necessary changes on core migration code. The main change is that the list of pages to migrate can link not only LRU pages, but also hugepages. Along with this,

Re: [PATCH 02/10] migrate: make core migration code aware of hugepage

2013-03-25 Thread Naoya Horiguchi
On Mon, Mar 25, 2013 at 11:57:01AM +0100, Michal Hocko wrote: On Fri 22-03-13 16:23:47, Naoya Horiguchi wrote: ... diff --git v3.9-rc3.orig/mm/hugetlb.c v3.9-rc3/mm/hugetlb.c index 98a478e..a787c44 100644 --- v3.9-rc3.orig/mm/hugetlb.c +++ v3.9-rc3/mm/hugetlb.c @@ -48,7 +48,8 @@ static

[PATCH 02/10] migrate: make core migration code aware of hugepage

2013-03-22 Thread Naoya Horiguchi
Before enabling each user of page migration to support hugepage, this patch adds necessary changes on core migration code. The main change is that the list of pages to migrate can link not only LRU pages, but also hugepages. Along with this, functions such as migrate_pages() and

[PATCH 02/10] migrate: make core migration code aware of hugepage

2013-03-22 Thread Naoya Horiguchi
Before enabling each user of page migration to support hugepage, this patch adds necessary changes on core migration code. The main change is that the list of pages to migrate can link not only LRU pages, but also hugepages. Along with this, functions such as migrate_pages() and