Re: [PATCH 02/11] x86: code shrink in paranoid_exit

2015-02-18 Thread Andy Lutomirski
On Wed, Jan 14, 2015 at 1:48 PM, Denys Vlasenko wrote: > RESTORE_EXTRA_REGS + RESTORE_C_REGS looks small, but it's > a lot of instructions (fourteen). Let's reuse them. > > Signed-off-by: Denys Vlasenko > CC: Linus Torvalds > CC: Oleg Nesterov > CC: Borislav Petkov > CC: "H. Peter Anvin" >

Re: [PATCH 02/11] x86: code shrink in paranoid_exit

2015-02-18 Thread Andy Lutomirski
On Wed, Jan 14, 2015 at 1:48 PM, Denys Vlasenko dvlas...@redhat.com wrote: RESTORE_EXTRA_REGS + RESTORE_C_REGS looks small, but it's a lot of instructions (fourteen). Let's reuse them. Signed-off-by: Denys Vlasenko dvlas...@redhat.com CC: Linus Torvalds torva...@linux-foundation.org CC: Oleg

Re: [PATCH 02/11] x86: code shrink in paranoid_exit

2015-02-11 Thread Andy Lutomirski
On Wed, Feb 11, 2015 at 1:13 PM, Denys Vlasenko wrote: > On 02/11/2015 09:36 PM, Andy Lutomirski wrote: >> On Wed, Jan 14, 2015 at 1:48 PM, Denys Vlasenko wrote: >>> RESTORE_EXTRA_REGS + RESTORE_C_REGS looks small, but it's >>> a lot of instructions (fourteen). Let's reuse them. >>> >>>

Re: [PATCH 02/11] x86: code shrink in paranoid_exit

2015-02-11 Thread Denys Vlasenko
On 02/11/2015 09:36 PM, Andy Lutomirski wrote: > On Wed, Jan 14, 2015 at 1:48 PM, Denys Vlasenko wrote: >> RESTORE_EXTRA_REGS + RESTORE_C_REGS looks small, but it's >> a lot of instructions (fourteen). Let's reuse them. >> >> Signed-off-by: Denys Vlasenko >> CC: Linus Torvalds >> CC: Oleg

Re: [PATCH 02/11] x86: code shrink in paranoid_exit

2015-02-11 Thread H. Peter Anvin
On 02/11/2015 12:36 PM, Andy Lutomirski wrote: > > This is sort of a reply to the wrong thread, but wouldn't it be nicer > if we could pop a bunch of regs instead of using mov followed by add? > (Yes, this could be a followup, but it could be easier to spot now by > changing macros like

Re: [PATCH 02/11] x86: code shrink in paranoid_exit

2015-02-11 Thread Andy Lutomirski
On Wed, Jan 14, 2015 at 1:48 PM, Denys Vlasenko wrote: > RESTORE_EXTRA_REGS + RESTORE_C_REGS looks small, but it's > a lot of instructions (fourteen). Let's reuse them. > > Signed-off-by: Denys Vlasenko > CC: Linus Torvalds > CC: Oleg Nesterov > CC: Borislav Petkov > CC: "H. Peter Anvin" >

Re: [PATCH 02/11] x86: code shrink in paranoid_exit

2015-02-11 Thread H. Peter Anvin
On 02/11/2015 12:36 PM, Andy Lutomirski wrote: This is sort of a reply to the wrong thread, but wouldn't it be nicer if we could pop a bunch of regs instead of using mov followed by add? (Yes, this could be a followup, but it could be easier to spot now by changing macros like RESTORE_XYZ.)

Re: [PATCH 02/11] x86: code shrink in paranoid_exit

2015-02-11 Thread Denys Vlasenko
On 02/11/2015 09:36 PM, Andy Lutomirski wrote: On Wed, Jan 14, 2015 at 1:48 PM, Denys Vlasenko dvlas...@redhat.com wrote: RESTORE_EXTRA_REGS + RESTORE_C_REGS looks small, but it's a lot of instructions (fourteen). Let's reuse them. Signed-off-by: Denys Vlasenko dvlas...@redhat.com CC: Linus

Re: [PATCH 02/11] x86: code shrink in paranoid_exit

2015-02-11 Thread Andy Lutomirski
On Wed, Jan 14, 2015 at 1:48 PM, Denys Vlasenko dvlas...@redhat.com wrote: RESTORE_EXTRA_REGS + RESTORE_C_REGS looks small, but it's a lot of instructions (fourteen). Let's reuse them. Signed-off-by: Denys Vlasenko dvlas...@redhat.com CC: Linus Torvalds torva...@linux-foundation.org CC: Oleg

Re: [PATCH 02/11] x86: code shrink in paranoid_exit

2015-02-11 Thread Andy Lutomirski
On Wed, Feb 11, 2015 at 1:13 PM, Denys Vlasenko dvlas...@redhat.com wrote: On 02/11/2015 09:36 PM, Andy Lutomirski wrote: On Wed, Jan 14, 2015 at 1:48 PM, Denys Vlasenko dvlas...@redhat.com wrote: RESTORE_EXTRA_REGS + RESTORE_C_REGS looks small, but it's a lot of instructions (fourteen). Let's

[PATCH 02/11] x86: code shrink in paranoid_exit

2015-01-14 Thread Denys Vlasenko
RESTORE_EXTRA_REGS + RESTORE_C_REGS looks small, but it's a lot of instructions (fourteen). Let's reuse them. Signed-off-by: Denys Vlasenko CC: Linus Torvalds CC: Oleg Nesterov CC: Borislav Petkov CC: "H. Peter Anvin" CC: Andy Lutomirski CC: Frederic Weisbecker CC: X86 ML CC: Alexei

[PATCH 02/11] x86: code shrink in paranoid_exit

2015-01-14 Thread Denys Vlasenko
RESTORE_EXTRA_REGS + RESTORE_C_REGS looks small, but it's a lot of instructions (fourteen). Let's reuse them. Signed-off-by: Denys Vlasenko dvlas...@redhat.com CC: Linus Torvalds torva...@linux-foundation.org CC: Oleg Nesterov o...@redhat.com CC: Borislav Petkov b...@alien8.de CC: H. Peter Anvin