Re: [PATCH 02/15] swiotlb: remove dma_mark_clean

2019-01-04 Thread Christoph Hellwig
One more ifdef to rescue.. Btw, do you know why we only play these mark clean bits for swiotlb and not for the various iommus? Also do you have any good receipe to build an ia64 cross compiler on a recent Debian system? Unlike most architectures Debian doesn't have a pre-built one, and the

Re: [PATCH 02/15] swiotlb: remove dma_mark_clean

2019-01-03 Thread Tony Luck
On Wed, Jan 2, 2019 at 11:23 PM Christoph Hellwig wrote: > I think something like the patch below should fix it: > > diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig > index ccd56f5df8cd..8d7396bd1790 100644 > --- a/arch/ia64/Kconfig > +++ b/arch/ia64/Kconfig > @@ -31,7 +31,7 @@ config IA64 >

Re: [PATCH 02/15] swiotlb: remove dma_mark_clean

2019-01-02 Thread Christoph Hellwig
On Wed, Jan 02, 2019 at 01:53:33PM -0800, Tony Luck wrote: > On Fri, Dec 7, 2018 at 11:08 AM Christoph Hellwig wrote: > > > > Instead of providing a special dma_mark_clean hook just for ia64, switch > > ia64 to use the normal arch_sync_dma_for_cpu hooks instead. > > > > This means that we now

Re: [PATCH 02/15] swiotlb: remove dma_mark_clean

2019-01-02 Thread Tony Luck
On Fri, Dec 7, 2018 at 11:08 AM Christoph Hellwig wrote: > > Instead of providing a special dma_mark_clean hook just for ia64, switch > ia64 to use the normal arch_sync_dma_for_cpu hooks instead. > > This means that we now also set the PG_arch_1 bit for pages in the > swiotlb buffer, which isn't

[PATCH 02/15] swiotlb: remove dma_mark_clean

2018-12-07 Thread Christoph Hellwig
Instead of providing a special dma_mark_clean hook just for ia64, switch ia64 to use the normal arch_sync_dma_for_cpu hooks instead. This means that we now also set the PG_arch_1 bit for pages in the swiotlb buffer, which isn't stricly needed as we will never execute code out of the swiotlb