[PATCH 02/16] perf symbol: remove unused 'end' arg in kallsyms parse cb

kallsyms__parse() takes a callback that is called on every discovered symbol. As /proc/kallsyms does not supply symbol sizes, the callback was simply called with end=start, faking the symbol size to 1. All of the callbacks (there are 2) used in calls to kallsyms__parse() are _only_ used as

Re: [PATCH 02/16] perf symbol: remove unused 'end' arg in kallsyms parse cb

I guess that length of 1 effectively same as zero length in this case since we end up calling symbols__fixup_end. The 'end - start + 1' part looks like a leftover from previous change and not needed anymore - KSYM_NAME_LEN check too, IMHO - so I suggest using 0 length to make it clear. Got it.

Re: [PATCH 02/16] perf symbol: remove unused 'end' arg in kallsyms parse cb

I guess that length of 1 effectively same as zero length in this case since we end up calling symbols__fixup_end. The 'end - start + 1' part looks like a leftover from previous change and not needed anymore - KSYM_NAME_LEN check too, IMHO - so I suggest using 0 length to make it clear. Got it.

[PATCH 02/16] perf symbol: remove unused 'end' arg in kallsyms parse cb

kallsyms__parse() takes a callback that is called on every discovered symbol. As /proc/kallsyms does not supply symbol sizes, the callback was simply called with end=start, faking the symbol size to 1. All of the callbacks (there are 2) used in calls to kallsyms__parse() are _only_ used as

Re: [PATCH 02/16] perf symbol: remove unused 'end' arg in kallsyms parse cb

Hi, Cody On Thu, 9 Aug 2012 15:18:27 -0700, Cody P. Schafer wrote: > kallsyms__parse() takes a callback that is called on every discovered > symbol. As /proc/kallsyms does not supply symbol sizes, the callback was > simply called with end=start, faking the symbol size to 1. > > All of the

[PATCH 02/16] perf symbol: remove unused 'end' arg in kallsyms parse cb

kallsyms__parse() takes a callback that is called on every discovered symbol. As /proc/kallsyms does not supply symbol sizes, the callback was simply called with end=start, faking the symbol size to 1. All of the callbacks (there are 2) used in calls to kallsyms__parse() are _only_ used as

[PATCH 02/16] perf symbol: remove unused 'end' arg in kallsyms parse cb

kallsyms__parse() takes a callback that is called on every discovered symbol. As /proc/kallsyms does not supply symbol sizes, the callback was simply called with end=start, faking the symbol size to 1. All of the callbacks (there are 2) used in calls to kallsyms__parse() are _only_ used as

Re: [PATCH 02/16] perf symbol: remove unused 'end' arg in kallsyms parse cb

Hi, Cody On Thu, 9 Aug 2012 15:18:27 -0700, Cody P. Schafer wrote: kallsyms__parse() takes a callback that is called on every discovered symbol. As /proc/kallsyms does not supply symbol sizes, the callback was simply called with end=start, faking the symbol size to 1. All of the callbacks