Re: [PATCH 02/17] cfi: add __cficanonical

2021-03-12 Thread Bjorn Helgaas
On Thu, Mar 11, 2021 at 04:49:04PM -0800, Sami Tolvanen wrote: > With CONFIG_CFI_CLANG, the compiler replaces a function address taken > in C code with the address of a local jump table entry, which passes > runtime indirect call checks. However, the compiler won't replace > addresses taken in

Re: [PATCH 02/17] cfi: add __cficanonical

2021-03-11 Thread Kees Cook
On Thu, Mar 11, 2021 at 04:49:04PM -0800, Sami Tolvanen wrote: > With CONFIG_CFI_CLANG, the compiler replaces a function address taken > in C code with the address of a local jump table entry, which passes > runtime indirect call checks. However, the compiler won't replace > addresses taken in

[PATCH 02/17] cfi: add __cficanonical

2021-03-11 Thread Sami Tolvanen
With CONFIG_CFI_CLANG, the compiler replaces a function address taken in C code with the address of a local jump table entry, which passes runtime indirect call checks. However, the compiler won't replace addresses taken in assembly code, which will result in a CFI failure if we later jump to such