Re: [PATCH 02/19] Input: Improve the events-per-packet estimate

2012-08-14 Thread Ping Cheng
On Tue, Aug 14, 2012 at 2:12 PM, Dmitry Torokhov wrote: > >> On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg > >> wrote: > >> > Many MT devices send a number of keys along with the mt information. > >> > This patch makes sure that there is room for them in the packet > >> > buffer. >> >> So,

Re: [PATCH 02/19] Input: Improve the events-per-packet estimate

2012-08-14 Thread Dmitry Torokhov
On Tue, Aug 14, 2012 at 01:50:38PM -0700, Ping Cheng wrote: > On Tue, Aug 14, 2012 at 12:53 PM, Dmitry Torokhov > wrote: > > On Tuesday, August 14, 2012 12:32:21 PM Ping Cheng wrote: > >> On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg > >> wrote: > >> > Many MT devices send a number of keys

Re: [PATCH 02/19] Input: Improve the events-per-packet estimate

2012-08-14 Thread Ping Cheng
On Tue, Aug 14, 2012 at 1:01 PM, Henrik Rydberg wrote: > Hi Ping, > > Long time no see. :-) > >> > + /* Make room for KEY and MSC events */ >> > + events += 7; >> >> It is nice to get rid of the redundant pieces and to incorporate >> common functions. Thank you. >> >> I have a

Re: [PATCH 02/19] Input: Improve the events-per-packet estimate

2012-08-14 Thread Ping Cheng
On Tue, Aug 14, 2012 at 12:53 PM, Dmitry Torokhov wrote: > On Tuesday, August 14, 2012 12:32:21 PM Ping Cheng wrote: >> On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg wrote: >> > Many MT devices send a number of keys along with the mt information. >> > This patch makes sure that there is room

Re: [PATCH 02/19] Input: Improve the events-per-packet estimate

2012-08-14 Thread Henrik Rydberg
Hi Ping, Long time no see. :-) > > + /* Make room for KEY and MSC events */ > > + events += 7; > > It is nice to get rid of the redundant pieces and to incorporate > common functions. Thank you. > > I have a question about the code above though. Why do we use 7 > instead of going

Re: [PATCH 02/19] Input: Improve the events-per-packet estimate

2012-08-14 Thread Dmitry Torokhov
On Tuesday, August 14, 2012 12:32:21 PM Ping Cheng wrote: > On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg wrote: > > Many MT devices send a number of keys along with the mt information. > > This patch makes sure that there is room for them in the packet > > buffer. > > > > Signed-off-by:

Re: [PATCH 02/19] Input: Improve the events-per-packet estimate

2012-08-14 Thread Ping Cheng
On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg wrote: > Many MT devices send a number of keys along with the mt information. > This patch makes sure that there is room for them in the packet > buffer. > > Signed-off-by: Henrik Rydberg > --- > drivers/input/input.c | 10 +++--- > 1 file

Re: [PATCH 02/19] Input: Improve the events-per-packet estimate

2012-08-14 Thread Ping Cheng
On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg rydb...@euromail.se wrote: Many MT devices send a number of keys along with the mt information. This patch makes sure that there is room for them in the packet buffer. Signed-off-by: Henrik Rydberg rydb...@euromail.se ---

Re: [PATCH 02/19] Input: Improve the events-per-packet estimate

2012-08-14 Thread Dmitry Torokhov
On Tuesday, August 14, 2012 12:32:21 PM Ping Cheng wrote: On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg rydb...@euromail.se wrote: Many MT devices send a number of keys along with the mt information. This patch makes sure that there is room for them in the packet buffer.

Re: [PATCH 02/19] Input: Improve the events-per-packet estimate

2012-08-14 Thread Henrik Rydberg
Hi Ping, Long time no see. :-) + /* Make room for KEY and MSC events */ + events += 7; It is nice to get rid of the redundant pieces and to incorporate common functions. Thank you. I have a question about the code above though. Why do we use 7 instead of going through

Re: [PATCH 02/19] Input: Improve the events-per-packet estimate

2012-08-14 Thread Ping Cheng
On Tue, Aug 14, 2012 at 12:53 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Tuesday, August 14, 2012 12:32:21 PM Ping Cheng wrote: On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg rydb...@euromail.se wrote: Many MT devices send a number of keys along with the mt information. This

Re: [PATCH 02/19] Input: Improve the events-per-packet estimate

2012-08-14 Thread Ping Cheng
On Tue, Aug 14, 2012 at 1:01 PM, Henrik Rydberg rydb...@euromail.se wrote: Hi Ping, Long time no see. :-) + /* Make room for KEY and MSC events */ + events += 7; It is nice to get rid of the redundant pieces and to incorporate common functions. Thank you. I have a question

Re: [PATCH 02/19] Input: Improve the events-per-packet estimate

2012-08-14 Thread Dmitry Torokhov
On Tue, Aug 14, 2012 at 01:50:38PM -0700, Ping Cheng wrote: On Tue, Aug 14, 2012 at 12:53 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Tuesday, August 14, 2012 12:32:21 PM Ping Cheng wrote: On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg rydb...@euromail.se wrote: Many MT

Re: [PATCH 02/19] Input: Improve the events-per-packet estimate

2012-08-14 Thread Ping Cheng
On Tue, Aug 14, 2012 at 2:12 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Sun, Aug 12, 2012 at 2:42 PM, Henrik Rydberg rydb...@euromail.se wrote: Many MT devices send a number of keys along with the mt information. This patch makes sure that there is room for them in the

[PATCH 02/19] Input: Improve the events-per-packet estimate

2012-08-12 Thread Henrik Rydberg
Many MT devices send a number of keys along with the mt information. This patch makes sure that there is room for them in the packet buffer. Signed-off-by: Henrik Rydberg --- drivers/input/input.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git

[PATCH 02/19] Input: Improve the events-per-packet estimate

2012-08-12 Thread Henrik Rydberg
Many MT devices send a number of keys along with the mt information. This patch makes sure that there is room for them in the packet buffer. Signed-off-by: Henrik Rydberg rydb...@euromail.se --- drivers/input/input.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git