Re: [PATCH 02/19] dma-iommu: cleanup dma-iommu.h

2019-02-11 Thread Christoph Hellwig
On Wed, Feb 06, 2019 at 03:08:26PM +, Robin Murphy wrote: > Other than dma-iommu.c itself, none of them *require* it - only arch/arm64 > selects it (the one from MTK_IOMMU is just bogus), and a lot of the drivers > also build for at least one other architecture (and/or arm64 with >

Re: [PATCH 02/19] dma-iommu: cleanup dma-iommu.h

2019-02-06 Thread Robin Murphy
On 01/02/2019 16:13, Christoph Hellwig wrote: On Fri, Feb 01, 2019 at 02:47:17PM +, Robin Murphy wrote: On 14/01/2019 09:41, Christoph Hellwig wrote: No need for a __KERNEL__ guard outside uapi, make sure we pull in the includes unconditionally so users can rely on it, and add a missing

Re: [PATCH 02/19] dma-iommu: cleanup dma-iommu.h

2019-02-01 Thread Christoph Hellwig
On Fri, Feb 01, 2019 at 02:47:17PM +, Robin Murphy wrote: > On 14/01/2019 09:41, Christoph Hellwig wrote: >> No need for a __KERNEL__ guard outside uapi, make sure we pull in the >> includes unconditionally so users can rely on it, and add a missing >> comment describing the #else cpp

Re: [PATCH 02/19] dma-iommu: cleanup dma-iommu.h

2019-02-01 Thread Robin Murphy
On 14/01/2019 09:41, Christoph Hellwig wrote: No need for a __KERNEL__ guard outside uapi, make sure we pull in the includes unconditionally so users can rely on it, and add a missing comment describing the #else cpp statement. Last but not least include instead of the asm version, which is

[PATCH 02/19] dma-iommu: cleanup dma-iommu.h

2019-01-14 Thread Christoph Hellwig
No need for a __KERNEL__ guard outside uapi, make sure we pull in the includes unconditionally so users can rely on it, and add a missing comment describing the #else cpp statement. Last but not least include instead of the asm version, which is frowned upon. Signed-off-by: Christoph Hellwig