Re: [PATCH 02/26] pstore: add flags

2012-10-25 Thread Tatulea, Dragos
On Tue, Oct 23, 2012 at 7:57 PM, Luck, Tony wrote: >> I wonder if the default should be to not show headers, and to add this >> flag to the backends that want the pstore-added header. I think the >> more common case going forward will to be without headers since >> backends should arguably

Re: [PATCH 02/26] pstore: add flags

2012-10-25 Thread Tatulea, Dragos
On Tue, Oct 23, 2012 at 7:57 PM, Luck, Tony tony.l...@intel.com wrote: I wonder if the default should be to not show headers, and to add this flag to the backends that want the pstore-added header. I think the more common case going forward will to be without headers since backends should

RE: [PATCH 02/26] pstore: add flags

2012-10-23 Thread Luck, Tony
> I wonder if the default should be to not show headers, and to add this > flag to the backends that want the pstore-added header. I think the > more common case going forward will to be without headers since > backends should arguably storing metadata themselves. Perhaps just add the headings

Re: [PATCH 02/26] pstore: add flags

2012-10-23 Thread Kees Cook
On Tue, Oct 23, 2012 at 6:48 AM, Irina Tirdea wrote: > From: Adrian Hunter > > Let the back end tweak pstore behaviour. Flags added are: > > PSTORE_NO_HEADINGS > > Omit pstore heading lines from dumped data I wonder if the default should be to not show headers, and to

[PATCH 02/26] pstore: add flags

2012-10-23 Thread Irina Tirdea
From: Adrian Hunter Let the back end tweak pstore behaviour. Flags added are: PSTORE_NO_HEADINGS Omit pstore heading lines from dumped data PSTORE_MAX_KMSG_BYTES Default kmsg_bytes to ULONG_MAX Signed-off-by: Adrian Hunter Signed-off-by:

[PATCH 02/26] pstore: add flags

2012-10-23 Thread Irina Tirdea
From: Adrian Hunter adrian.hun...@intel.com Let the back end tweak pstore behaviour. Flags added are: PSTORE_NO_HEADINGS Omit pstore heading lines from dumped data PSTORE_MAX_KMSG_BYTES Default kmsg_bytes to ULONG_MAX Signed-off-by: Adrian

Re: [PATCH 02/26] pstore: add flags

2012-10-23 Thread Kees Cook
On Tue, Oct 23, 2012 at 6:48 AM, Irina Tirdea irina.tir...@intel.com wrote: From: Adrian Hunter adrian.hun...@intel.com Let the back end tweak pstore behaviour. Flags added are: PSTORE_NO_HEADINGS Omit pstore heading lines from dumped data I wonder if the default

RE: [PATCH 02/26] pstore: add flags

2012-10-23 Thread Luck, Tony
I wonder if the default should be to not show headers, and to add this flag to the backends that want the pstore-added header. I think the more common case going forward will to be without headers since backends should arguably storing metadata themselves. Perhaps just add the headings when