Re: [PATCH 02/27] perf tools: Fix tab vs spaces issue in Makefile ifdef/endif

2013-04-01 Thread Jiri Olsa
On Mon, Apr 01, 2013 at 09:49:05PM +0200, Sam Ravnborg wrote: > On Mon, Apr 01, 2013 at 09:18:25PM +0200, Jiri Olsa wrote: > > Unmatched spaces/tabs Makefile indentation could make the > > Makefile fails. While the tabed line could be considered > > sometimes as follow up for rule command, the

Re: [PATCH 02/27] perf tools: Fix tab vs spaces issue in Makefile ifdef/endif

2013-04-01 Thread Sam Ravnborg
On Mon, Apr 01, 2013 at 09:18:25PM +0200, Jiri Olsa wrote: > Unmatched spaces/tabs Makefile indentation could make the > Makefile fails. While the tabed line could be considered > sometimes as follow up for rule command, the mixed space > tab meses up with makefile if conditions. I have too many

[PATCH 02/27] perf tools: Fix tab vs spaces issue in Makefile ifdef/endif

2013-04-01 Thread Jiri Olsa
Unmatched spaces/tabs Makefile indentation could make the Makefile fails. While the tabed line could be considered sometimes as follow up for rule command, the mixed space tab meses up with makefile if conditions. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc:

[PATCH 02/27] perf tools: Fix tab vs spaces issue in Makefile ifdef/endif

2013-04-01 Thread Jiri Olsa
Unmatched spaces/tabs Makefile indentation could make the Makefile fails. While the tabed line could be considered sometimes as follow up for rule command, the mixed space tab meses up with makefile if conditions. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo

Re: [PATCH 02/27] perf tools: Fix tab vs spaces issue in Makefile ifdef/endif

2013-04-01 Thread Sam Ravnborg
On Mon, Apr 01, 2013 at 09:18:25PM +0200, Jiri Olsa wrote: Unmatched spaces/tabs Makefile indentation could make the Makefile fails. While the tabed line could be considered sometimes as follow up for rule command, the mixed space tab meses up with makefile if conditions. I have too many

Re: [PATCH 02/27] perf tools: Fix tab vs spaces issue in Makefile ifdef/endif

2013-04-01 Thread Jiri Olsa
On Mon, Apr 01, 2013 at 09:49:05PM +0200, Sam Ravnborg wrote: On Mon, Apr 01, 2013 at 09:18:25PM +0200, Jiri Olsa wrote: Unmatched spaces/tabs Makefile indentation could make the Makefile fails. While the tabed line could be considered sometimes as follow up for rule command, the mixed