Re: [PATCH 03/11] Input: synaptics-rmi4 - do not update configuration in rmi_f01_probe()

2014-03-18 Thread Christopher Heiny
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote: Do not write configuration data in probe(), we have config() for that. I've just submitted a patch to correctly call config() after probe(). So this becomes... Signed-off-by: Christopher Heiny Signed-off-by: Dmitry Torokhov ---

Re: [PATCH 03/11] Input: synaptics-rmi4 - do not update configuration in rmi_f01_probe()

2014-03-18 Thread Christopher Heiny
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote: Do not write configuration data in probe(), we have config() for that. I've just submitted a patch to correctly call config() after probe(). So this becomes... Signed-off-by: Christopher Heiny che...@synaptics.com Signed-off-by: Dmitry

Re: [PATCH 03/11] Input: synaptics-rmi4 - do not update configuration in rmi_f01_probe()

2014-02-18 Thread Christopher Heiny
On 02/17/2014 11:23 AM, Dmitry Torokhov wrote: On Fri, Feb 14, 2014 at 03:00:43PM -0800, Christopher Heiny wrote: On 02/13/2014 01:54 PM, Dmitry Torokhov wrote: On Thu, Feb 13, 2014 at 11:23:44AM -0800, Christopher Heiny wrote: On 02/12/2014 09:27 PM, Dmitry Torokhov wrote: Do not write

Re: [PATCH 03/11] Input: synaptics-rmi4 - do not update configuration in rmi_f01_probe()

2014-02-18 Thread Christopher Heiny
On 02/17/2014 11:23 AM, Dmitry Torokhov wrote: On Fri, Feb 14, 2014 at 03:00:43PM -0800, Christopher Heiny wrote: On 02/13/2014 01:54 PM, Dmitry Torokhov wrote: On Thu, Feb 13, 2014 at 11:23:44AM -0800, Christopher Heiny wrote: On 02/12/2014 09:27 PM, Dmitry Torokhov wrote: Do not write

Re: [PATCH 03/11] Input: synaptics-rmi4 - do not update configuration in rmi_f01_probe()

2014-02-17 Thread Dmitry Torokhov
On Fri, Feb 14, 2014 at 03:00:43PM -0800, Christopher Heiny wrote: > On 02/13/2014 01:54 PM, Dmitry Torokhov wrote: > >On Thu, Feb 13, 2014 at 11:23:44AM -0800, Christopher Heiny wrote: > >>>On 02/12/2014 09:27 PM, Dmitry Torokhov wrote: > >Do not write configuration data in probe(), we have

Re: [PATCH 03/11] Input: synaptics-rmi4 - do not update configuration in rmi_f01_probe()

2014-02-17 Thread Dmitry Torokhov
On Fri, Feb 14, 2014 at 03:00:43PM -0800, Christopher Heiny wrote: On 02/13/2014 01:54 PM, Dmitry Torokhov wrote: On Thu, Feb 13, 2014 at 11:23:44AM -0800, Christopher Heiny wrote: On 02/12/2014 09:27 PM, Dmitry Torokhov wrote: Do not write configuration data in probe(), we have config() for

Re: [PATCH 03/11] Input: synaptics-rmi4 - do not update configuration in rmi_f01_probe()

2014-02-14 Thread Christopher Heiny
On 02/13/2014 01:54 PM, Dmitry Torokhov wrote: On Thu, Feb 13, 2014 at 11:23:44AM -0800, Christopher Heiny wrote: >On 02/12/2014 09:27 PM, Dmitry Torokhov wrote: > >Do not write configuration data in probe(), we have config() for that. > >Then we should call config() in rmi_function_probe()

Re: [PATCH 03/11] Input: synaptics-rmi4 - do not update configuration in rmi_f01_probe()

2014-02-14 Thread Dmitry Torokhov
On Thu, Feb 13, 2014 at 11:23:44AM -0800, Christopher Heiny wrote: > On 02/12/2014 09:27 PM, Dmitry Torokhov wrote: > >Do not write configuration data in probe(), we have config() for that. > > Then we should call config() in rmi_function_probe() to ensure that > any platform data or device tree

Re: [PATCH 03/11] Input: synaptics-rmi4 - do not update configuration in rmi_f01_probe()

2014-02-14 Thread Dmitry Torokhov
On Thu, Feb 13, 2014 at 11:23:44AM -0800, Christopher Heiny wrote: On 02/12/2014 09:27 PM, Dmitry Torokhov wrote: Do not write configuration data in probe(), we have config() for that. Then we should call config() in rmi_function_probe() to ensure that any platform data or device tree

Re: [PATCH 03/11] Input: synaptics-rmi4 - do not update configuration in rmi_f01_probe()

2014-02-14 Thread Christopher Heiny
On 02/13/2014 01:54 PM, Dmitry Torokhov wrote: On Thu, Feb 13, 2014 at 11:23:44AM -0800, Christopher Heiny wrote: On 02/12/2014 09:27 PM, Dmitry Torokhov wrote: Do not write configuration data in probe(), we have config() for that. Then we should call config() in rmi_function_probe() to

Re: [PATCH 03/11] Input: synaptics-rmi4 - do not update configuration in rmi_f01_probe()

2014-02-13 Thread Christopher Heiny
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote: Do not write configuration data in probe(), we have config() for that. Then we should call config() in rmi_function_probe() to ensure that any platform data or device tree configuration settings get written to the device. Thinking about that, it

Re: [PATCH 03/11] Input: synaptics-rmi4 - do not update configuration in rmi_f01_probe()

2014-02-13 Thread Christopher Heiny
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote: Do not write configuration data in probe(), we have config() for that. Then we should call config() in rmi_function_probe() to ensure that any platform data or device tree configuration settings get written to the device. Thinking about that, it

[PATCH 03/11] Input: synaptics-rmi4 - do not update configuration in rmi_f01_probe()

2014-02-12 Thread Dmitry Torokhov
Do not write configuration data in probe(), we have config() for that. Signed-off-by: Dmitry Torokhov --- drivers/input/rmi4/rmi_f01.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/drivers/input/rmi4/rmi_f01.c b/drivers/input/rmi4/rmi_f01.c index 897d8ac..976aba3 100644

[PATCH 03/11] Input: synaptics-rmi4 - do not update configuration in rmi_f01_probe()

2014-02-12 Thread Dmitry Torokhov
Do not write configuration data in probe(), we have config() for that. Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com --- drivers/input/rmi4/rmi_f01.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/drivers/input/rmi4/rmi_f01.c b/drivers/input/rmi4/rmi_f01.c