Re: [PATCH 03/14] soundwire: Add Master registration

2017-11-09 Thread Vinod Koul
On Thu, Nov 09, 2017 at 09:14:16PM +, Srinivas Kandagatla wrote: > > > On 19/10/17 04:03, Vinod Koul wrote: > > >+/** > >+ * sdw_add_bus_master: add a bus Master instance > >+ * > >+ * @bus: bus instance > >+ * > >+ * Initializes the bus instance, read properties and create child > >+ * devi

Re: [PATCH 03/14] soundwire: Add Master registration

2017-11-09 Thread Srinivas Kandagatla
On 19/10/17 04:03, Vinod Koul wrote: +/** + * sdw_add_bus_master: add a bus Master instance + * + * @bus: bus instance + * + * Initializes the bus instance, read properties and create child + * devices. + */ Some of the exported functions are missing kerneldocs. Is it something you plan to a

Re: [PATCH 03/14] soundwire: Add Master registration

2017-10-23 Thread Vinod Koul
On Mon, Oct 23, 2017 at 09:24:26AM +0100, Mark Brown wrote: > On Sat, Oct 21, 2017 at 05:05:13PM +0530, Vinod Koul wrote: > > On Sat, Oct 21, 2017 at 10:12:30AM +0100, Mark Brown wrote: > > > On Thu, Oct 19, 2017 at 08:33:19AM +0530, Vinod Koul wrote: > > > > > + mutex_lock(&bus->bus_lock);

Re: [PATCH 03/14] soundwire: Add Master registration

2017-10-23 Thread Mark Brown
On Sat, Oct 21, 2017 at 05:05:13PM +0530, Vinod Koul wrote: > On Sat, Oct 21, 2017 at 10:12:30AM +0100, Mark Brown wrote: > > On Thu, Oct 19, 2017 at 08:33:19AM +0530, Vinod Koul wrote: > > > + mutex_lock(&bus->bus_lock); > > > + if (!list_empty(&bus->slaves)) > > > + list_del(&slave->node

Re: [PATCH 03/14] soundwire: Add Master registration

2017-10-21 Thread Vinod Koul
On Sat, Oct 21, 2017 at 10:12:30AM +0100, Mark Brown wrote: > On Thu, Oct 19, 2017 at 08:33:19AM +0530, Vinod Koul wrote: > > > + /* > > +* SDW is an enumerable bus, but devices can be powered off. So, > > +* they won't be able to report as present. > > +* > > +* Create Slave dev

Re: [PATCH 03/14] soundwire: Add Master registration

2017-10-21 Thread Mark Brown
On Thu, Oct 19, 2017 at 08:33:19AM +0530, Vinod Koul wrote: > + /* > + * SDW is an enumerable bus, but devices can be powered off. So, > + * they won't be able to report as present. > + * > + * Create Slave devices based on Slaves described in > + * the respective firm

Re: [PATCH 03/14] soundwire: Add Master registration

2017-10-20 Thread Vinod Koul
On Fri, Oct 20, 2017 at 12:47:26PM +0200, Greg Kroah-Hartman wrote: > On Thu, Oct 19, 2017 at 08:33:19AM +0530, Vinod Koul wrote: > > +void sdw_extract_slave_id(struct sdw_bus *bus, > > + unsigned long long addr, struct sdw_slave_id *id) > > +{ > > + dev_dbg(bus->dev, "SDW Slave

Re: [PATCH 03/14] soundwire: Add Master registration

2017-10-20 Thread Greg Kroah-Hartman
On Thu, Oct 19, 2017 at 08:33:19AM +0530, Vinod Koul wrote: > +void sdw_extract_slave_id(struct sdw_bus *bus, > + unsigned long long addr, struct sdw_slave_id *id) > +{ > + dev_dbg(bus->dev, "SDW Slave Addr: %llx", addr); > + > + /* > + * Spec definition > + *

Re: [alsa-devel] [PATCH 03/14] soundwire: Add Master registration

2017-10-19 Thread Vinod Koul
On Thu, Oct 19, 2017 at 10:54:50AM +0200, Takashi Iwai wrote: > On Thu, 19 Oct 2017 05:03:19 +0200, > Vinod Koul wrote: > > +int sdw_add_bus_master(struct sdw_bus *bus) > > +{ > > + int ret; > > + > > + if (!bus->dev) { > > + pr_err("SoundWire bus has no device"); > > + ret

Re: [alsa-devel] [PATCH 03/14] soundwire: Add Master registration

2017-10-19 Thread Takashi Iwai
On Thu, 19 Oct 2017 05:03:19 +0200, Vinod Koul wrote: > > +/** > + * sdw_add_bus_master: add a bus Master instance > + * > + * @bus: bus instance > + * > + * Initializes the bus instance, read properties and create child > + * devices. > + */ > +int sdw_add_bus_master(struct sdw_bus *bus) > +{ > +

[PATCH 03/14] soundwire: Add Master registration

2017-10-18 Thread Vinod Koul
A Master registers with SoundWire bus and scans the firmware provided for device description. In this patch we scan the ACPI namespaces and create the SoundWire Slave devices based on the ACPI description Signed-off-by: Sanyog Kale Signed-off-by: Vinod Koul --- drivers/soundwire/Makefile|