Re: [PATCH 03/15] cfq-iosched: Rename "service_tree" to "st"

2012-10-02 Thread Tejun Heo
Hello, On Tue, Oct 02, 2012 at 09:26:03AM -0400, Vivek Goyal wrote: > Yes this one is little odd. Ok, I will change it back to "service_tree" > and only use "st" for local variables and in some function names. Yes, please do that. In general, it's beneficial to use at least somewhat descriptive

Re: [PATCH 03/15] cfq-iosched: Rename "service_tree" to "st"

2012-10-02 Thread Vivek Goyal
On Mon, Oct 01, 2012 at 04:52:13PM -0400, Jeff Moyer wrote: > Vivek Goyal writes: > > > At quite a few places we use the keyword "service_tree" and I feel that > > names in CFQ are already very long and they need to be shortened a bit > > where appropriate. > > > > So this patch just renames

Re: [PATCH 03/15] cfq-iosched: Rename service_tree to st

2012-10-02 Thread Vivek Goyal
On Mon, Oct 01, 2012 at 04:52:13PM -0400, Jeff Moyer wrote: Vivek Goyal vgo...@redhat.com writes: At quite a few places we use the keyword service_tree and I feel that names in CFQ are already very long and they need to be shortened a bit where appropriate. So this patch just renames

Re: [PATCH 03/15] cfq-iosched: Rename service_tree to st

2012-10-02 Thread Tejun Heo
Hello, On Tue, Oct 02, 2012 at 09:26:03AM -0400, Vivek Goyal wrote: Yes this one is little odd. Ok, I will change it back to service_tree and only use st for local variables and in some function names. Yes, please do that. In general, it's beneficial to use at least somewhat descriptive names

Re: [PATCH 03/15] cfq-iosched: Rename "service_tree" to "st"

2012-10-01 Thread Jeff Moyer
Vivek Goyal writes: > At quite a few places we use the keyword "service_tree" and I feel that > names in CFQ are already very long and they need to be shortened a bit > where appropriate. > > So this patch just renames "service_tree" to "st" at most of the places. > No functionality change.

[PATCH 03/15] cfq-iosched: Rename "service_tree" to "st"

2012-10-01 Thread Vivek Goyal
At quite a few places we use the keyword "service_tree" and I feel that names in CFQ are already very long and they need to be shortened a bit where appropriate. So this patch just renames "service_tree" to "st" at most of the places. No functionality change. Signed-off-by: Vivek Goyal ---

[PATCH 03/15] cfq-iosched: Rename service_tree to st

2012-10-01 Thread Vivek Goyal
At quite a few places we use the keyword service_tree and I feel that names in CFQ are already very long and they need to be shortened a bit where appropriate. So this patch just renames service_tree to st at most of the places. No functionality change. Signed-off-by: Vivek Goyal

Re: [PATCH 03/15] cfq-iosched: Rename service_tree to st

2012-10-01 Thread Jeff Moyer
Vivek Goyal vgo...@redhat.com writes: At quite a few places we use the keyword service_tree and I feel that names in CFQ are already very long and they need to be shortened a bit where appropriate. So this patch just renames service_tree to st at most of the places. No functionality change.