Re: [PATCH 03/15] mm: Add file_offset_of_ helpers

2019-10-04 Thread Matthew Wilcox
On Thu, Sep 26, 2019 at 05:02:11PM +0300, Kirill A. Shutemov wrote: > On Tue, Sep 24, 2019 at 05:52:02PM -0700, Matthew Wilcox wrote: > > From: "Matthew Wilcox (Oracle)" > > > > The page_offset function is badly named for people reading the functions > > which call it. The natural meaning of a

Re: [PATCH 03/15] mm: Add file_offset_of_ helpers

2019-10-04 Thread Matthew Wilcox
Your mail program is still broken. This shows up as a reply to the 0/15 email instead of as a reply to the 3/15 email. On Wed, Oct 02, 2019 at 09:07:53PM +0800, Hillf Danton wrote: > On Tue, 24 Sep 2019 17:52:02 -0700 From: Matthew Wilcox (Oracle) > > +/** > > + * file_offset_of_page - File

Re: [PATCH 03/15] mm: Add file_offset_of_ helpers

2019-09-26 Thread Kirill A. Shutemov
On Tue, Sep 24, 2019 at 05:52:02PM -0700, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > The page_offset function is badly named for people reading the functions > which call it. The natural meaning of a function with this name would > be 'offset within a page', not 'page offset in

[PATCH 03/15] mm: Add file_offset_of_ helpers

2019-09-24 Thread Matthew Wilcox
From: "Matthew Wilcox (Oracle)" The page_offset function is badly named for people reading the functions which call it. The natural meaning of a function with this name would be 'offset within a page', not 'page offset in bytes within a file'. Dave Chinner suggests file_offset_of_page() as a