Re: [PATCH 03/19] dma-iommu: don't use a scatterlist in iommu_dma_alloc

2019-02-11 Thread Christoph Hellwig
On Wed, Feb 06, 2019 at 03:28:28PM +, Robin Murphy wrote: > Because if iommu_map() only gets called at PAGE_SIZE granularity, then the > IOMMU PTEs will be created at PAGE_SIZE (or smaller) granularity, so any > effort to get higher-order allocations matching larger IOMMU block sizes is >

Re: [PATCH 03/19] dma-iommu: don't use a scatterlist in iommu_dma_alloc

2019-02-06 Thread Robin Murphy
On 01/02/2019 16:16, Christoph Hellwig wrote: On Fri, Feb 01, 2019 at 03:24:45PM +, Robin Murphy wrote: On 14/01/2019 09:41, Christoph Hellwig wrote: Directly iterating over the pages makes the code a bit simpler and prepares for the following changes. It also defeats the whole purpose

Re: [PATCH 03/19] dma-iommu: don't use a scatterlist in iommu_dma_alloc

2019-02-01 Thread Christoph Hellwig
On Fri, Feb 01, 2019 at 03:24:45PM +, Robin Murphy wrote: > On 14/01/2019 09:41, Christoph Hellwig wrote: >> Directly iterating over the pages makes the code a bit simpler and >> prepares for the following changes. > > It also defeats the whole purpose of __iommu_dma_alloc_pages(), so I'm not

Re: [PATCH 03/19] dma-iommu: don't use a scatterlist in iommu_dma_alloc

2019-02-01 Thread Robin Murphy
On 14/01/2019 09:41, Christoph Hellwig wrote: Directly iterating over the pages makes the code a bit simpler and prepares for the following changes. It also defeats the whole purpose of __iommu_dma_alloc_pages(), so I'm not really buying the simplification angle - you've *seen* that code,

[PATCH 03/19] dma-iommu: don't use a scatterlist in iommu_dma_alloc

2019-01-14 Thread Christoph Hellwig
Directly iterating over the pages makes the code a bit simpler and prepares for the following changes. Signed-off-by: Christoph Hellwig --- drivers/iommu/dma-iommu.c | 40 +-- 1 file changed, 17 insertions(+), 23 deletions(-) diff --git