[PATCH 03/22] KEYS: Provide missing asymmetric key subops for new key type ops [ver #2]

2018-10-09 Thread David Howells
Provide the missing asymmetric key subops for new key type ops. This include query, encrypt, decrypt and create signature. Verify signature already exists. Also provided are accessor functions for this: int query_asymmetric_key(const struct key *key,

[PATCH 03/22] KEYS: Provide missing asymmetric key subops for new key type ops [ver #2]

2018-10-09 Thread David Howells
Provide the missing asymmetric key subops for new key type ops. This include query, encrypt, decrypt and create signature. Verify signature already exists. Also provided are accessor functions for this: int query_asymmetric_key(const struct key *key,

Re: [PATCH 03/22] KEYS: Provide missing asymmetric key subops for new key type ops

2018-10-05 Thread David Howells
James Morris wrote: > > + pr_devel("==>%s()\n", __func__); > > Are you planning on leaving these pr_devel()s in? Well, they don't do anything unless you #define DEBUG at the top of the file. If they really offend you, I can remove them. David

Re: [PATCH 03/22] KEYS: Provide missing asymmetric key subops for new key type ops

2018-10-05 Thread David Howells
James Morris wrote: > > + pr_devel("==>%s()\n", __func__); > > Are you planning on leaving these pr_devel()s in? Well, they don't do anything unless you #define DEBUG at the top of the file. If they really offend you, I can remove them. David

Re: [PATCH 03/22] KEYS: Provide missing asymmetric key subops for new key type ops

2018-10-03 Thread James Morris
On Wed, 5 Sep 2018, David Howells wrote: > +int asymmetric_key_eds_op(struct kernel_pkey_params *params, > + const void *in, void *out) > +{ > + const struct asymmetric_key_subtype *subtype; > + struct key *key = params->key; > + int ret; > + > +

Re: [PATCH 03/22] KEYS: Provide missing asymmetric key subops for new key type ops

2018-10-03 Thread James Morris
On Wed, 5 Sep 2018, David Howells wrote: > +int asymmetric_key_eds_op(struct kernel_pkey_params *params, > + const void *in, void *out) > +{ > + const struct asymmetric_key_subtype *subtype; > + struct key *key = params->key; > + int ret; > + > +

[PATCH 03/22] KEYS: Provide missing asymmetric key subops for new key type ops

2018-09-05 Thread David Howells
Provide the missing asymmetric key subops for new key type ops. This include query, encrypt, decrypt and create signature. Verify signature already exists. Also provided are accessor functions for this: int query_asymmetric_key(const struct key *key,

[PATCH 03/22] KEYS: Provide missing asymmetric key subops for new key type ops

2018-09-05 Thread David Howells
Provide the missing asymmetric key subops for new key type ops. This include query, encrypt, decrypt and create signature. Verify signature already exists. Also provided are accessor functions for this: int query_asymmetric_key(const struct key *key,