Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

On Mon, Jan 29, 2018 at 08:21:08PM +0100, Peter Zijlstra wrote: > On Mon, Jan 29, 2018 at 12:38:50PM -0600, Josh Poimboeuf wrote: > > On Tue, Jan 23, 2018 at 04:25:42PM +0100, Peter Zijlstra wrote: > > > Paravirt emits indirect calls which get flagged by objtool retpoline > > > checks, annotate it

Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

On Mon, Jan 29, 2018 at 08:21:08PM +0100, Peter Zijlstra wrote: > On Mon, Jan 29, 2018 at 12:38:50PM -0600, Josh Poimboeuf wrote: > > On Tue, Jan 23, 2018 at 04:25:42PM +0100, Peter Zijlstra wrote: > > > Paravirt emits indirect calls which get flagged by objtool retpoline > > > checks, annotate it

Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

On Mon, Jan 29, 2018 at 12:38:50PM -0600, Josh Poimboeuf wrote: > On Tue, Jan 23, 2018 at 04:25:42PM +0100, Peter Zijlstra wrote: > > Paravirt emits indirect calls which get flagged by objtool retpoline > > checks, annotate it away because all these indirect calls will be > > patched out before we

Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

On Mon, Jan 29, 2018 at 12:38:50PM -0600, Josh Poimboeuf wrote: > On Tue, Jan 23, 2018 at 04:25:42PM +0100, Peter Zijlstra wrote: > > Paravirt emits indirect calls which get flagged by objtool retpoline > > checks, annotate it away because all these indirect calls will be > > patched out before we

Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

On Tue, Jan 23, 2018 at 04:25:42PM +0100, Peter Zijlstra wrote: > Paravirt emits indirect calls which get flagged by objtool retpoline > checks, annotate it away because all these indirect calls will be > patched out before we start userspace. There's one condition where this isn't true: the

Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

On Tue, Jan 23, 2018 at 04:25:42PM +0100, Peter Zijlstra wrote: > Paravirt emits indirect calls which get flagged by objtool retpoline > checks, annotate it away because all these indirect calls will be > patched out before we start userspace. There's one condition where this isn't true: the

Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

On Mon, Jan 29, 2018 at 11:58:58AM -0600, Josh Poimboeuf wrote: > On Tue, Jan 23, 2018 at 04:25:42PM +0100, Peter Zijlstra wrote: > > Paravirt emits indirect calls which get flagged by objtool retpoline > > checks, annotate it away because all these indirect calls will be > > patched out before we

Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

On Mon, Jan 29, 2018 at 11:58:58AM -0600, Josh Poimboeuf wrote: > On Tue, Jan 23, 2018 at 04:25:42PM +0100, Peter Zijlstra wrote: > > Paravirt emits indirect calls which get flagged by objtool retpoline > > checks, annotate it away because all these indirect calls will be > > patched out before we

Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

On Mon, 2018-01-29 at 11:58 -0600, Josh Poimboeuf wrote: > On Tue, Jan 23, 2018 at 04:25:42PM +0100, Peter Zijlstra wrote: > > > > Paravirt emits indirect calls which get flagged by objtool > > retpoline > > checks, annotate it away because all these indirect calls will be > > patched out before

Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

On Mon, 2018-01-29 at 11:58 -0600, Josh Poimboeuf wrote: > On Tue, Jan 23, 2018 at 04:25:42PM +0100, Peter Zijlstra wrote: > > > > Paravirt emits indirect calls which get flagged by objtool > > retpoline > > checks, annotate it away because all these indirect calls will be > > patched out before

Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

On Tue, Jan 23, 2018 at 04:25:42PM +0100, Peter Zijlstra wrote: > Paravirt emits indirect calls which get flagged by objtool retpoline > checks, annotate it away because all these indirect calls will be > patched out before we start userspace. > > Signed-off-by: Peter Zijlstra (Intel)

Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

On Tue, Jan 23, 2018 at 04:25:42PM +0100, Peter Zijlstra wrote: > Paravirt emits indirect calls which get flagged by objtool retpoline > checks, annotate it away because all these indirect calls will be > patched out before we start userspace. > > Signed-off-by: Peter Zijlstra (Intel) > --- >

Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

On Thu, 2018-01-25 at 12:35 +0100, Peter Zijlstra wrote: > On Thu, Jan 25, 2018 at 10:52:53AM +, David Woodhouse wrote: > > > > OK, my brain hurts a bit but I'm happy now. Thank you. > OK, I've updated the Changelog thusly. Is this satisfactory? > > --- > Subject: x86/paravirt: Annotate

Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

On Thu, 2018-01-25 at 12:35 +0100, Peter Zijlstra wrote: > On Thu, Jan 25, 2018 at 10:52:53AM +, David Woodhouse wrote: > > > > OK, my brain hurts a bit but I'm happy now. Thank you. > OK, I've updated the Changelog thusly. Is this satisfactory? > > --- > Subject: x86/paravirt: Annotate

Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

On Thu, Jan 25, 2018 at 10:52:53AM +, David Woodhouse wrote: > OK, my brain hurts a bit but I'm happy now. Thank you. OK, I've updated the Changelog thusly. Is this satisfactory? --- Subject: x86/paravirt: Annotate indirect calls From: Peter Zijlstra Date: Wed Jan 17

Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

On Thu, Jan 25, 2018 at 10:52:53AM +, David Woodhouse wrote: > OK, my brain hurts a bit but I'm happy now. Thank you. OK, I've updated the Changelog thusly. Is this satisfactory? --- Subject: x86/paravirt: Annotate indirect calls From: Peter Zijlstra Date: Wed Jan 17 16:58:11 CET 2018

Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

On Thu, 2018-01-25 at 11:26 +0100, Juergen Gross wrote: > On 25/01/18 11:22, Peter Zijlstra wrote: > > > > On Thu, Jan 25, 2018 at 10:02:05AM +, David Woodhouse wrote: > > > > > > On Tue, 2018-01-23 at 16:25 +0100, Peter Zijlstra wrote: > > > > > > > > Paravirt emits indirect calls which

Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

On Thu, 2018-01-25 at 11:26 +0100, Juergen Gross wrote: > On 25/01/18 11:22, Peter Zijlstra wrote: > > > > On Thu, Jan 25, 2018 at 10:02:05AM +, David Woodhouse wrote: > > > > > > On Tue, 2018-01-23 at 16:25 +0100, Peter Zijlstra wrote: > > > > > > > > Paravirt emits indirect calls which

Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

On 25/01/18 11:22, Peter Zijlstra wrote: > On Thu, Jan 25, 2018 at 10:02:05AM +, David Woodhouse wrote: >> On Tue, 2018-01-23 at 16:25 +0100, Peter Zijlstra wrote: >>> Paravirt emits indirect calls which get flagged by objtool retpoline >>> checks, annotate it away because all these indirect

Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

On 25/01/18 11:22, Peter Zijlstra wrote: > On Thu, Jan 25, 2018 at 10:02:05AM +, David Woodhouse wrote: >> On Tue, 2018-01-23 at 16:25 +0100, Peter Zijlstra wrote: >>> Paravirt emits indirect calls which get flagged by objtool retpoline >>> checks, annotate it away because all these indirect

Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

On Thu, Jan 25, 2018 at 10:02:05AM +, David Woodhouse wrote: > On Tue, 2018-01-23 at 16:25 +0100, Peter Zijlstra wrote: > > Paravirt emits indirect calls which get flagged by objtool retpoline > > checks, annotate it away because all these indirect calls will be > > patched out before we start

Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

On Thu, Jan 25, 2018 at 10:02:05AM +, David Woodhouse wrote: > On Tue, 2018-01-23 at 16:25 +0100, Peter Zijlstra wrote: > > Paravirt emits indirect calls which get flagged by objtool retpoline > > checks, annotate it away because all these indirect calls will be > > patched out before we start

Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

On Tue, 2018-01-23 at 16:25 +0100, Peter Zijlstra wrote: > Paravirt emits indirect calls which get flagged by objtool retpoline > checks, annotate it away because all these indirect calls will be > patched out before we start userspace. I've seen this asserted repeatedly but I've never truly

Re: [PATCH 03/24] x86/paravirt: Annotate indirect calls

On Tue, 2018-01-23 at 16:25 +0100, Peter Zijlstra wrote: > Paravirt emits indirect calls which get flagged by objtool retpoline > checks, annotate it away because all these indirect calls will be > patched out before we start userspace. I've seen this asserted repeatedly but I've never truly

[PATCH 03/24] x86/paravirt: Annotate indirect calls

Paravirt emits indirect calls which get flagged by objtool retpoline checks, annotate it away because all these indirect calls will be patched out before we start userspace. Signed-off-by: Peter Zijlstra (Intel) --- arch/x86/include/asm/paravirt.h | 22

[PATCH 03/24] x86/paravirt: Annotate indirect calls

Paravirt emits indirect calls which get flagged by objtool retpoline checks, annotate it away because all these indirect calls will be patched out before we start userspace. Signed-off-by: Peter Zijlstra (Intel) --- arch/x86/include/asm/paravirt.h | 22 ++