Re: [PATCH 03/27] perf tools: Move arch check into config/Makefile

2013-04-01 Thread Jiri Olsa
On Tue, Apr 02, 2013 at 06:54:26AM +0900, Namhyung Kim wrote: > Hi, Jiri > > 2013-04-01 (월), 21:18 +0200, Jiri Olsa: > > Moving arch check into config/Makefile. > > [SNIP] > > > +ifeq ($(filter clean tags,$(MAKECMDGOALS)),) > > +include config/Makefile > > endif > > Problem with this approach

Re: [PATCH 03/27] perf tools: Move arch check into config/Makefile

2013-04-01 Thread Namhyung Kim
Hi, Jiri 2013-04-01 (월), 21:18 +0200, Jiri Olsa: > Moving arch check into config/Makefile. [SNIP] > +ifeq ($(filter clean tags,$(MAKECMDGOALS)),) > +include config/Makefile > endif Problem with this approach is that people (including me) sometimes give multiple targets in one go - like "make

Re: [PATCH 03/27] perf tools: Move arch check into config/Makefile

2013-04-01 Thread Jiri Olsa
On Mon, Apr 01, 2013 at 09:54:46PM +0200, Sam Ravnborg wrote: SNIP > > diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile > > new file mode 100644 > > index 000..fe317c2 > > --- /dev/null > > +++ b/tools/perf/config/Makefile > > @@ -0,0 +1,34 @@ > > +uname_M := $(shell

Re: [PATCH 03/27] perf tools: Move arch check into config/Makefile

2013-04-01 Thread Sam Ravnborg
On Mon, Apr 01, 2013 at 09:18:26PM +0200, Jiri Olsa wrote: > Moving arch check into config/Makefile. > > Signed-off-by: Jiri Olsa > Cc: Arnaldo Carvalho de Melo > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Paul Mackerras > Cc: Corey Ashford > Cc: Frederic Weisbecker > Cc: Namhyung Kim >

[PATCH 03/27] perf tools: Move arch check into config/Makefile

2013-04-01 Thread Jiri Olsa
Moving arch check into config/Makefile. Signed-off-by: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paul Mackerras Cc: Corey Ashford Cc: Frederic Weisbecker Cc: Namhyung Kim Cc: Borislav Petkov Cc: Stephane Eranian --- tools/perf/Makefile| 31

[PATCH 03/27] perf tools: Move arch check into config/Makefile

2013-04-01 Thread Jiri Olsa
Moving arch check into config/Makefile. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc:

Re: [PATCH 03/27] perf tools: Move arch check into config/Makefile

2013-04-01 Thread Sam Ravnborg
On Mon, Apr 01, 2013 at 09:18:26PM +0200, Jiri Olsa wrote: Moving arch check into config/Makefile. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras

Re: [PATCH 03/27] perf tools: Move arch check into config/Makefile

2013-04-01 Thread Jiri Olsa
On Mon, Apr 01, 2013 at 09:54:46PM +0200, Sam Ravnborg wrote: SNIP diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile new file mode 100644 index 000..fe317c2 --- /dev/null +++ b/tools/perf/config/Makefile @@ -0,0 +1,34 @@ +uname_M := $(shell uname -m

Re: [PATCH 03/27] perf tools: Move arch check into config/Makefile

2013-04-01 Thread Namhyung Kim
Hi, Jiri 2013-04-01 (월), 21:18 +0200, Jiri Olsa: Moving arch check into config/Makefile. [SNIP] +ifeq ($(filter clean tags,$(MAKECMDGOALS)),) +include config/Makefile endif Problem with this approach is that people (including me) sometimes give multiple targets in one go - like make clean

Re: [PATCH 03/27] perf tools: Move arch check into config/Makefile

2013-04-01 Thread Jiri Olsa
On Tue, Apr 02, 2013 at 06:54:26AM +0900, Namhyung Kim wrote: Hi, Jiri 2013-04-01 (월), 21:18 +0200, Jiri Olsa: Moving arch check into config/Makefile. [SNIP] +ifeq ($(filter clean tags,$(MAKECMDGOALS)),) +include config/Makefile endif Problem with this approach is that people