Re: [PATCH 03/34] perf, x86: Basic Haswell PEBS support v2

2012-10-23 Thread Andi Kleen
> Do things like the 0xd0 event really need all the UEVENT things spelled > out? There were some missing unit masks, so I spelled it out. > And 0x22d0 (LOCK_STORES) still appears missing going by the pattern > in there. Will double check. > Also, it looks like the 0xc5 things want to be

Re: [PATCH 03/34] perf, x86: Basic Haswell PEBS support v2

2012-10-23 Thread Peter Zijlstra
On Thu, 2012-10-18 at 16:19 -0700, Andi Kleen wrote: > +struct event_constraint intel_hsw_pebs_event_constraints[] = { > + INTEL_UEVENT_CONSTRAINT(0x01c0, 0x2), /* INST_RETIRED.PRECDIST */ > + INTEL_UEVENT_CONSTRAINT(0x01c2, 0xf), /* UOPS_RETIRED.ALL */ > +

Re: [PATCH 03/34] perf, x86: Basic Haswell PEBS support v2

2012-10-23 Thread Peter Zijlstra
On Thu, 2012-10-18 at 16:19 -0700, Andi Kleen wrote: +struct event_constraint intel_hsw_pebs_event_constraints[] = { + INTEL_UEVENT_CONSTRAINT(0x01c0, 0x2), /* INST_RETIRED.PRECDIST */ + INTEL_UEVENT_CONSTRAINT(0x01c2, 0xf), /* UOPS_RETIRED.ALL */ +

Re: [PATCH 03/34] perf, x86: Basic Haswell PEBS support v2

2012-10-23 Thread Andi Kleen
Do things like the 0xd0 event really need all the UEVENT things spelled out? There were some missing unit masks, so I spelled it out. And 0x22d0 (LOCK_STORES) still appears missing going by the pattern in there. Will double check. Also, it looks like the 0xc5 things want to be UEVENT,

[PATCH 03/34] perf, x86: Basic Haswell PEBS support v2

2012-10-18 Thread Andi Kleen
From: Andi Kleen Add basic PEBS support for Haswell. The constraints are similar to SandyBridge with a few new events. v2: Readd missing pebs_aliases Signed-off-by: Andi Kleen --- arch/x86/kernel/cpu/perf_event.h |2 ++ arch/x86/kernel/cpu/perf_event_intel.c|3 ++-

[PATCH 03/34] perf, x86: Basic Haswell PEBS support v2

2012-10-18 Thread Andi Kleen
From: Andi Kleen a...@linux.intel.com Add basic PEBS support for Haswell. The constraints are similar to SandyBridge with a few new events. v2: Readd missing pebs_aliases Signed-off-by: Andi Kleen a...@linux.intel.com --- arch/x86/kernel/cpu/perf_event.h |2 ++