On Fri, Mar 27, 2015 at 06:23:18AM +0100, Sascha Hauer wrote:
> Hi Amit,
>
> On Fri, Mar 27, 2015 at 08:35:50AM +0530, amit daniel kachhap wrote:
> > Hi Sascha,
> >
> > > -#ifdef CONFIG_THERMAL_EMULATION
> > > - if (!tz->emul_temperature)
> > > - goto skip_emul;
> > > -
> > >
On Fri, Mar 27, 2015 at 06:23:18AM +0100, Sascha Hauer wrote:
Hi Amit,
On Fri, Mar 27, 2015 at 08:35:50AM +0530, amit daniel kachhap wrote:
Hi Sascha,
-#ifdef CONFIG_THERMAL_EMULATION
- if (!tz-emul_temperature)
- goto skip_emul;
-
- for (count =
Hi Amit,
On Fri, Mar 27, 2015 at 08:35:50AM +0530, amit daniel kachhap wrote:
> Hi Sascha,
>
> > -#ifdef CONFIG_THERMAL_EMULATION
> > - if (!tz->emul_temperature)
> > - goto skip_emul;
> > -
> > - for (count = 0; count < tz->trips; count++) {
> > - ret =
Hi Sascha,
On Thu, Mar 26, 2015 at 9:23 PM, Sascha Hauer wrote:
> commit e6e238c38 (thermal: sysfs: Add a new sysfs node emul_temp for
> thermal emulation) promised not to emulate critical temperatures,
> but the check for critical temperatures is broken in multiple ways:
>
> - The code should
+Cc Amit who implemented the emulation code.
On Thu, Mar 26, 2015 at 02:13:47PM -0400, Carlos Hernandez wrote:
> On 03/26/2015 11:53 AM, Sascha Hauer wrote:
> >- The code should only accept an emulated temperature when the emulated
> > temperature is lower than the critical temperature. Instead
On 03/26/2015 11:53 AM, Sascha Hauer wrote:
- The code should only accept an emulated temperature when the emulated
temperature is lower than the critical temperature. Instead the code
Why?
Emulating temperatures higher than critical temperature is useful for
testing. For instance it
commit e6e238c38 (thermal: sysfs: Add a new sysfs node emul_temp for
thermal emulation) promised not to emulate critical temperatures,
but the check for critical temperatures is broken in multiple ways:
- The code should only accept an emulated temperature when the emulated
temperature is
Hi Amit,
On Fri, Mar 27, 2015 at 08:35:50AM +0530, amit daniel kachhap wrote:
Hi Sascha,
-#ifdef CONFIG_THERMAL_EMULATION
- if (!tz-emul_temperature)
- goto skip_emul;
-
- for (count = 0; count tz-trips; count++) {
- ret =
Hi Sascha,
On Thu, Mar 26, 2015 at 9:23 PM, Sascha Hauer s.ha...@pengutronix.de wrote:
commit e6e238c38 (thermal: sysfs: Add a new sysfs node emul_temp for
thermal emulation) promised not to emulate critical temperatures,
but the check for critical temperatures is broken in multiple ways:
-
On 03/26/2015 11:53 AM, Sascha Hauer wrote:
- The code should only accept an emulated temperature when the emulated
temperature is lower than the critical temperature. Instead the code
Why?
Emulating temperatures higher than critical temperature is useful for
testing. For instance it
+Cc Amit who implemented the emulation code.
On Thu, Mar 26, 2015 at 02:13:47PM -0400, Carlos Hernandez wrote:
On 03/26/2015 11:53 AM, Sascha Hauer wrote:
- The code should only accept an emulated temperature when the emulated
temperature is lower than the critical temperature. Instead the
commit e6e238c38 (thermal: sysfs: Add a new sysfs node emul_temp for
thermal emulation) promised not to emulate critical temperatures,
but the check for critical temperatures is broken in multiple ways:
- The code should only accept an emulated temperature when the emulated
temperature is
12 matches
Mail list logo