Re: [PATCH 04/13] thermal: Fix not emulating critical temperatures

2015-04-06 Thread Eduardo Valentin
On Fri, Mar 27, 2015 at 06:23:18AM +0100, Sascha Hauer wrote: > Hi Amit, > > On Fri, Mar 27, 2015 at 08:35:50AM +0530, amit daniel kachhap wrote: > > Hi Sascha, > > > > > -#ifdef CONFIG_THERMAL_EMULATION > > > - if (!tz->emul_temperature) > > > - goto skip_emul; > > > - > > >

Re: [PATCH 04/13] thermal: Fix not emulating critical temperatures

2015-04-06 Thread Eduardo Valentin
On Fri, Mar 27, 2015 at 06:23:18AM +0100, Sascha Hauer wrote: Hi Amit, On Fri, Mar 27, 2015 at 08:35:50AM +0530, amit daniel kachhap wrote: Hi Sascha, -#ifdef CONFIG_THERMAL_EMULATION - if (!tz-emul_temperature) - goto skip_emul; - - for (count =

Re: [PATCH 04/13] thermal: Fix not emulating critical temperatures

2015-03-26 Thread Sascha Hauer
Hi Amit, On Fri, Mar 27, 2015 at 08:35:50AM +0530, amit daniel kachhap wrote: > Hi Sascha, > > > -#ifdef CONFIG_THERMAL_EMULATION > > - if (!tz->emul_temperature) > > - goto skip_emul; > > - > > - for (count = 0; count < tz->trips; count++) { > > - ret =

Re: [PATCH 04/13] thermal: Fix not emulating critical temperatures

2015-03-26 Thread amit daniel kachhap
Hi Sascha, On Thu, Mar 26, 2015 at 9:23 PM, Sascha Hauer wrote: > commit e6e238c38 (thermal: sysfs: Add a new sysfs node emul_temp for > thermal emulation) promised not to emulate critical temperatures, > but the check for critical temperatures is broken in multiple ways: > > - The code should

Re: [PATCH 04/13] thermal: Fix not emulating critical temperatures

2015-03-26 Thread Sascha Hauer
+Cc Amit who implemented the emulation code. On Thu, Mar 26, 2015 at 02:13:47PM -0400, Carlos Hernandez wrote: > On 03/26/2015 11:53 AM, Sascha Hauer wrote: > >- The code should only accept an emulated temperature when the emulated > > temperature is lower than the critical temperature. Instead

Re: [PATCH 04/13] thermal: Fix not emulating critical temperatures

2015-03-26 Thread Carlos Hernandez
On 03/26/2015 11:53 AM, Sascha Hauer wrote: - The code should only accept an emulated temperature when the emulated temperature is lower than the critical temperature. Instead the code Why? Emulating temperatures higher than critical temperature is useful for testing. For instance it

[PATCH 04/13] thermal: Fix not emulating critical temperatures

2015-03-26 Thread Sascha Hauer
commit e6e238c38 (thermal: sysfs: Add a new sysfs node emul_temp for thermal emulation) promised not to emulate critical temperatures, but the check for critical temperatures is broken in multiple ways: - The code should only accept an emulated temperature when the emulated temperature is

Re: [PATCH 04/13] thermal: Fix not emulating critical temperatures

2015-03-26 Thread Sascha Hauer
Hi Amit, On Fri, Mar 27, 2015 at 08:35:50AM +0530, amit daniel kachhap wrote: Hi Sascha, -#ifdef CONFIG_THERMAL_EMULATION - if (!tz-emul_temperature) - goto skip_emul; - - for (count = 0; count tz-trips; count++) { - ret =

Re: [PATCH 04/13] thermal: Fix not emulating critical temperatures

2015-03-26 Thread amit daniel kachhap
Hi Sascha, On Thu, Mar 26, 2015 at 9:23 PM, Sascha Hauer s.ha...@pengutronix.de wrote: commit e6e238c38 (thermal: sysfs: Add a new sysfs node emul_temp for thermal emulation) promised not to emulate critical temperatures, but the check for critical temperatures is broken in multiple ways: -

Re: [PATCH 04/13] thermal: Fix not emulating critical temperatures

2015-03-26 Thread Carlos Hernandez
On 03/26/2015 11:53 AM, Sascha Hauer wrote: - The code should only accept an emulated temperature when the emulated temperature is lower than the critical temperature. Instead the code Why? Emulating temperatures higher than critical temperature is useful for testing. For instance it

Re: [PATCH 04/13] thermal: Fix not emulating critical temperatures

2015-03-26 Thread Sascha Hauer
+Cc Amit who implemented the emulation code. On Thu, Mar 26, 2015 at 02:13:47PM -0400, Carlos Hernandez wrote: On 03/26/2015 11:53 AM, Sascha Hauer wrote: - The code should only accept an emulated temperature when the emulated temperature is lower than the critical temperature. Instead the

[PATCH 04/13] thermal: Fix not emulating critical temperatures

2015-03-26 Thread Sascha Hauer
commit e6e238c38 (thermal: sysfs: Add a new sysfs node emul_temp for thermal emulation) promised not to emulate critical temperatures, but the check for critical temperatures is broken in multiple ways: - The code should only accept an emulated temperature when the emulated temperature is