Re: [PATCH 04/17] perf data: Fail check_backup in case of error

2019-02-22 Thread Jiri Olsa
On Thu, Feb 21, 2019 at 02:23:30PM -0800, Andi Kleen wrote: > On Thu, Feb 21, 2019 at 10:41:32AM +0100, Jiri Olsa wrote: > > And display the error message from removing > > the old data file: > > > > $ perf record ls > > Can't remove old data: Permission denied (perf.data.old) > > Perf

Re: [PATCH 04/17] perf data: Fail check_backup in case of error

2019-02-21 Thread Andi Kleen
On Thu, Feb 21, 2019 at 10:41:32AM +0100, Jiri Olsa wrote: > And display the error message from removing > the old data file: > > $ perf record ls > Can't remove old data: Permission denied (perf.data.old) > Perf session creation failed. > > Not sure how to make fail the rename (after we

[PATCH 04/17] perf data: Fail check_backup in case of error

2019-02-21 Thread Jiri Olsa
And display the error message from removing the old data file: $ perf record ls Can't remove old data: Permission denied (perf.data.old) Perf session creation failed. Not sure how to make fail the rename (after we successfully remove the destination file/dir) to show the message, anyway