Re: [PATCH 05/10] mm, compaction: remember position within pageblock in free pages scanner

2014-06-11 Thread Vlastimil Babka
On 06/11/2014 10:16 AM, Joonsoo Kim wrote: On Wed, Jun 11, 2014 at 11:12:13AM +0900, Minchan Kim wrote: On Mon, Jun 09, 2014 at 11:26:17AM +0200, Vlastimil Babka wrote: Unlike the migration scanner, the free scanner remembers the beginning of the last scanned pageblock in cc->free_pfn. It might

Re: [PATCH 05/10] mm, compaction: remember position within pageblock in free pages scanner

2014-06-11 Thread Vlastimil Babka
On 06/11/2014 04:12 AM, Minchan Kim wrote: >@@ -314,6 +315,9 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, >int isolated, i; >struct page *page = cursor; > >+ /* Record how far we have got within the block */ >+ *start_pfn

Re: [PATCH 05/10] mm, compaction: remember position within pageblock in free pages scanner

2014-06-11 Thread Joonsoo Kim
On Wed, Jun 11, 2014 at 11:12:13AM +0900, Minchan Kim wrote: > On Mon, Jun 09, 2014 at 11:26:17AM +0200, Vlastimil Babka wrote: > > Unlike the migration scanner, the free scanner remembers the beginning of > > the > > last scanned pageblock in cc->free_pfn. It might be therefore rescanning > > pa

Re: [PATCH 05/10] mm, compaction: remember position within pageblock in free pages scanner

2014-06-10 Thread Zhang Yanfei
On 06/09/2014 05:26 PM, Vlastimil Babka wrote: > Unlike the migration scanner, the free scanner remembers the beginning of the > last scanned pageblock in cc->free_pfn. It might be therefore rescanning pages > uselessly when called several times during single compaction. This might have > been usef

Re: [PATCH 05/10] mm, compaction: remember position within pageblock in free pages scanner

2014-06-10 Thread Minchan Kim
On Mon, Jun 09, 2014 at 11:26:17AM +0200, Vlastimil Babka wrote: > Unlike the migration scanner, the free scanner remembers the beginning of the > last scanned pageblock in cc->free_pfn. It might be therefore rescanning pages > uselessly when called several times during single compaction. This migh

Re: [PATCH 05/10] mm, compaction: remember position within pageblock in free pages scanner

2014-06-09 Thread David Rientjes
On Mon, 9 Jun 2014, Vlastimil Babka wrote: > Unlike the migration scanner, the free scanner remembers the beginning of the > last scanned pageblock in cc->free_pfn. It might be therefore rescanning pages > uselessly when called several times during single compaction. This might have > been useful

[PATCH 05/10] mm, compaction: remember position within pageblock in free pages scanner

2014-06-09 Thread Vlastimil Babka
Unlike the migration scanner, the free scanner remembers the beginning of the last scanned pageblock in cc->free_pfn. It might be therefore rescanning pages uselessly when called several times during single compaction. This might have been useful when pages were returned to the buddy allocator afte