Re: [PATCH 05/11] staging: gasket: page_table: rearrange gasket_page_table_entry

2018-10-15 Thread Greg Kroah-Hartman 
On Sun, Oct 14, 2018 at 09:59:21PM -0700, Todd Poynor wrote:
> From: Nick Ewalt 
> 
> Rearrange gasket_page_table entry to reduce padding slop.

In the future, defining exactly what "slop" is here would be nice :)

thanks,

greg k-h

Re: [PATCH 05/11] staging: gasket: page_table: rearrange gasket_page_table_entry

2018-10-15 Thread Greg Kroah-Hartman 
On Sun, Oct 14, 2018 at 09:59:21PM -0700, Todd Poynor wrote:
> From: Nick Ewalt 
> 
> Rearrange gasket_page_table entry to reduce padding slop.

In the future, defining exactly what "slop" is here would be nice :)

thanks,

greg k-h

[PATCH 05/11] staging: gasket: page_table: rearrange gasket_page_table_entry

2018-10-14 Thread Todd Poynor 
From: Nick Ewalt 

Rearrange gasket_page_table entry to reduce padding slop.

Signed-off-by: Nick Ewalt 
Signed-off-by: Todd Poynor 
---
 drivers/staging/gasket/gasket_page_table.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/gasket/gasket_page_table.c 
b/drivers/staging/gasket/gasket_page_table.c
index d2e115d2dba30..9c2f8671216b5 100644
--- a/drivers/staging/gasket/gasket_page_table.c
+++ b/drivers/staging/gasket/gasket_page_table.c
@@ -103,12 +103,6 @@ struct gasket_page_table_entry {
/* The status of this entry/slot: free or in use. */
enum pte_status status;
 
-   /* Address of the page in DMA space. */
-   dma_addr_t dma_addr;
-
-   /* Linux page descriptor for the page described by this structure. */
-   struct page *page;
-
/*
 * Index for alignment into host vaddrs.
 * When a user specifies a host address for a mapping, that address may
@@ -119,6 +113,12 @@ struct gasket_page_table_entry {
 */
int offset;
 
+   /* Address of the page in DMA space. */
+   dma_addr_t dma_addr;
+
+   /* Linux page descriptor for the page described by this structure. */
+   struct page *page;
+
/*
 * If this is an extended and first-level entry, sublevel points
 * to the second-level entries underneath this entry.
-- 
2.19.0.605.g01d371f741-goog

[PATCH 05/11] staging: gasket: page_table: rearrange gasket_page_table_entry

2018-10-14 Thread Todd Poynor 
From: Nick Ewalt 

Rearrange gasket_page_table entry to reduce padding slop.

Signed-off-by: Nick Ewalt 
Signed-off-by: Todd Poynor 
---
 drivers/staging/gasket/gasket_page_table.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/gasket/gasket_page_table.c 
b/drivers/staging/gasket/gasket_page_table.c
index d2e115d2dba30..9c2f8671216b5 100644
--- a/drivers/staging/gasket/gasket_page_table.c
+++ b/drivers/staging/gasket/gasket_page_table.c
@@ -103,12 +103,6 @@ struct gasket_page_table_entry {
/* The status of this entry/slot: free or in use. */
enum pte_status status;
 
-   /* Address of the page in DMA space. */
-   dma_addr_t dma_addr;
-
-   /* Linux page descriptor for the page described by this structure. */
-   struct page *page;
-
/*
 * Index for alignment into host vaddrs.
 * When a user specifies a host address for a mapping, that address may
@@ -119,6 +113,12 @@ struct gasket_page_table_entry {
 */
int offset;
 
+   /* Address of the page in DMA space. */
+   dma_addr_t dma_addr;
+
+   /* Linux page descriptor for the page described by this structure. */
+   struct page *page;
+
/*
 * If this is an extended and first-level entry, sublevel points
 * to the second-level entries underneath this entry.
-- 
2.19.0.605.g01d371f741-goog