Re: [PATCH 05/11] touchscreen: elants: Use octal permissions

2018-07-23 Thread Harshit Jain
I ran a treewide script and changed them all to octal and built a kernel which i am currently running on my machine, I have used DEVICE_ATTR_RO() for 0444's where possible if i dont find any regressions I will post a patch for review. I think i will be testing it at least for a week. On Tue, Jul

Re: [PATCH 05/11] touchscreen: elants: Use octal permissions

2018-07-23 Thread Harshit Jain
I ran a treewide script and changed them all to octal and built a kernel which i am currently running on my machine, I have used DEVICE_ATTR_RO() for 0444's where possible if i dont find any regressions I will post a patch for review. I think i will be testing it at least for a week. On Tue, Jul

Re: [PATCH 05/11] touchscreen: elants: Use octal permissions

2018-07-23 Thread Joe Perches
On Mon, 2018-07-23 at 11:24 -0700, Guenter Roeck wrote: > There are much more urgent issues to fix there (such as, for example, > converting the "offending" drivers to the latest API, which would > magically cause most of the offenders to disappear). Perhaps posting a list of desired hwmon

Re: [PATCH 05/11] touchscreen: elants: Use octal permissions

2018-07-23 Thread Joe Perches
On Mon, 2018-07-23 at 11:24 -0700, Guenter Roeck wrote: > There are much more urgent issues to fix there (such as, for example, > converting the "offending" drivers to the latest API, which would > magically cause most of the offenders to disappear). Perhaps posting a list of desired hwmon

Re: [PATCH 05/11] touchscreen: elants: Use octal permissions

2018-07-23 Thread Guenter Roeck
On Mon, Jul 23, 2018 at 10:25:10AM -0700, Joe Perches wrote: > On Mon, 2018-07-23 at 10:18 -0700, Dmitry Torokhov wrote: > > On Mon, Jul 23, 2018 at 03:32:00PM +0200, Greg Kroah-Hartman wrote: > > > On Mon, Jul 23, 2018 at 06:49:20PM +0530, dev-harsh1998 wrote: > > > > WARNING: Symbolic

Re: [PATCH 05/11] touchscreen: elants: Use octal permissions

2018-07-23 Thread Guenter Roeck
On Mon, Jul 23, 2018 at 10:25:10AM -0700, Joe Perches wrote: > On Mon, 2018-07-23 at 10:18 -0700, Dmitry Torokhov wrote: > > On Mon, Jul 23, 2018 at 03:32:00PM +0200, Greg Kroah-Hartman wrote: > > > On Mon, Jul 23, 2018 at 06:49:20PM +0530, dev-harsh1998 wrote: > > > > WARNING: Symbolic

Re: [PATCH 05/11] touchscreen: elants: Use octal permissions

2018-07-23 Thread Dmitry Torokhov
On Mon, Jul 23, 2018 at 10:25:10AM -0700, Joe Perches wrote: > On Mon, 2018-07-23 at 10:18 -0700, Dmitry Torokhov wrote: > > On Mon, Jul 23, 2018 at 03:32:00PM +0200, Greg Kroah-Hartman wrote: > > > On Mon, Jul 23, 2018 at 06:49:20PM +0530, dev-harsh1998 wrote: > > > > WARNING: Symbolic

Re: [PATCH 05/11] touchscreen: elants: Use octal permissions

2018-07-23 Thread Dmitry Torokhov
On Mon, Jul 23, 2018 at 10:25:10AM -0700, Joe Perches wrote: > On Mon, 2018-07-23 at 10:18 -0700, Dmitry Torokhov wrote: > > On Mon, Jul 23, 2018 at 03:32:00PM +0200, Greg Kroah-Hartman wrote: > > > On Mon, Jul 23, 2018 at 06:49:20PM +0530, dev-harsh1998 wrote: > > > > WARNING: Symbolic

Re: [PATCH 05/11] touchscreen: elants: Use octal permissions

2018-07-23 Thread Joe Perches
On Mon, 2018-07-23 at 10:18 -0700, Dmitry Torokhov wrote: > On Mon, Jul 23, 2018 at 03:32:00PM +0200, Greg Kroah-Hartman wrote: > > On Mon, Jul 23, 2018 at 06:49:20PM +0530, dev-harsh1998 wrote: > > > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using > > > octal

Re: [PATCH 05/11] touchscreen: elants: Use octal permissions

2018-07-23 Thread Joe Perches
On Mon, 2018-07-23 at 10:18 -0700, Dmitry Torokhov wrote: > On Mon, Jul 23, 2018 at 03:32:00PM +0200, Greg Kroah-Hartman wrote: > > On Mon, Jul 23, 2018 at 06:49:20PM +0530, dev-harsh1998 wrote: > > > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using > > > octal

Re: [PATCH 05/11] touchscreen: elants: Use octal permissions

2018-07-23 Thread Dmitry Torokhov
On Mon, Jul 23, 2018 at 03:32:00PM +0200, Greg Kroah-Hartman wrote: > On Mon, Jul 23, 2018 at 06:49:20PM +0530, dev-harsh1998 wrote: > > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using > > octal permissions '0444'. > > +static DEVICE_ATTR(iap_mode, S_IRUGO,

Re: [PATCH 05/11] touchscreen: elants: Use octal permissions

2018-07-23 Thread Dmitry Torokhov
On Mon, Jul 23, 2018 at 03:32:00PM +0200, Greg Kroah-Hartman wrote: > On Mon, Jul 23, 2018 at 06:49:20PM +0530, dev-harsh1998 wrote: > > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using > > octal permissions '0444'. > > +static DEVICE_ATTR(iap_mode, S_IRUGO,

Re: [PATCH 05/11] touchscreen: elants: Use octal permissions

2018-07-23 Thread Greg Kroah-Hartman
On Mon, Jul 23, 2018 at 06:49:20PM +0530, dev-harsh1998 wrote: > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using > octal permissions '0444'. > +static DEVICE_ATTR(iap_mode, S_IRUGO, show_iap_mode, NULL); > > WARNING: Symbolic permissions 'S_IWUSR' are not preferred.

Re: [PATCH 05/11] touchscreen: elants: Use octal permissions

2018-07-23 Thread Greg Kroah-Hartman
On Mon, Jul 23, 2018 at 06:49:20PM +0530, dev-harsh1998 wrote: > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using > octal permissions '0444'. > +static DEVICE_ATTR(iap_mode, S_IRUGO, show_iap_mode, NULL); > > WARNING: Symbolic permissions 'S_IWUSR' are not preferred.

[PATCH 05/11] touchscreen: elants: Use octal permissions

2018-07-23 Thread dev-harsh1998
WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(iap_mode, S_IRUGO, show_iap_mode, NULL); WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'. +static DEVICE_ATTR(update_fw,

[PATCH 05/11] touchscreen: elants: Use octal permissions

2018-07-23 Thread dev-harsh1998
WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(iap_mode, S_IRUGO, show_iap_mode, NULL); WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'. +static DEVICE_ATTR(update_fw,

Re: [PATCH 05/11] touchscreen: elants: Use octal permissions

2018-07-22 Thread Greg Kroah-Hartman
On Sun, Jul 22, 2018 at 12:39:45AM +0530, dev-harsh1998 wrote: > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using > octal permissions '0444'. > +static DEVICE_ATTR(iap_mode, S_IRUGO, show_iap_mode, NULL); > > WARNING: Symbolic permissions 'S_IWUSR' are not preferred.

Re: [PATCH 05/11] touchscreen: elants: Use octal permissions

2018-07-22 Thread Greg Kroah-Hartman
On Sun, Jul 22, 2018 at 12:39:45AM +0530, dev-harsh1998 wrote: > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using > octal permissions '0444'. > +static DEVICE_ATTR(iap_mode, S_IRUGO, show_iap_mode, NULL); > > WARNING: Symbolic permissions 'S_IWUSR' are not preferred.

[PATCH 05/11] touchscreen: elants: Use octal permissions

2018-07-21 Thread dev-harsh1998
WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(iap_mode, S_IRUGO, show_iap_mode, NULL); WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'. +static DEVICE_ATTR(update_fw,

[PATCH 05/11] touchscreen: elants: Use octal permissions

2018-07-21 Thread dev-harsh1998
WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(iap_mode, S_IRUGO, show_iap_mode, NULL); WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'. +static DEVICE_ATTR(update_fw,