Re: [PATCH 05/13] cpufreq: e_powersave: call CPUFREQ_POSTCHANGE notfier in error cases

2013-06-19 Thread Dave Jones
On Wed, Jun 19, 2013 at 08:24:41PM +0530, Viresh Kumar wrote: > On 19 June 2013 17:52, Simon Horman wrote: > > I have no objections to this change but at the same time I don't > > feel that I know the code well enough to review it. > > Probably I made a mistake adding your name. Don't know h

Re: [PATCH 05/13] cpufreq: e_powersave: call CPUFREQ_POSTCHANGE notfier in error cases

2013-06-19 Thread Viresh Kumar
On 19 June 2013 17:52, Simon Horman wrote: > I have no objections to this change but at the same time I don't > feel that I know the code well enough to review it. Probably I made a mistake adding your name. Don't know how I made up my mind that you are the main contributor for this. Probably Da

Re: [PATCH 05/13] cpufreq: e_powersave: call CPUFREQ_POSTCHANGE notfier in error cases

2013-06-19 Thread Simon Horman
On Wed, Jun 19, 2013 at 02:22:59PM +0530, Viresh Kumar wrote: > PRECHANGE and POSTCHANGE notifiers must be called in groups, i.e either both > should be called or both shouldn't be. > > In case we have started PRECHANGE notifier and found an error, we must call > POSTCHANGE notifier with freqs.new

[PATCH 05/13] cpufreq: e_powersave: call CPUFREQ_POSTCHANGE notfier in error cases

2013-06-19 Thread Viresh Kumar
PRECHANGE and POSTCHANGE notifiers must be called in groups, i.e either both should be called or both shouldn't be. In case we have started PRECHANGE notifier and found an error, we must call POSTCHANGE notifier with freqs.new = freqs.old to guarantee that sequence of calling notifiers is complete