Re: [PATCH 05/18] mm: memcontrol: convert page cache to a new mem_cgroup_charge() API

2020-05-11 Thread Hugh Dickins
On Mon, 11 May 2020, Johannes Weiner wrote: > > Since commit b56a2d8af914 ("mm: rid swapoff of quadratic complexity"), > shmem_unuse_inode() doesn't have its own copy anymore - it uses > shmem_swapin_page(). > > However, that commit appears to have made shmem's private call to >

Re: [PATCH 05/18] mm: memcontrol: convert page cache to a new mem_cgroup_charge() API

2020-05-11 Thread Johannes Weiner
On Mon, May 11, 2020 at 02:10:58PM -0400, Johannes Weiner wrote: > From fc9dcaf68c8b54baf365cd670fb5780c7f0d243f Mon Sep 17 00:00:00 2001 > From: Johannes Weiner > Date: Mon, 11 May 2020 12:59:08 -0400 > Subject: [PATCH] mm: shmem: remove rare optimization when swapin races with > hole punching

Re: [PATCH 05/18] mm: memcontrol: convert page cache to a new mem_cgroup_charge() API

2020-05-11 Thread Johannes Weiner
On Mon, May 11, 2020 at 09:32:16AM -0700, Hugh Dickins wrote: > On Mon, 11 May 2020, Johannes Weiner wrote: > > On Mon, May 11, 2020 at 12:38:04AM -0700, Hugh Dickins wrote: > > > On Fri, 8 May 2020, Johannes Weiner wrote: > > > > > > > > I looked at this some more, as well as compared it to

Re: [PATCH 05/18] mm: memcontrol: convert page cache to a new mem_cgroup_charge() API

2020-05-11 Thread Hugh Dickins
On Mon, 11 May 2020, Johannes Weiner wrote: > On Mon, May 11, 2020 at 12:38:04AM -0700, Hugh Dickins wrote: > > On Fri, 8 May 2020, Johannes Weiner wrote: > > > > > > I looked at this some more, as well as compared it to non-shmem > > > swapping. My conclusion is - and Hugh may correct me on this

Re: [PATCH 05/18] mm: memcontrol: convert page cache to a new mem_cgroup_charge() API

2020-05-11 Thread Johannes Weiner
On Mon, May 11, 2020 at 12:38:04AM -0700, Hugh Dickins wrote: > On Fri, 8 May 2020, Johannes Weiner wrote: > > > > I looked at this some more, as well as compared it to non-shmem > > swapping. My conclusion is - and Hugh may correct me on this - that > > the deletion looks mandatory but is

Re: [PATCH 05/18] mm: memcontrol: convert page cache to a new mem_cgroup_charge() API

2020-05-11 Thread Hugh Dickins
On Fri, 8 May 2020, Johannes Weiner wrote: > > I looked at this some more, as well as compared it to non-shmem > swapping. My conclusion is - and Hugh may correct me on this - that > the deletion looks mandatory but is actually an optimization. Page > reclaim will ultimately pick these pages up.

Re: [PATCH 05/18] mm: memcontrol: convert page cache to a new mem_cgroup_charge() API

2020-05-10 Thread Joonsoo Kim
On Fri, May 08, 2020 at 12:01:22PM -0400, Johannes Weiner wrote: > On Thu, Apr 23, 2020 at 02:25:06PM +0900, Joonsoo Kim wrote: > > On Wed, Apr 22, 2020 at 08:09:46AM -0400, Johannes Weiner wrote: > > > On Wed, Apr 22, 2020 at 03:40:41PM +0900, Joonsoo Kim wrote: > > > > On Mon, Apr 20, 2020 at

Re: [PATCH 05/18] mm: memcontrol: convert page cache to a new mem_cgroup_charge() API

2020-05-08 Thread Johannes Weiner
On Thu, Apr 23, 2020 at 02:25:06PM +0900, Joonsoo Kim wrote: > On Wed, Apr 22, 2020 at 08:09:46AM -0400, Johannes Weiner wrote: > > On Wed, Apr 22, 2020 at 03:40:41PM +0900, Joonsoo Kim wrote: > > > On Mon, Apr 20, 2020 at 06:11:13PM -0400, Johannes Weiner wrote: > > > > @@ -1664,29 +1678,22 @@