Re: [PATCH 05/18] perf tools: Add ordered_events_(get|put) interface

2014-06-30 Thread Arnaldo Carvalho de Melo
Em Sun, Jun 29, 2014 at 06:39:33PM +0200, Jiri Olsa escreveu: > On Fri, Jun 27, 2014 at 05:06:36PM -0600, David Ahern wrote: > > On 6/18/14, 8:58 AM, Jiri Olsa wrote: > > >+static struct ordered_event* > > >+ordered_events_get(struct ordered_events_queue *q, u64 timestamp) Also I don't think that

Re: [PATCH 05/18] perf tools: Add ordered_events_(get|put) interface

2014-06-30 Thread Arnaldo Carvalho de Melo
Em Sun, Jun 29, 2014 at 10:50:24AM -0600, David Ahern escreveu: > On 6/29/14, 10:39 AM, Jiri Olsa wrote: > >On Fri, Jun 27, 2014 at 05:06:36PM -0600, David Ahern wrote: > >>On 6/18/14, 8:58 AM, Jiri Olsa wrote: > >>>+static struct ordered_event* > >>>+ordered_events_get(struct ordered_events_queue

Re: [PATCH 05/18] perf tools: Add ordered_events_(get|put) interface

2014-06-30 Thread Arnaldo Carvalho de Melo
Em Sun, Jun 29, 2014 at 10:50:24AM -0600, David Ahern escreveu: On 6/29/14, 10:39 AM, Jiri Olsa wrote: On Fri, Jun 27, 2014 at 05:06:36PM -0600, David Ahern wrote: On 6/18/14, 8:58 AM, Jiri Olsa wrote: +static struct ordered_event* +ordered_events_get(struct ordered_events_queue *q, u64

Re: [PATCH 05/18] perf tools: Add ordered_events_(get|put) interface

2014-06-30 Thread Arnaldo Carvalho de Melo
Em Sun, Jun 29, 2014 at 06:39:33PM +0200, Jiri Olsa escreveu: On Fri, Jun 27, 2014 at 05:06:36PM -0600, David Ahern wrote: On 6/18/14, 8:58 AM, Jiri Olsa wrote: +static struct ordered_event* +ordered_events_get(struct ordered_events_queue *q, u64 timestamp) Also I don't think that it

Re: [PATCH 05/18] perf tools: Add ordered_events_(get|put) interface

2014-06-29 Thread David Ahern
On 6/29/14, 10:39 AM, Jiri Olsa wrote: On Fri, Jun 27, 2014 at 05:06:36PM -0600, David Ahern wrote: On 6/18/14, 8:58 AM, Jiri Olsa wrote: +static struct ordered_event* +ordered_events_get(struct ordered_events_queue *q, u64 timestamp) +{ + struct ordered_event *new; + + new =

Re: [PATCH 05/18] perf tools: Add ordered_events_(get|put) interface

2014-06-29 Thread Jiri Olsa
On Fri, Jun 27, 2014 at 05:06:36PM -0600, David Ahern wrote: > On 6/18/14, 8:58 AM, Jiri Olsa wrote: > > > >+static struct ordered_event* > >+ordered_events_get(struct ordered_events_queue *q, u64 timestamp) > >+{ > >+struct ordered_event *new; > >+ > >+new = alloc_event(q); > >+if

Re: [PATCH 05/18] perf tools: Add ordered_events_(get|put) interface

2014-06-29 Thread Jiri Olsa
On Fri, Jun 27, 2014 at 05:06:36PM -0600, David Ahern wrote: On 6/18/14, 8:58 AM, Jiri Olsa wrote: +static struct ordered_event* +ordered_events_get(struct ordered_events_queue *q, u64 timestamp) +{ +struct ordered_event *new; + +new = alloc_event(q); +if (new) { +

Re: [PATCH 05/18] perf tools: Add ordered_events_(get|put) interface

2014-06-29 Thread David Ahern
On 6/29/14, 10:39 AM, Jiri Olsa wrote: On Fri, Jun 27, 2014 at 05:06:36PM -0600, David Ahern wrote: On 6/18/14, 8:58 AM, Jiri Olsa wrote: +static struct ordered_event* +ordered_events_get(struct ordered_events_queue *q, u64 timestamp) +{ + struct ordered_event *new; + + new =

Re: [PATCH 05/18] perf tools: Add ordered_events_(get|put) interface

2014-06-27 Thread David Ahern
On 6/18/14, 8:58 AM, Jiri Olsa wrote: +static struct ordered_event* +ordered_events_get(struct ordered_events_queue *q, u64 timestamp) +{ + struct ordered_event *new; + + new = alloc_event(q); + if (new) { + new->timestamp = timestamp; +

Re: [PATCH 05/18] perf tools: Add ordered_events_(get|put) interface

2014-06-27 Thread David Ahern
On 6/18/14, 8:58 AM, Jiri Olsa wrote: +static struct ordered_event* +ordered_events_get(struct ordered_events_queue *q, u64 timestamp) +{ + struct ordered_event *new; + + new = alloc_event(q); + if (new) { + new-timestamp = timestamp; +

[PATCH 05/18] perf tools: Add ordered_events_(get|put) interface

2014-06-18 Thread Jiri Olsa
Adding new ordered events interface to get|put event buffer: ordered_events_get - allocate event buffer from the cache ordered_events_put - return event buffer to the cache Cc: Arnaldo Carvalho de Melo Cc: Corey Ashford Cc: David Ahern Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Jean

[PATCH 05/18] perf tools: Add ordered_events_(get|put) interface

2014-06-18 Thread Jiri Olsa
Adding new ordered events interface to get|put event buffer: ordered_events_get - allocate event buffer from the cache ordered_events_put - return event buffer to the cache Cc: Arnaldo Carvalho de Melo a...@kernel.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: David Ahern