RE: [PATCH 05/45] C++: Set compilation as C++ for .c files

2018-04-10 Thread Li, Philip
> > Hi David, > > On Tue, Apr 10, 2018 at 09:44:14AM +0100, David Howells wrote: > >Hi Fengguang, > > > >There's another kbuild test that's probably worth adding if you don't do it > >already: create a c++ source file that just #includes all the exported UAPI > >headers and then try to build it.

Re: [PATCH 05/45] C++: Set compilation as C++ for .c files

2018-04-10 Thread Fengguang Wu
Hi David, On Tue, Apr 10, 2018 at 09:44:14AM +0100, David Howells wrote: Hi Fengguang, There's another kbuild test that's probably worth adding if you don't do it already: create a c++ source file that just #includes all the exported UAPI headers and then try to build it. This should catch wor

Re: [PATCH 05/45] C++: Set compilation as C++ for .c files

2018-04-10 Thread David Howells
Hi Fengguang, There's another kbuild test that's probably worth adding if you don't do it already: create a c++ source file that just #includes all the exported UAPI headers and then try to build it. This should catch words like "private" cropping up in structs. Thanks, David

Re: [PATCH 05/45] C++: Set compilation as C++ for .c files

2018-04-03 Thread Fengguang Wu
On Tue, Apr 03, 2018 at 02:16:50PM +0100, David Howells wrote: kbuild test robot wrote: scripts/Makefile.kasan:17: Cannot use CONFIG_KASAN: -fsanitize=kernel-address is not supported by compiler cc1: warning: command line option '-fno-rtti' is valid for C++/ObjC++ but not for C cc1:

Re: [PATCH 05/45] C++: Set compilation as C++ for .c files

2018-04-03 Thread David Howells
kbuild test robot wrote: >scripts/Makefile.kasan:17: Cannot use CONFIG_KASAN: > -fsanitize=kernel-address is not supported by compiler >cc1: warning: command line option '-fno-rtti' is valid for C++/ObjC++ but > not for C >cc1: warning: command line option '-fpermissive' is valid fo

Re: [PATCH 05/45] C++: Set compilation as C++ for .c files

2018-04-01 Thread kbuild test robot
Hi David, I love your patch! Yet something to improve: [auto build test ERROR on v4.16-rc7] [cannot apply to linus/master tip/x86/core tip/locking/core v4.16 next-20180329] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github

Re: [PATCH 05/45] C++: Set compilation as C++ for .c files

2018-04-01 Thread kbuild test robot
Hi David, I love your patch! Yet something to improve: [auto build test ERROR on v4.16-rc7] [cannot apply to linus/master tip/x86/core tip/locking/core v4.16 next-20180329] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github

[PATCH 05/45] C++: Set compilation as C++ for .c files

2018-04-01 Thread David Howells
--- Makefile | 13 - arch/x86/Makefile |2 +- arch/x86/purgatory/Makefile |2 +- include/linux/types.h |4 scripts/checksyscalls.sh |2 +- tools/power/cpupower/Makefile |1 - tools/virtio/Makefile |