Re: [PATCH 06/17] staging: lustre: tidy up ldlm_resource_putref()

2018-03-30 Thread James Simmons
> 1/ the return value of ldlm_resource_putref() is never > used, so change it to return 'void'. > 2/ Move all of the code to run on the last putref to >__ldlm_resource_putref_final(). This means a lock >is taken in one function and dropped in another, but >that isn't too uncommon,

Re: [PATCH 06/17] staging: lustre: tidy up ldlm_resource_putref()

2018-03-30 Thread James Simmons
> 1/ the return value of ldlm_resource_putref() is never > used, so change it to return 'void'. > 2/ Move all of the code to run on the last putref to >__ldlm_resource_putref_final(). This means a lock >is taken in one function and dropped in another, but >that isn't too uncommon,

[PATCH 06/17] staging: lustre: tidy up ldlm_resource_putref()

2018-03-28 Thread NeilBrown
1/ the return value of ldlm_resource_putref() is never used, so change it to return 'void'. 2/ Move all of the code to run on the last putref to __ldlm_resource_putref_final(). This means a lock is taken in one function and dropped in another, but that isn't too uncommon, and will

[PATCH 06/17] staging: lustre: tidy up ldlm_resource_putref()

2018-03-28 Thread NeilBrown
1/ the return value of ldlm_resource_putref() is never used, so change it to return 'void'. 2/ Move all of the code to run on the last putref to __ldlm_resource_putref_final(). This means a lock is taken in one function and dropped in another, but that isn't too uncommon, and will