Re: [PATCH 06/20] IB/ipoib: drop useless LIST_HEAD

2019-01-02 Thread Jason Gunthorpe 
On Sun, Dec 23, 2018 at 09:57:01AM +0100, Julia Lawall wrote:
> Drop LIST_HEAD where the variable it declares is never used.
> 
> Commit 31c02e215700 ("IPoIB: Avoid using stale last_send counter
> when reaping AHs") removed the uses, but not the declaration.
> 
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // 
> @@
> identifier x;
> @@
> - LIST_HEAD(x);
>   ... when != x
> // 
> 
> Fixes: 31c02e215700 ("IPoIB: Avoid using stale last_send counter when reaping 
> AHs")
> Signed-off-by: Julia Lawall 
> Reviewed-by: Leon Romanovsky 
> ---
> Successfully 0-day tested on 151 configurations.
> 
>  drivers/infiniband/ulp/ipoib/ipoib_ib.c |1 -
>  1 file changed, 1 deletion(-)

Applied to rdma for-next thanks

Jason

Re: [PATCH 06/20] IB/ipoib: drop useless LIST_HEAD

2018-12-23 Thread Leon Romanovsky 
On Sun, Dec 23, 2018 at 09:57:01AM +0100, Julia Lawall wrote:
> Drop LIST_HEAD where the variable it declares is never used.
>
> Commit 31c02e215700 ("IPoIB: Avoid using stale last_send counter
> when reaping AHs") removed the uses, but not the declaration.
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // 
> @@
> identifier x;
> @@
> - LIST_HEAD(x);
>   ... when != x
> // 
>
> Fixes: 31c02e215700 ("IPoIB: Avoid using stale last_send counter when reaping 
> AHs")
> Signed-off-by: Julia Lawall 
>

Thanks,
Reviewed-by: Leon Romanovsky 


signature.asc
Description: PGP signature

[PATCH 06/20] IB/ipoib: drop useless LIST_HEAD

2018-12-23 Thread Julia Lawall 
Drop LIST_HEAD where the variable it declares is never used.

Commit 31c02e215700 ("IPoIB: Avoid using stale last_send counter
when reaping AHs") removed the uses, but not the declaration.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// 
@@
identifier x;
@@
- LIST_HEAD(x);
  ... when != x
// 

Fixes: 31c02e215700 ("IPoIB: Avoid using stale last_send counter when reaping 
AHs")
Signed-off-by: Julia Lawall 

---
Successfully 0-day tested on 151 configurations.

 drivers/infiniband/ulp/ipoib/ipoib_ib.c |1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ib.c 
b/drivers/infiniband/ulp/ipoib/ipoib_ib.c
index 6d35570092d6..78fa777c87b1 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_ib.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_ib.c
@@ -669,7 +669,6 @@ static void __ipoib_reap_ah(struct net_device *dev)
 {
struct ipoib_dev_priv *priv = ipoib_priv(dev);
struct ipoib_ah *ah, *tah;
-   LIST_HEAD(remove_list);
unsigned long flags;
 
netif_tx_lock_bh(dev);