Re: [PATCH 06/31] perf, kvm: Support the intx/intx_cp modifiers in KVM arch perfmon emulation

2012-10-03 Thread Avi Kivity
On 10/03/2012 02:11 PM, Andi Kleen wrote: >> > - eventsel & ARCH_PERFMON_EVENTSEL_INT); >> > + eventsel & ARCH_PERFMON_EVENTSEL_INT, >> > + !!(eventsel & HSW_INTX), >> > + !!(eventsel & HSW_INTX_CHECKPOINTED)); >> > } >> > >>

Re: [PATCH 06/31] perf, kvm: Support the intx/intx_cp modifiers in KVM arch perfmon emulation

2012-10-03 Thread Andi Kleen
> > - eventsel & ARCH_PERFMON_EVENTSEL_INT); > > + eventsel & ARCH_PERFMON_EVENTSEL_INT, > > + !!(eventsel & HSW_INTX), > > + !!(eventsel & HSW_INTX_CHECKPOINTED)); > > } > > > > Those !! are !necessary, since the formal

Re: [PATCH 06/31] perf, kvm: Support the intx/intx_cp modifiers in KVM arch perfmon emulation

2012-10-03 Thread Avi Kivity
On 10/03/2012 01:48 AM, Andi Kleen wrote: > From: Andi Kleen > > This is not arch perfmon, but older CPUs will just ignore it. This makes > it possible to do at least some TSX measurements from a KVM guest > > Cc: a...@redhat.com > Signed-off-by: Andi Kleen > --- > arch/x86/kvm/pmu.c | 13

Re: [PATCH 06/31] perf, kvm: Support the intx/intx_cp modifiers in KVM arch perfmon emulation

2012-10-03 Thread Avi Kivity
On 10/03/2012 01:48 AM, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com This is not arch perfmon, but older CPUs will just ignore it. This makes it possible to do at least some TSX measurements from a KVM guest Cc: a...@redhat.com Signed-off-by: Andi Kleen a...@linux.intel.com

Re: [PATCH 06/31] perf, kvm: Support the intx/intx_cp modifiers in KVM arch perfmon emulation

2012-10-03 Thread Andi Kleen
- eventsel ARCH_PERFMON_EVENTSEL_INT); + eventsel ARCH_PERFMON_EVENTSEL_INT, + !!(eventsel HSW_INTX), + !!(eventsel HSW_INTX_CHECKPOINTED)); } Those !! are !necessary, since the formal argument is a bool.

Re: [PATCH 06/31] perf, kvm: Support the intx/intx_cp modifiers in KVM arch perfmon emulation

2012-10-03 Thread Avi Kivity
On 10/03/2012 02:11 PM, Andi Kleen wrote: - eventsel ARCH_PERFMON_EVENTSEL_INT); + eventsel ARCH_PERFMON_EVENTSEL_INT, + !!(eventsel HSW_INTX), + !!(eventsel HSW_INTX_CHECKPOINTED)); } Those !! are

[PATCH 06/31] perf, kvm: Support the intx/intx_cp modifiers in KVM arch perfmon emulation

2012-10-02 Thread Andi Kleen
From: Andi Kleen This is not arch perfmon, but older CPUs will just ignore it. This makes it possible to do at least some TSX measurements from a KVM guest Cc: a...@redhat.com Signed-off-by: Andi Kleen --- arch/x86/kvm/pmu.c | 13 ++--- 1 files changed, 10 insertions(+), 3

[PATCH 06/31] perf, kvm: Support the intx/intx_cp modifiers in KVM arch perfmon emulation

2012-10-02 Thread Andi Kleen
From: Andi Kleen a...@linux.intel.com This is not arch perfmon, but older CPUs will just ignore it. This makes it possible to do at least some TSX measurements from a KVM guest Cc: a...@redhat.com Signed-off-by: Andi Kleen a...@linux.intel.com --- arch/x86/kvm/pmu.c | 13 ++--- 1