Re: [PATCH 07/10] block: kill merge_bvec_fn() completely

2015-05-06 Thread Ming Lin
On Wed, May 6, 2015 at 12:26 AM, Christoph Hellwig wrote: >> -static int chunk_aligned_read(struct mddev *mddev, struct bio * raid_bio) >> +static int __chunk_aligned_read(struct mddev *mddev, struct bio *raid_bio) > > Call it raid5_read_one_chunk or something similar descriptive? > >> { >>

Re: [PATCH 07/10] block: kill merge_bvec_fn() completely

2015-05-06 Thread Christoph Hellwig
> -static int chunk_aligned_read(struct mddev *mddev, struct bio * raid_bio) > +static int __chunk_aligned_read(struct mddev *mddev, struct bio *raid_bio) Call it raid5_read_one_chunk or something similar descriptive? > { > struct r5conf *conf = mddev->private; > int dd_idx; > @@

Re: [PATCH 07/10] block: kill merge_bvec_fn() completely

2015-05-06 Thread Ming Lin
On Mon, May 4, 2015 at 12:47 AM, Ming Lin wrote: > On 04/28/2015 03:09 PM, NeilBrown wrote: >> On Mon, 27 Apr 2015 23:48:34 -0700 Ming Lin wrote: >> >>> From: Kent Overstreet >>> >>> As generic_make_request() is now able to handle arbitrarily sized bios, >>> it's no longer necessary for each

Re: [PATCH 07/10] block: kill merge_bvec_fn() completely

2015-05-06 Thread Ming Lin
On Mon, May 4, 2015 at 12:47 AM, Ming Lin m...@kernel.org wrote: On 04/28/2015 03:09 PM, NeilBrown wrote: On Mon, 27 Apr 2015 23:48:34 -0700 Ming Lin m...@kernel.org wrote: From: Kent Overstreet kent.overstr...@gmail.com As generic_make_request() is now able to handle arbitrarily sized bios,

Re: [PATCH 07/10] block: kill merge_bvec_fn() completely

2015-05-06 Thread Christoph Hellwig
-static int chunk_aligned_read(struct mddev *mddev, struct bio * raid_bio) +static int __chunk_aligned_read(struct mddev *mddev, struct bio *raid_bio) Call it raid5_read_one_chunk or something similar descriptive? { struct r5conf *conf = mddev-private; int dd_idx; @@ -4718,7

Re: [PATCH 07/10] block: kill merge_bvec_fn() completely

2015-05-06 Thread Ming Lin
On Wed, May 6, 2015 at 12:26 AM, Christoph Hellwig h...@lst.de wrote: -static int chunk_aligned_read(struct mddev *mddev, struct bio * raid_bio) +static int __chunk_aligned_read(struct mddev *mddev, struct bio *raid_bio) Call it raid5_read_one_chunk or something similar descriptive? {

Re: [PATCH 07/10] block: kill merge_bvec_fn() completely

2015-05-04 Thread Ming Lin
On 04/28/2015 03:09 PM, NeilBrown wrote: > On Mon, 27 Apr 2015 23:48:34 -0700 Ming Lin wrote: > >> From: Kent Overstreet >> >> As generic_make_request() is now able to handle arbitrarily sized bios, >> it's no longer necessary for each individual block driver to define its >> own

Re: [PATCH 07/10] block: kill merge_bvec_fn() completely

2015-05-04 Thread Ming Lin
On 04/28/2015 03:09 PM, NeilBrown wrote: On Mon, 27 Apr 2015 23:48:34 -0700 Ming Lin m...@kernel.org wrote: From: Kent Overstreet kent.overstr...@gmail.com As generic_make_request() is now able to handle arbitrarily sized bios, it's no longer necessary for each individual block driver to

Re: [PATCH 07/10] block: kill merge_bvec_fn() completely

2015-04-29 Thread Ming Lin
On Tue, Apr 28, 2015 at 10:31 AM, Alasdair G Kergon wrote: > On Mon, Apr 27, 2015 at 11:48:34PM -0700, Ming Lin wrote: >> As generic_make_request() is now able to handle arbitrarily sized bios, >> it's no longer necessary for each individual block driver to define its >> own ->merge_bvec_fn()

Re: [PATCH 07/10] block: kill merge_bvec_fn() completely

2015-04-29 Thread Ming Lin
On Tue, Apr 28, 2015 at 10:31 AM, Alasdair G Kergon a...@redhat.com wrote: On Mon, Apr 27, 2015 at 11:48:34PM -0700, Ming Lin wrote: As generic_make_request() is now able to handle arbitrarily sized bios, it's no longer necessary for each individual block driver to define its own

Re: [PATCH 07/10] block: kill merge_bvec_fn() completely

2015-04-28 Thread NeilBrown
On Mon, 27 Apr 2015 23:48:34 -0700 Ming Lin wrote: > From: Kent Overstreet > > As generic_make_request() is now able to handle arbitrarily sized bios, > it's no longer necessary for each individual block driver to define its > own ->merge_bvec_fn() callback. Remove every invocation completely.

Re: [PATCH 07/10] block: kill merge_bvec_fn() completely

2015-04-28 Thread Alasdair G Kergon
On Mon, Apr 27, 2015 at 11:48:34PM -0700, Ming Lin wrote: > As generic_make_request() is now able to handle arbitrarily sized bios, > it's no longer necessary for each individual block driver to define its > own ->merge_bvec_fn() callback. Remove every invocation completely. merge_bvec_fn is also

[PATCH 07/10] block: kill merge_bvec_fn() completely

2015-04-28 Thread Ming Lin
From: Kent Overstreet As generic_make_request() is now able to handle arbitrarily sized bios, it's no longer necessary for each individual block driver to define its own ->merge_bvec_fn() callback. Remove every invocation completely. Cc: Jens Axboe Cc: Lars Ellenberg Cc:

Re: [PATCH 07/10] block: kill merge_bvec_fn() completely

2015-04-28 Thread NeilBrown
On Mon, 27 Apr 2015 23:48:34 -0700 Ming Lin m...@kernel.org wrote: From: Kent Overstreet kent.overstr...@gmail.com As generic_make_request() is now able to handle arbitrarily sized bios, it's no longer necessary for each individual block driver to define its own -merge_bvec_fn() callback.

Re: [PATCH 07/10] block: kill merge_bvec_fn() completely

2015-04-28 Thread Alasdair G Kergon
On Mon, Apr 27, 2015 at 11:48:34PM -0700, Ming Lin wrote: As generic_make_request() is now able to handle arbitrarily sized bios, it's no longer necessary for each individual block driver to define its own -merge_bvec_fn() callback. Remove every invocation completely. merge_bvec_fn is also

[PATCH 07/10] block: kill merge_bvec_fn() completely

2015-04-28 Thread Ming Lin
From: Kent Overstreet kent.overstr...@gmail.com As generic_make_request() is now able to handle arbitrarily sized bios, it's no longer necessary for each individual block driver to define its own -merge_bvec_fn() callback. Remove every invocation completely. Cc: Jens Axboe ax...@kernel.dk Cc: