Re: [PATCH 07/14] mm: consider zone which is not fully populated to have holes

2017-05-19 Thread Vlastimil Babka
On 05/18/2017 06:42 PM, Michal Hocko wrote: > On Thu 18-05-17 18:14:39, Vlastimil Babka wrote: >> On 05/15/2017 10:58 AM, Michal Hocko wrote: > [...] >>> #ifdef CONFIG_MEMORY_HOTPLUG >>> +/* >>> + * Return page for the valid pfn only if the page is online. All pfn >>> + * walkers which rely on

Re: [PATCH 07/14] mm: consider zone which is not fully populated to have holes

2017-05-19 Thread Vlastimil Babka
On 05/18/2017 06:42 PM, Michal Hocko wrote: > On Thu 18-05-17 18:14:39, Vlastimil Babka wrote: >> On 05/15/2017 10:58 AM, Michal Hocko wrote: > [...] >>> #ifdef CONFIG_MEMORY_HOTPLUG >>> +/* >>> + * Return page for the valid pfn only if the page is online. All pfn >>> + * walkers which rely on

Re: [PATCH 07/14] mm: consider zone which is not fully populated to have holes

2017-05-18 Thread Michal Hocko
On Thu 18-05-17 18:14:39, Vlastimil Babka wrote: > On 05/15/2017 10:58 AM, Michal Hocko wrote: [...] > > #ifdef CONFIG_MEMORY_HOTPLUG > > +/* > > + * Return page for the valid pfn only if the page is online. All pfn > > + * walkers which rely on the fully initialized page->flags and others > > +

Re: [PATCH 07/14] mm: consider zone which is not fully populated to have holes

2017-05-18 Thread Michal Hocko
On Thu 18-05-17 18:14:39, Vlastimil Babka wrote: > On 05/15/2017 10:58 AM, Michal Hocko wrote: [...] > > #ifdef CONFIG_MEMORY_HOTPLUG > > +/* > > + * Return page for the valid pfn only if the page is online. All pfn > > + * walkers which rely on the fully initialized page->flags and others > > +

Re: [PATCH 07/14] mm: consider zone which is not fully populated to have holes

2017-05-18 Thread Vlastimil Babka
On 05/15/2017 10:58 AM, Michal Hocko wrote: > From: Michal Hocko > > __pageblock_pfn_to_page has two users currently, set_zone_contiguous > which checks whether the given zone contains holes and > pageblock_pfn_to_page which then carefully returns a first valid > page from the

Re: [PATCH 07/14] mm: consider zone which is not fully populated to have holes

2017-05-18 Thread Vlastimil Babka
On 05/15/2017 10:58 AM, Michal Hocko wrote: > From: Michal Hocko > > __pageblock_pfn_to_page has two users currently, set_zone_contiguous > which checks whether the given zone contains holes and > pageblock_pfn_to_page which then carefully returns a first valid > page from the given pfn range

[PATCH 07/14] mm: consider zone which is not fully populated to have holes

2017-05-15 Thread Michal Hocko
From: Michal Hocko __pageblock_pfn_to_page has two users currently, set_zone_contiguous which checks whether the given zone contains holes and pageblock_pfn_to_page which then carefully returns a first valid page from the given pfn range for the given zone. This doesn't handle

[PATCH 07/14] mm: consider zone which is not fully populated to have holes

2017-05-15 Thread Michal Hocko
From: Michal Hocko __pageblock_pfn_to_page has two users currently, set_zone_contiguous which checks whether the given zone contains holes and pageblock_pfn_to_page which then carefully returns a first valid page from the given pfn range for the given zone. This doesn't handle zones which are