Re: [PATCH 07/19] gpio: bcm-kona: make use of raw_spinlock variants

2017-03-15 Thread Linus Walleij
On Fri, Mar 10, 2017 at 6:28 PM, Ray Jui wrote: > Is such API use change well accepted by the open source community already? The raw_*spinlock APIs are in the kernel header files and used at several sites in the kernel, so yes. Yours, Linus Walleij

Re: [PATCH 07/19] gpio: bcm-kona: make use of raw_spinlock variants

2017-03-15 Thread Linus Walleij
On Thu, Mar 9, 2017 at 5:21 PM, Julia Cartwright wrote: > The bcm-kona gpio driver currently implements an irq_chip for handling > interrupts; due to how irq_chip handling is done, it's necessary for the > irq_chip methods to be invoked from hardirq context, even on a a > real-time kernel. Becau

Re: [PATCH 07/19] gpio: bcm-kona: make use of raw_spinlock variants

2017-03-10 Thread Julia Cartwright
On Fri, Mar 10, 2017 at 09:28:08AM -0800, Ray Jui wrote: > Hi Julia/Linus, > > On 3/9/2017 8:21 AM, Julia Cartwright wrote: > > The bcm-kona gpio driver currently implements an irq_chip for handling > > interrupts; due to how irq_chip handling is done, it's necessary for the > > irq_chip methods to

Re: [PATCH 07/19] gpio: bcm-kona: make use of raw_spinlock variants

2017-03-10 Thread Ray Jui
Hi Julia/Linus, On 3/9/2017 8:21 AM, Julia Cartwright wrote: > The bcm-kona gpio driver currently implements an irq_chip for handling > interrupts; due to how irq_chip handling is done, it's necessary for the > irq_chip methods to be invoked from hardirq context, even on a a > real-time kernel. B

[PATCH 07/19] gpio: bcm-kona: make use of raw_spinlock variants

2017-03-09 Thread Julia Cartwright
The bcm-kona gpio driver currently implements an irq_chip for handling interrupts; due to how irq_chip handling is done, it's necessary for the irq_chip methods to be invoked from hardirq context, even on a a real-time kernel. Because the spinlock_t type becomes a "sleeping" spinlock w/ RT kernels