Re: [PATCH 07/20] platform: goldfish: pipe: Replace an array of 1 with a variable

2018-09-14 Thread Greg KH
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I

Re: [PATCH 07/20] platform: goldfish: pipe: Replace an array of 1 with a variable

2018-09-14 Thread Greg KH
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I

Re: [PATCH 07/20] platform: goldfish: pipe: Replace an array of 1 with a variable

2018-09-14 Thread Roman Kiryanov
Yes, in the later change I am going to retire this variable completely. Could you please accept this patch as it? On Fri, Sep 14, 2018 at 6:30 AM Greg KH wrote: > > On Mon, Aug 27, 2018 at 11:23:02AM -0700, r...@google.com wrote: > > From: Roman Kiryanov > > > > There is no reason to have an

Re: [PATCH 07/20] platform: goldfish: pipe: Replace an array of 1 with a variable

2018-09-14 Thread Roman Kiryanov
Yes, in the later change I am going to retire this variable completely. Could you please accept this patch as it? On Fri, Sep 14, 2018 at 6:30 AM Greg KH wrote: > > On Mon, Aug 27, 2018 at 11:23:02AM -0700, r...@google.com wrote: > > From: Roman Kiryanov > > > > There is no reason to have an

Re: [PATCH 07/20] platform: goldfish: pipe: Replace an array of 1 with a variable

2018-09-14 Thread Greg KH
On Mon, Aug 27, 2018 at 11:23:02AM -0700, r...@google.com wrote: > From: Roman Kiryanov > > There is no reason to have an array of 1. > > Signed-off-by: Roman Kiryanov > --- > drivers/platform/goldfish/goldfish_pipe.c | 28 +++ > 1 file changed, 13 insertions(+), 15

Re: [PATCH 07/20] platform: goldfish: pipe: Replace an array of 1 with a variable

2018-09-14 Thread Greg KH
On Mon, Aug 27, 2018 at 11:23:02AM -0700, r...@google.com wrote: > From: Roman Kiryanov > > There is no reason to have an array of 1. > > Signed-off-by: Roman Kiryanov > --- > drivers/platform/goldfish/goldfish_pipe.c | 28 +++ > 1 file changed, 13 insertions(+), 15

[PATCH 07/20] platform: goldfish: pipe: Replace an array of 1 with a variable

2018-08-27 Thread rkir
From: Roman Kiryanov There is no reason to have an array of 1. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 28 +++ 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c

[PATCH 07/20] platform: goldfish: pipe: Replace an array of 1 with a variable

2018-08-27 Thread rkir
From: Roman Kiryanov There is no reason to have an array of 1. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/goldfish_pipe.c | 28 +++ 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/drivers/platform/goldfish/goldfish_pipe.c