RE: [PATCH 07/83] drm/radeon: Add kfd-->kgd interface of locking srbm_gfx_cntl register

2014-07-11 Thread Bridgman, John
g, Christian >Subject: RE: [PATCH 07/83] drm/radeon: Add kfd-->kgd interface of locking >srbm_gfx_cntl register > >Checking... we shouldn't need to call the lock from kfd any more.We should >be able to do any required locking in radeon kgd code. Confirmed. The locking functions a

Recall: [PATCH 07/83] drm/radeon: Add kfd-->kgd interface of locking srbm_gfx_cntl register

2014-07-11 Thread Bridgman, John
Bridgman, John would like to recall the message, "[PATCH 07/83] drm/radeon: Add kfd-->kgd interface of locking srbm_gfx_cntl register".-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

RE: [PATCH 07/83] drm/radeon: Add kfd-->kgd interface of locking srbm_gfx_cntl register

2014-07-11 Thread Bridgman, John
o: 'Jerome Glisse'; Oded Gabbay >Cc: David Airlie; Deucher, Alexander; linux-kernel@vger.kernel.org; dri- >de...@lists.freedesktop.org; Lewycky, Andrew; Joerg Roedel; Gabbay, Oded; >Koenig, Christian >Subject: RE: [PATCH 07/83] drm/radeon: Add kfd-->kgd interface of locking >srb

RE: [PATCH 07/83] drm/radeon: Add kfd-->kgd interface of locking srbm_gfx_cntl register

2014-07-11 Thread Bridgman, John
Airlie; Deucher, Alexander; linux-kernel@vger.kernel.org; dri- >de...@lists.freedesktop.org; Bridgman, John; Lewycky, Andrew; Joerg >Roedel; Gabbay, Oded; Koenig, Christian >Subject: Re: [PATCH 07/83] drm/radeon: Add kfd-->kgd interface of locking >srbm_gfx_cntl register > >On Fri, Ju

Re: [PATCH 07/83] drm/radeon: Add kfd-->kgd interface of locking srbm_gfx_cntl register

2014-07-11 Thread Jerome Glisse
On Fri, Jul 11, 2014 at 12:50:07AM +0300, Oded Gabbay wrote: > This patch adds a new interface to kfd2kgd_calls structure, which > allows the kfd to lock and unlock the srbm_gfx_cntl register Why does kfd needs to lock this register if kfd can not access any of those register ? This sounds broken

Re: [PATCH 07/83] drm/radeon: Add kfd--kgd interface of locking srbm_gfx_cntl register

2014-07-11 Thread Jerome Glisse
On Fri, Jul 11, 2014 at 12:50:07AM +0300, Oded Gabbay wrote: This patch adds a new interface to kfd2kgd_calls structure, which allows the kfd to lock and unlock the srbm_gfx_cntl register Why does kfd needs to lock this register if kfd can not access any of those register ? This sounds broken

RE: [PATCH 07/83] drm/radeon: Add kfd--kgd interface of locking srbm_gfx_cntl register

2014-07-11 Thread Bridgman, John
; linux-kernel@vger.kernel.org; dri- de...@lists.freedesktop.org; Bridgman, John; Lewycky, Andrew; Joerg Roedel; Gabbay, Oded; Koenig, Christian Subject: Re: [PATCH 07/83] drm/radeon: Add kfd--kgd interface of locking srbm_gfx_cntl register On Fri, Jul 11, 2014 at 12:50:07AM +0300, Oded Gabbay wrote

RE: [PATCH 07/83] drm/radeon: Add kfd--kgd interface of locking srbm_gfx_cntl register

2014-07-11 Thread Bridgman, John
; Deucher, Alexander; linux-kernel@vger.kernel.org; dri- de...@lists.freedesktop.org; Lewycky, Andrew; Joerg Roedel; Gabbay, Oded; Koenig, Christian Subject: RE: [PATCH 07/83] drm/radeon: Add kfd--kgd interface of locking srbm_gfx_cntl register Checking... we shouldn't need to call the lock from kfd any

Recall: [PATCH 07/83] drm/radeon: Add kfd--kgd interface of locking srbm_gfx_cntl register

2014-07-11 Thread Bridgman, John
Bridgman, John would like to recall the message, [PATCH 07/83] drm/radeon: Add kfd--kgd interface of locking srbm_gfx_cntl register.-- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

RE: [PATCH 07/83] drm/radeon: Add kfd--kgd interface of locking srbm_gfx_cntl register

2014-07-11 Thread Bridgman, John
: [PATCH 07/83] drm/radeon: Add kfd--kgd interface of locking srbm_gfx_cntl register Checking... we shouldn't need to call the lock from kfd any more.We should be able to do any required locking in radeon kgd code. Confirmed. The locking functions are removed from the interface in commit 82 : [PATCH

[PATCH 07/83] drm/radeon: Add kfd-->kgd interface of locking srbm_gfx_cntl register

2014-07-10 Thread Oded Gabbay
This patch adds a new interface to kfd2kgd_calls structure, which allows the kfd to lock and unlock the srbm_gfx_cntl register Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/radeon_kfd.c | 20 include/linux/radeon_kfd.h | 4 2 files changed, 24

[PATCH 07/83] drm/radeon: Add kfd--kgd interface of locking srbm_gfx_cntl register

2014-07-10 Thread Oded Gabbay
This patch adds a new interface to kfd2kgd_calls structure, which allows the kfd to lock and unlock the srbm_gfx_cntl register Signed-off-by: Oded Gabbay oded.gab...@amd.com --- drivers/gpu/drm/radeon/radeon_kfd.c | 20 include/linux/radeon_kfd.h | 4 2 files